| Sgs | |
| Nov 28 2023, 6:17 PM |
| F41615276: Screen Shot 2023-12-20 at 6.20.06 PM.png | |
| Dec 21 2023, 2:21 AM |
| F41601089: Screen Shot 2023-12-14 at 2.25.52 PM.png | |
| Dec 14 2023, 11:12 PM |
| F41543863: Screenshot 2023-11-13 at 17.36.10.png | |
| Nov 28 2023, 6:17 PM |
Steps to replicate the issue (include links if applicable):
See parent task.
What happens?:
The image placeholder shows as a thin line rather than square
What should have happened instead?:
The image placeholder should have appropriate dimensions for phone and tablet screens
Software version (skip for WMF-hosted wikis like Wikipedia):
Other information (browser name/version, screenshots, etc.):
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | BUG REPORT | Sgs | T348362 [wmf.29] [mobile] Section level image placeholder displays an additional visual element | ||
| Resolved | BUG REPORT | Sgs | T352208 [wmf.29] [mobile] Section level image placeholder has no width |
Change 973834 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] Section images: do not use 0 width values for calculating placeholder width
Test wiki created on Patch demo by Martin Urbanec (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/b20d1ca6be/w
Change 973834 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Section images: on mobile use overlay width for setting the image width
Change 983761 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] Section images: adjust placeholder width in narrow screens
Change 983761 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Section images: adjust placeholder width in narrow screens
Checked on cswiki wmf.12 - the issue is fixed.
Checked in beta - the placeholder doesn't quite fit viewport widths with <390px:
Checked in beta - the issue is fixed.
Test wiki on Patch demo by Martin Urbanec (WMF) using patch(es) linked to this task was deleted:
