Page MenuHomePhabricator

Upstream codesniffer gets renamed from squizlabs/php_codesniffer to PHPCSStandards/PHP_CodeSniffer
Closed, DeclinedPublic

Description

The repo gets a new company, read more at https://github.com/squizlabs/PHP_CodeSniffer/issues/3932

https://github.com/PHPCSStandards/PHP_CodeSniffer

Upstream PR and issues needs to be recreated and mediawiki/codesniffer needs to use the new company with the next upstream release.

Event Timeline

Change 979415 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/tools/codesniffer@master] build: Switch renamed upstream phpcsstandards/php_codesniffer package

https://gerrit.wikimedia.org/r/979415

It seems that this is solved by changing the repo on packagist to point to the new one, so everything can stay from the composer view - https://packagist.org/packages/squizlabs/php_codesniffer

There is also a new release 3.8.0 - https://github.com/PHPCSStandards/PHP_CodeSniffer/releases/tag/3.8.0

But the open issues upstream needs to be revisited and, if still relevant, needs recreated in the new repo/issue tracker.

Just a notice about a proposal about further "informing external standards" which came up with the new maintenance - https://github.com/PHPCSStandards/PHP_CodeSniffer/issues/227

Change 979415 abandoned by Umherirrender:

[mediawiki/tools/codesniffer@master] build: Switch renamed upstream phpcsstandards/php_codesniffer package

Reason:

No rename needed

https://gerrit.wikimedia.org/r/979415

It seems that this is solved by changing the repo on packagist to point to the new one, so everything can stay from the composer view - https://packagist.org/packages/squizlabs/php_codesniffer

Aha, that's very helpful.

Are they going to re-namespace the code? If so that's going to be a messy migration, as evidenced from my migration patch that you've just abandoned.