Page MenuHomePhabricator
Create Task
Maniphest T352739

cxserver: Cannot read properties of undefined (reading 'pages')
Closed, ResolvedPublic
Actions

Description

This is occurring in cxserver log since couple of days:

Full error:

TypeError: Cannot read properties of undefined (reading 'pages')
    at processResult (/srv/service/lib/mw/BatchedAPIRequest.js:85:23)
    at tryCatcher (/srv/service/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/srv/service/node_modules/bluebird/js/release/promise.js:547:31)
    at Promise._settlePromise (/srv/service/node_modules/bluebird/js/release/promise.js:604:18)
    at Promise._settlePromise0 (/srv/service/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/srv/service/node_modules/bluebird/js/release/promise.js:729:18)
    at _drainQueueStep (/srv/service/node_modules/bluebird/js/release/async.js:93:12)
    at _drainQueue (/srv/service/node_modules/bluebird/js/release/async.js:86:9)
    at Async._drainQueues (/srv/service/node_modules/bluebird/js/release/async.js:102:5)
    at Async.drainQueues [as _onImmediate] (/srv/service/node_modules/bluebird/js/release/async.js:15:14)
    at process.processImmediate (node:internal/timers:471:21)

Logstash URL: https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-k8s-1-7.0.0-1-2023.12.05?id=P_GjOIwBySCoT0gdG8PH

Impact: Unknown.

Details

SubjectRepoBranchLines +/-
Update cxserver to 2024-03-20-072017-productionoperations/deployment-chartsmaster+1 -1
BatchedAPIRequest: Prevent javascript errors, handle redirects bettermediawiki/services/cxservermaster+20 -13
Customize query in gerrit

Event Timeline

KartikMistry created this task.Dec 5 2023, 8:12 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 5 2023, 8:12 AM
KartikMistry added a comment.Dec 11 2023, 6:24 AM

This seems related, "Non-string title for normalizeTitle: undefined": https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-k8s-1-7.0.0-1-2023.12.11?id=rMeCV4wBySCoT0gdO2N7

santhosh added a comment.EditedMar 18 2024, 11:16 AM

After the migration to node fetch, the error is still there:

	TypeError: Cannot read properties of undefined (reading 'pages')
    at processResult (/srv/service/lib/mw/BatchedAPIRequest.js:85:23)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Example

About 9 instances in an hour. we should fix this

KartikMistry added a comment.Mar 18 2024, 12:20 PM
In T352739#9395538, @KartikMistry wrote:

This seems related, "Non-string title for normalizeTitle: undefined": https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-k8s-1-7.0.0-1-2023.12.11?id=rMeCV4wBySCoT0gdO2N7

@santhosh Similarly, https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-k8s-1-7.0.0-1-2024.03.18?id=rU15UY4BWjhRzdxn0uML is happening with it.

gerritbot added a comment.Mar 19 2024, 5:15 AM

Change 1012464 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/services/cxserver@master] BatchedAPIRequest: Prevent javascript errors, handle redirects better

https://gerrit.wikimedia.org/r/1012464

gerritbot added a project: Patch-For-Review.Mar 19 2024, 5:15 AM
santhosh claimed this task.Mar 19 2024, 5:16 AM
santhosh added projects: Language-Team (Language-2024-January-March), Unplanned-Sprint-Work.
KartikMistry moved this task from Quarter Backlog to In Review on the Language-Team (Language-2024-January-March) board.Mar 19 2024, 7:20 AM
gerritbot added a comment.Mar 20 2024, 7:19 AM

Change 1012464 merged by jenkins-bot:

[mediawiki/services/cxserver@master] BatchedAPIRequest: Prevent javascript errors, handle redirects better

https://gerrit.wikimedia.org/r/1012464

Maintenance_bot removed a project: Patch-For-Review.Mar 20 2024, 7:30 AM
Nikerabbit moved this task from In Review to Check after deployment on the Language-Team (Language-2024-January-March) board.Mar 20 2024, 7:41 AM
gerritbot added a comment.Mar 20 2024, 1:20 PM

Change 1013047 had a related patch set uploaded (by KartikMistry; author: KartikMistry):

[operations/deployment-charts@master] Update cxserver to 2024-03-20-072017-production

https://gerrit.wikimedia.org/r/1013047

gerritbot added a project: Patch-For-Review.Mar 20 2024, 1:20 PM
gerritbot added a comment.Mar 21 2024, 5:28 AM

Change 1013047 merged by jenkins-bot:

[operations/deployment-charts@master] Update cxserver to 2024-03-20-072017-production

https://gerrit.wikimedia.org/r/1013047

Maintenance_bot removed a project: Patch-For-Review.Mar 21 2024, 5:30 AM
Stashbot added a comment.Mar 21 2024, 5:36 AM

Mentioned in SAL (#wikimedia-operations) [2024-03-21T05:36:26Z] <kart_> Updated cxserver to 2024-03-20-072017-production (T352739)

KartikMistry added a comment.Mar 21 2024, 11:35 AM

This error no longer happening in production.

KartikMistry moved this task from Check after deployment to Done on the Language-Team (Language-2024-January-March) board.Mar 21 2024, 11:35 AM
Pginer-WMF closed this task as Resolved.Mar 27 2024, 1:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits