Page MenuHomePhabricator
Create Task
Maniphest T353163

Creation of dynamic property File_Ogg_Theora::$_firstGranulePos is deprecated
Closed, ResolvedPublic
Actions

Description

Seen on phpunit under php8.2 for TimedMediaHandler

7) OggHandlerTest::testGetStreamTypes with data set #1 ('bunny.stereo.audio.opus', 'application/ogg', array('audio/ogg; codecs="opus"', array('Opus'), false, true, 2, array(array('Lavf59.27.100', 'Lavc59.37.100 libopus'), array('Big Buck Bunny, Sunflower version'))))
Creation of dynamic property File_Ogg_Opus::$_firstGranulePos is deprecated

/workspace/src/extensions/TimedMediaHandler/includes/Handlers/OggHandler/File_Ogg/File/Ogg/Bitstream.php:80
/workspace/src/extensions/TimedMediaHandler/includes/Handlers/OggHandler/File_Ogg/File/Ogg/Opus.php:44
/workspace/src/extensions/TimedMediaHandler/includes/Handlers/OggHandler/File_Ogg/File/Ogg.php:495
/workspace/src/extensions/TimedMediaHandler/includes/Handlers/OggHandler/File_Ogg/File/Ogg.php:210
/workspace/src/extensions/TimedMediaHandler/includes/Handlers/OggHandler/OggHandler.php:26
/workspace/src/includes/media/MediaHandler.php:242
/workspace/src/includes/filerepo/file/UnregisteredLocalFile.php:202
/workspace/src/includes/filerepo/file/UnregisteredLocalFile.php:193
/workspace/src/extensions/TimedMediaHandler/includes/Handlers/OggHandler/OggHandler.php:238
/workspace/src/extensions/TimedMediaHandler/tests/phpunit/TimedMediaHandlerTestCase.php:28

Details

SubjectRepoBranchLines +/-
Declare forgotten member variables in Bitstreammediawiki/extensions/TimedMediaHandlerREL1_41+170 -8
Declare forgotten member variables in Bitstreammediawiki/extensions/TimedMediaHandlerREL1_39+170 -8
Declare forgotten member variables in Bitstreammediawiki/extensions/TimedMediaHandlerREL1_40+170 -8
Declare forgotten member variables in Bitstreammediawiki/extensions/TimedMediaHandlermaster+170 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

Umherirrender created this task.Dec 11 2023, 4:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 11 2023, 4:01 PM
Umherirrender moved this task from Backlog to Wikimedia production on the PHP 8.2 support board.Dec 12 2023, 12:09 PM
Umherirrender mentioned this in T352085: Make PHP 8.2 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries).Dec 12 2023, 12:17 PM
• brooke claimed this task.Dec 12 2023, 4:46 PM
gerritbot added a comment.Dec 12 2023, 4:51 PM

Change 982435 had a related patch set uploaded (by Brion VIBBER; author: Brion VIBBER):

[mediawiki/extensions/TimedMediaHandler@master] Declare forgotten member variables in Bitstream

https://gerrit.wikimedia.org/r/982435

gerritbot added a project: Patch-For-Review.Dec 12 2023, 4:51 PM
Reedy added a parent task: T314099: PHP 8.2: Dynamic property creation is deprecated.Dec 18 2023, 10:44 PM
gerritbot added a comment.Jan 17 2024, 10:07 PM

Change 982435 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Declare forgotten member variables in Bitstream

https://gerrit.wikimedia.org/r/982435

Maintenance_bot removed a project: Patch-For-Review.Jan 17 2024, 10:31 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.15; 2024-01-23).Jan 17 2024, 11:00 PM
TheDJ subscribed.Jan 18 2024, 8:24 AM

Reminder to self: should be backported before this is closed

gerritbot added a comment.Jan 18 2024, 6:13 PM

Change 991556 had a related patch set uploaded (by Jforrester; author: Brion VIBBER):

[mediawiki/extensions/TimedMediaHandler@REL1_41] Declare forgotten member variables in Bitstream

https://gerrit.wikimedia.org/r/991556

gerritbot added a project: Patch-For-Review.Jan 18 2024, 6:13 PM

Change 991557 had a related patch set uploaded (by Jforrester; author: Brion VIBBER):

[mediawiki/extensions/TimedMediaHandler@REL1_40] Declare forgotten member variables in Bitstream

https://gerrit.wikimedia.org/r/991557

gerritbot added a comment.Jan 18 2024, 6:13 PM

Change 991558 had a related patch set uploaded (by Jforrester; author: Brion VIBBER):

[mediawiki/extensions/TimedMediaHandler@REL1_39] Declare forgotten member variables in Bitstream

https://gerrit.wikimedia.org/r/991558

gerritbot added a comment.Jan 18 2024, 8:29 PM

Change 991557 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@REL1_40] Declare forgotten member variables in Bitstream

https://gerrit.wikimedia.org/r/991557

gerritbot added a comment.Jan 18 2024, 8:29 PM

Change 991558 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@REL1_39] Declare forgotten member variables in Bitstream

https://gerrit.wikimedia.org/r/991558

gerritbot added a comment.Jan 18 2024, 8:30 PM

Change 991556 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@REL1_41] Declare forgotten member variables in Bitstream

https://gerrit.wikimedia.org/r/991556

Maintenance_bot removed a project: Patch-For-Review.Jan 18 2024, 8:30 PM
Jdforrester-WMF closed this task as Resolved.Jan 18 2024, 8:48 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits