Modernise TranslateMetadata::class to an injectable service
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

Subtask of T193166. As this class requires a bit more attention and many changes, the patch related would have been outside the scope of generally modernizing code. This ticket proposes tracking these changes on a different task.

Details

Subject	Repo	Branch	Lines +/-
Merge branch 'master' into wmf_deploy	mediawiki/extensions/CentralNotice	wmf_deploy	+0 -0
Banner: Drop references to old TranslateMetadata class to make phan happy	mediawiki/extensions/CentralNotice	master	+18 -50
TranslateMetadata: Rename to MessageGroupMetadata and convert to service	mediawiki/extensions/Translate	master	+254 -182
Update reference to namespaced MessageGroupMetadata::class	mediawiki/extensions/CentralNotice	master	+58 -19

Customize query in gerrit

Related Objects

Mentioned Here: T193166: Adopt PSR-4 namespaces in Translate and modernize code

Event Timeline

Wangombe created this task.Dec 14 2023, 8:13 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 14 2023, 8:13 AM

Wangombe renamed this task from Modernise to Modernise TranslateMetadata::class to an injectable service.Dec 14 2023, 8:18 AM

Wangombe changed the task status from Open to In Progress.

Wangombe claimed this task.

Wangombe added projects: MediaWiki-extensions-Translate, Language-Team (Language-2023-October-December).

Wangombe updated the task description. (Show Details)

Wangombe moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2023-October-December) board.

Wangombe added subscribers: abi_, • Nikerabbit.

Pginer-WMF triaged this task as Medium priority.Dec 14 2023, 9:17 AM

Change 982182 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Convert TranslateMetadata::class to a service

https://gerrit.wikimedia.org/r/982182

gerritbot added a project: Patch-For-Review.Dec 18 2023, 10:31 AM

abi_ set the point value for this task to 4.Dec 20 2023, 6:44 AM

abi_ moved this task from In Progress to In Review on the Language-Team (Language-2023-October-December) board.

• Nikerabbit added a project: Localization Infrastructure FY2023-24.Jan 8 2024, 7:46 AM

• Nikerabbit moved this task from Backlog to Support (LM) on the Localization Infrastructure FY2023-24 board.Jan 8 2024, 9:55 AM

Pginer-WMF edited projects, added Language-Team (Language-2024-January-March); removed Language-Team (Language-2023-October-December).Jan 8 2024, 10:36 AM

Pginer-WMF moved this task from Quarter Backlog to In Review on the Language-Team (Language-2024-January-March) board.

• Nikerabbit moved this task from Backlog to group management on the MediaWiki-extensions-Translate board.Jan 15 2024, 11:41 AM

Change 980983 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/CentralNotice@master] Update reference to namespaced MessageGroupMetadata::class

https://gerrit.wikimedia.org/r/980983

Change 980983 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Update reference to namespaced MessageGroupMetadata::class

https://gerrit.wikimedia.org/r/980983

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.19; 2024-02-20).Feb 14 2024, 3:00 PM

We're waiting for MediaWiki-extensions-CentralNotice patch to be deployed on production before we can merge the patch for this task.

abi_ changed the task status from Stalled to In Progress.Apr 2 2024, 8:20 AM

abi_ moved this task from Blocked to In Progress on the Language-Team (Language-2024-January-March) board.

Pginer-WMF edited projects, added Language-Team (Language-2024-April-June); removed Language-Team (Language-2024-January-March).Apr 2 2024, 3:24 PM

Pginer-WMF moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2024-April-June) board.

abi_ moved this task from In Progress to In Review on the Language-Team (Language-2024-April-June) board.Apr 3 2024, 9:15 AM

Change #982182 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslateMetadata: Rename to MessageGroupMetadata and convert to service

https://gerrit.wikimedia.org/r/982182

Maintenance_bot removed a project: Patch-For-Review.Apr 3 2024, 12:30 PM

Change #1016843 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/CentralNotice@master] Banner: Drop references to old TranslateMetadata class to make phan happy

https://gerrit.wikimedia.org/r/1016843

gerritbot added a project: Patch-For-Review.Apr 3 2024, 7:49 PM

abi_ moved this task from In Review to Check after deployment on the Language-Team (Language-2024-April-June) board.Apr 9 2024, 1:18 PM

The relevant patch: 982182: TranslateMetadata: Rename to MessageGroupMetadata and convert to service | https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/982182 was deployed along with the train this week. We did not notice any issues.

There is a patch for Central notice extension (1016843: Banner: Drop references to old TranslateMetadata class to make phan happy | https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/1016843) remove backward compatibility code, but we need not keep this task open for that.

Change #1052668 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/CentralNotice@wmf_deploy] Merge branch 'master' into wmf_deploy

https://gerrit.wikimedia.org/r/1052668

Change #1052668 merged by jenkins-bot: