Page MenuHomePhabricator
Create Task
Maniphest T193166

Adopt PSR-4 namespaces in Translate and modernize code
Open, MediumPublic
Actions

Description

Manually keeping autoloader class names up to date time consuming and unnecessary burden. Additionally it bloats extensions.json which can get thousands of lines long. Replacing the autoloader section with simple PSR-4 declaration makes it shorter.

Slightly more complicated is to not break other code using Translate's classes, mainly TranslateSVG and CentralNotice come to my mind.

The initial plan for namespace structure is documented in https://www.mediawiki.org/wiki/Extension:Translate/Namespaces

Details

Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT182943 Move namespaced extensions to use PSR-4 autoloading
 OpenNoneT278278 Adopt PSR-4 namespaces in WMF-deployed extensions/skins
 OpenNoneT193166 Adopt PSR-4 namespaces in Translate and modernize code
 Resolvedabi_T267100 Move insertables to the src/ folder.
 Resolvedabi_T299019 Move SpecialPages to namespace and use service injection
 Resolvedabi_T299022 Move webservice consumers to namespace and use service injection
ResolvedWangombeT308513 Namespace classes inside the util folder
 ResolvedWangombeT312006 Move classes under tag folder to namespace
 ResolvedPRODUCTION ERRORabi_T315889 Error: Class 'TranslatablePage' not found
 ResolvedBUG REPORTabi_T315708 Edits to translated pages left unpatrolled
 ResolvedPRODUCTION ERROR• UrbanecmT315657 Fatal exception of type "TypeError" from TranslatableBundleLogFormatter.php
 ResolvedPRODUCTION ERRORUmherirrenderT315412 TypeError: Return value of MediaWiki\Extension\Translate\PageTranslation\RenderTranslationPageJob::getUser() must be an instance of User, null returned
 ResolvedBUG REPORT• NikerabbitT318484 Translate job execution time seems to have significantly increase
 Resolvedabi_T312007 Remove the RevTag class
 ResolvedWangombeT312008 Move classes under api folder to namespace
 ResolvedPRODUCTION ERRORabi_T313836 MediaWiki\Extension\Translate\TtmServer\ServiceCreationFailure: Unknown type for name 'Apertium': cxserver
 ResolvedPRODUCTION ERRORabi_T313608 Marking translations as reviewed fails
 ResolvedBUG REPORTabi_T315726 Translation sandbox on translatewiki doesn't offer any test translations
 ResolvedWangombeT313242 Move classes in the Translate root directory to namespace
 ResolvedNoneT327712 Review CentralNotice patch for Translate namespace change
 ResolvedWangombeT333820 Modernize code under ffs/ directory
In ProgressWangombeT335342 Modernize code under ttmserver/ directory
ResolvedWangombeT340724 Modernize code under util/ directory
ResolvedWangombeT348496 Modernize code under util/ directory starting with T*
 OpenNoneT340723 Modernize code under messagegroups/ directory
OpenNoneT340725 Move renaming i18n files in the Translate root directory under i18n

Event Timeline

• Nikerabbit created this task.Apr 26 2018, 2:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2018, 2:38 PM
• Nikerabbit triaged this task as Medium priority.Apr 26 2018, 2:38 PM
• Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.
• Nikerabbit updated the task description. (Show Details)
• Vvjjkkii renamed this task from Convert Translate to PSR-4 to l5daaaaaaa.Jul 1 2018, 1:13 AM
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
Yann renamed this task from l5daaaaaaa to Convert Translate to PSR-4.Jul 1 2018, 12:06 PM
Yann lowered the priority of this task from High to Medium.
Yann updated the task description. (Show Details)
Yann removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Yann added a subscriber: Aklapper.
awight subscribed.Jun 10 2019, 2:02 PM
awight mentioned this in T221913: Translate coverage publish step fails with: Incorrect whitelist config, no code coverage will be generated..Jun 10 2019, 8:35 PM
abi_ closed subtask T267100: Move insertables to the src/ folder. as Resolved.Dec 17 2020, 9:37 AM
Reedy added a parent task: T182943: Move namespaced extensions to use PSR-4 autoloading.Mar 24 2021, 12:26 AM
Reedy added a parent task: T278278: Adopt PSR-4 namespaces in WMF-deployed extensions/skins.
gerritbot added a comment.Sep 29 2021, 4:48 PM

Change 724782 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] TranslationAid: Move into namespace

https://gerrit.wikimedia.org/r/724782

gerritbot added a project: Patch-For-Review.Sep 29 2021, 4:48 PM
gerritbot added a comment.Sep 30 2021, 3:14 PM

Change 725017 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] ApiTranslationAids: Move to namespace

https://gerrit.wikimedia.org/r/725017

gerritbot added a comment.Oct 4 2021, 7:48 AM

Change 724782 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslationAid: Move into namespace

https://gerrit.wikimedia.org/r/724782

gerritbot added a comment.Oct 4 2021, 7:49 AM

Change 725017 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] ApiTranslationAids: Move to namespace

https://gerrit.wikimedia.org/r/725017

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Oct 4 2021, 8:00 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 4 2021, 8:10 AM
gerritbot added a comment.Nov 2 2021, 6:07 AM

Change 735936 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Move StringMangler & StringMatcher to namespace

https://gerrit.wikimedia.org/r/735936

gerritbot added a project: Patch-For-Review.Nov 2 2021, 6:07 AM
gerritbot added a comment.Nov 2 2021, 9:53 AM

Change 736194 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] ArrayFlattener: Add strict types

https://gerrit.wikimedia.org/r/736194

gerritbot added a comment.Nov 2 2021, 10:48 AM

Change 736202 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] ArrayFlattener: Move to namespace

https://gerrit.wikimedia.org/r/736202

gerritbot added a comment.Nov 2 2021, 1:09 PM

Change 736229 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] TranslateReplaceTitle: Move to appropriate namespace

https://gerrit.wikimedia.org/r/736229

gerritbot added a comment.Nov 3 2021, 7:32 AM

Change 735936 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Move StringMangler & StringMatcher to namespace

https://gerrit.wikimedia.org/r/735936

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.9; 2021-11-16); removed MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Nov 3 2021, 8:00 AM
gerritbot added a comment.Nov 3 2021, 8:12 AM

Change 736194 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] ArrayFlattener: Add strict types

https://gerrit.wikimedia.org/r/736194

gerritbot added a comment.Nov 3 2021, 8:24 AM

Change 736202 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] ArrayFlattener: Move to namespace

https://gerrit.wikimedia.org/r/736202

gerritbot added a comment.Nov 10 2021, 8:00 AM

Change 736229 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslateReplaceTitle: Move to appropriate namespace

https://gerrit.wikimedia.org/r/736229

abi_ added a subtask: T299019: Move SpecialPages to namespace and use service injection.Jan 12 2022, 5:53 AM
abi_ added a subtask: T299022: Move webservice consumers to namespace and use service injection .
abi_ changed the status of subtask T299019: Move SpecialPages to namespace and use service injection from Open to In Progress.Feb 1 2022, 12:39 PM
Reedy removed a project: Patch-For-Review.Feb 6 2022, 9:51 PM
abi_ closed subtask T299019: Move SpecialPages to namespace and use service injection as Resolved.Mar 3 2022, 4:56 AM
abi_ closed subtask T299022: Move webservice consumers to namespace and use service injection as Resolved.Apr 19 2022, 3:52 AM
abi_ added a subtask: T308513: Namespace classes inside the util folder.May 17 2022, 5:22 AM
Wangombe changed the status of subtask T308513: Namespace classes inside the util folder from Open to In Progress.May 18 2022, 5:30 AM
• Nikerabbit closed subtask T308513: Namespace classes inside the util folder as Resolved.Jun 9 2022, 2:52 PM
Tacsipacsi mentioned this in T230894: Move Translate PHP classes to includes/.Jul 18 2022, 4:03 PM
• Nikerabbit removed a parent task: T182943: Move namespaced extensions to use PSR-4 autoloading.Jul 28 2022, 8:34 AM
• Nikerabbit renamed this task from Convert Translate to PSR-4 to Adopt PSR-4 namespaces in Translate.Jul 28 2022, 8:38 AM
• Nikerabbit edited projects, added Epic; removed MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).
• Nikerabbit updated the task description. (Show Details)
Wangombe closed subtask T312008: Move classes under api folder to namespace as Resolved.Aug 2 2022, 6:29 AM
• Nikerabbit closed subtask T312006: Move classes under tag folder to namespace as Resolved.Sep 14 2022, 7:42 AM
Tacsipacsi mentioned this in T313242: Move classes in the Translate root directory to namespace.Oct 3 2022, 6:21 PM
abi_ closed subtask T312007: Remove the RevTag class as Resolved.Oct 7 2022, 1:55 PM
gerritbot added a comment.Dec 20 2022, 12:07 PM

Change 869743 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] processMessageChanges: Rename and move to namespace

https://gerrit.wikimedia.org/r/869743

gerritbot added a project: Patch-For-Review.Dec 20 2022, 12:07 PM
gerritbot added a comment.Dec 20 2022, 12:17 PM

Change 869745 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[translatewiki@master] Rename processMessageChanges to importExternalTranslations

https://gerrit.wikimedia.org/r/869745

gerritbot added a comment.Dec 20 2022, 12:19 PM

Change 869746 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Remove processMessageChanges

https://gerrit.wikimedia.org/r/869746

gerritbot added a comment.Jan 9 2023, 11:57 AM

Change 869743 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] processMessageChanges: Rename and move to namespace

https://gerrit.wikimedia.org/r/869743

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.18; 2023-01-09).Jan 9 2023, 12:00 PM
gerritbot added a comment.Jan 18 2023, 1:41 PM

Change 869745 merged by jenkins-bot:

[translatewiki@master] Rename processMessageChanges to importExternalTranslations

https://gerrit.wikimedia.org/r/869745

gerritbot added a comment.Jan 18 2023, 1:58 PM

Change 869746 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Remove processMessageChanges

https://gerrit.wikimedia.org/r/869746

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.20; 2023-01-23); removed MW-1.40-notes (1.40.0-wmf.18; 2023-01-09).Jan 18 2023, 2:00 PM
gerritbot added a comment.Feb 13 2023, 3:15 PM

Change 881064 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Move Languageeditstats to Statistics namespace

https://gerrit.wikimedia.org/r/881064

gerritbot added a comment.Feb 16 2023, 5:29 AM

Change 881064 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Move Languageeditstats to Statistics namespace

https://gerrit.wikimedia.org/r/881064

Maintenance_bot removed a project: Patch-For-Review.Feb 16 2023, 5:30 AM
gerritbot added a comment.Feb 20 2023, 4:48 PM

Change 887385 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] ttmserver/Interfaces: Breakup into separate classes and namespace

https://gerrit.wikimedia.org/r/887385

gerritbot added a project: Patch-For-Review.Feb 20 2023, 4:48 PM
gerritbot added a comment.Mar 20 2023, 12:47 PM

Change 887385 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] ttmserver/Interfaces: Breakup into separate classes and namespace

https://gerrit.wikimedia.org/r/887385

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.1; 2023-03-20).Mar 20 2023, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 20 2023, 1:11 PM
• Nikerabbit added a subtask: T333820: Modernize code under ffs/ directory .Apr 3 2023, 11:32 AM
Wangombe closed subtask T313242: Move classes in the Translate root directory to namespace as Resolved.Apr 4 2023, 6:51 AM
gerritbot added a comment.Apr 25 2023, 6:50 AM

Change 911757 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] DatabaseTTMServer: Move to namespace

https://gerrit.wikimedia.org/r/911757

gerritbot added a project: Patch-For-Review.Apr 25 2023, 6:50 AM
Tacsipacsi removed a project: Patch-For-Review.Apr 25 2023, 2:16 PM
Tacsipacsi subscribed.
• Nikerabbit renamed this task from Adopt PSR-4 namespaces in Translate to Adopt PSR-4 namespaces in Translate and modernize code.Jun 29 2023, 10:13 AM
• Nikerabbit added a subtask: T340724: Modernize code under util/ directory .Jun 29 2023, 10:23 AM
• Nikerabbit added a subtask: T340723: Modernize code under messagegroups/ directory .
• Nikerabbit added a subtask: T340725: Move renaming i18n files in the Translate root directory under i18n.
abi_ closed subtask T333820: Modernize code under ffs/ directory as Resolved.Jul 3 2023, 9:59 AM
Wangombe mentioned this in T353420: Modernise TranslateMetadata::class to an injectable service.Dec 14 2023, 8:13 AM
abi_ changed the status of subtask T340724: Modernize code under util/ directory from Open to In Progress.May 28 2024, 9:19 AM
abi_ closed subtask T340724: Modernize code under util/ directory as Resolved.May 30 2024, 3:50 PM
Wangombe changed the status of subtask T335342: Modernize code under ttmserver/ directory from Open to In Progress.Tue, Jul 2, 4:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits