Page MenuHomePhabricator

Modernize code under ffs/ directory
Closed, ResolvedPublic16 Estimated Story Points

Description

Per parent task:

  • Namespace code and put under src/
  • Add type declarations and strict types
  • Use constructor service injection where possible
  • Update file, class and method comments per current practices

Since FFS classes are referred externally in Yaml files, we must create an id-based system similar to what was done for insertables in T267100: Move insertables to the src/ folder.. I suggest creating a FileFormatFactory service that contains a registry of known file formats using the ObjectFactory specification format. This allows service injection to file format handlers. Params from the YAML files would be passed as additional constructor param.

https://www.mediawiki.org/wiki/Extension:Translate/Namespaces#FileFormatSupport suggests to use namespace FileFormatSupport and name classes FooFfs. I think this could be further improved by using FileFormat as the namespace and FooFormat or FooHandler as the class names, to avoid using the ffs acronym.

Details

SubjectRepoBranchLines +/-
mediawiki/extensions/Translatemaster+2 -2
mediawiki/extensions/Translatemaster+24 -20
mediawiki/extensions/Translatemaster+81 -105
mediawiki/extensions/Translatemaster+8 -8
mediawiki/extensions/Translatemaster+8 -8
mediawiki/extensions/Translatemaster+0 -2 K
mediawiki/extensions/Translatemaster+0 -135
mediawiki/extensions/Translatemaster+0 -129
mediawiki/extensions/Translatemaster+8 -8
translatewikimaster+19 -19
translatewikimaster+6 -6
translatewikimaster+3 -3
translatewikimaster+6 -6
translatewikimaster+2 -2
mediawiki/extensions/Translatemaster+0 -229
mediawiki/extensions/Translatemaster+22 -27
mediawiki/extensions/Translatemaster+73 -85
mediawiki/extensions/Translatemaster+81 -81
mediawiki/extensions/Translatemaster+2 -2
mediawiki/extensions/Translatemaster+29 -73
mediawiki/extensions/Translatemaster+147 -175
mediawiki/extensions/Translatemaster+50 -60
mediawiki/extensions/Translatemaster+69 -94
mediawiki/extensions/Translatemaster+86 -101
mediawiki/extensions/Translatemaster+198 -217
mediawiki/extensions/Translatemaster+8 -3
translatewikimaster+203 -203
translatewikimaster+6 -6
mediawiki/extensions/Translatemaster+4 -2
translatewikimaster+1 -1
translatewikimaster+1 -1
mediawiki/extensions/Translatemaster+3 -3
mediawiki/extensions/Translatemaster+1 -1
mediawiki/extensions/Translatemaster+61 -69
mediawiki/extensions/Translatemaster+197 -11
mediawiki/extensions/Translatemaster+11 -8
mediawiki/extensions/Translatemaster+102 -111
mediawiki/extensions/Translatemaster+1 -5
mediawiki/extensions/Translatemaster+15 -7
mediawiki/extensions/Translatemaster+80 -95
mediawiki/extensions/Translatemaster+1 -1
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 908496 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] JsonFFS::isContentEqual: Allow nullable strings

https://gerrit.wikimedia.org/r/908496

Change 908497 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] FileFormatSupport: Remove unncessary documentation

https://gerrit.wikimedia.org/r/908497

Change 914709 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Update SimpleFornat::tryReadFile() return type

https://gerrit.wikimedia.org/r/914709

Change 908224 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Move SimpleFFS::class to FileFormatSupport namespace

https://gerrit.wikimedia.org/r/908224

Change 914709 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Update SimpleFormat::tryReadFile() return type

https://gerrit.wikimedia.org/r/914709

Change 916905 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Move JsonFFS::class to FileFormatSupport namespace

https://gerrit.wikimedia.org/r/916905

Change 917321 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] AndroidXmlFFS::class: Move to FileFormatSupport namespace

https://gerrit.wikimedia.org/r/917321

Change 917832 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Add FileFormatFactory to create instance of FileFormat class

https://gerrit.wikimedia.org/r/917832

Change 917832 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Add FileFormatFactory to create FileFormat instances

https://gerrit.wikimedia.org/r/917832

Change 916905 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Move JsonFFS::class to FileFormatSupport namespace

https://gerrit.wikimedia.org/r/916905

Change 920587 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] JsonFormat::class: Update class level comment

https://gerrit.wikimedia.org/r/920587

Change 920589 had a related patch set uploaded (by Wangombe; author: Wangombe):

[translatewiki@master] Update group configurations for AndroidXmlFormat

https://gerrit.wikimedia.org/r/920589

Change 920590 had a related patch set uploaded (by Wangombe; author: Wangombe):

[translatewiki@master] Update group configurations for JsonFormat

https://gerrit.wikimedia.org/r/920590

Change 920626 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Update group configurations for JsonFormat

https://gerrit.wikimedia.org/r/920626

Change 920587 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] JsonFormat::class: Update class level comment

https://gerrit.wikimedia.org/r/920587

Change 920680 had a related patch set uploaded (by Wangombe; author: Wangombe):

[translatewiki@master] Ajapaik.yaml: Update group configuration for JsonFormat

https://gerrit.wikimedia.org/r/920680

Change 917321 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] AndroidXmlFFS::class: Move to FileFormatSupport namespace

https://gerrit.wikimedia.org/r/917321

Change 920626 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Tests: update group configurations for JsonFormat

https://gerrit.wikimedia.org/r/920626

Change 920699 had a related patch set uploaded (by Wangombe; author: Wangombe):

[translatewiki@master] Ajapaik.yaml: Update group configuration for JsonFormat

https://gerrit.wikimedia.org/r/920699

Change 920699 abandoned by Wangombe:

[translatewiki@master] Ajapaik.yaml: Update group configuration for JsonFormat

Reason:

Deplicate

https://gerrit.wikimedia.org/r/920699

Change 920680 merged by jenkins-bot:

[translatewiki@master] Ajapaik.yaml: Update group configuration for JsonFormat

https://gerrit.wikimedia.org/r/920680

Change 920703 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] FileBasedMessageGroup: Update schema to allow FILES.format

https://gerrit.wikimedia.org/r/920703

Change 920703 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] FileBasedMessageGroup: Update schema to allow FILES.format

https://gerrit.wikimedia.org/r/920703

Change 920589 merged by jenkins-bot:

[translatewiki@master] Update group configurations for AndroidXmlFormat

https://gerrit.wikimedia.org/r/920589

Change 920989 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] GettextFFS::class: Move to FileFormatSupport namespace

https://gerrit.wikimedia.org/r/920989

Change 921022 had a related patch set uploaded (by Wangombe; author: Wangombe):

[translatewiki@master] Update group configurations for GettextFormat.

https://gerrit.wikimedia.org/r/921022

Change 921024 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] GettextFFS::class: Move to FileFormatSupport namespace

https://gerrit.wikimedia.org/r/921024

Change 921025 had a related patch set uploaded (by Wangombe; author: Wangombe):

[translatewiki@master] Update group configurations for YamlFormat

https://gerrit.wikimedia.org/r/921025

Change 921027 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] AdmFFS::class: Move to FileFormatSupport namespace

https://gerrit.wikimedia.org/r/921027

Change 921028 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] JavaFFS::class: Move to FileFormatSupport namespace

https://gerrit.wikimedia.org/r/921028

Change 921029 had a related patch set uploaded (by Wangombe; author: Wangombe):

[translatewiki@master] Update group configurations for YamlFormat

https://gerrit.wikimedia.org/r/921029

Change 921030 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] AppleFFS::class: Move to FileFormatSupport namespace

https://gerrit.wikimedia.org/r/921030

Change 921031 had a related patch set uploaded (by Wangombe; author: Wangombe):

[translatewiki@master] Update group configurations for AppleFormat

https://gerrit.wikimedia.org/r/921031

abi_ changed the point value for this task from 8 to 16.May 19 2023, 2:09 PM

Change 921880 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] DtdFFS::class: Move to FileFormatSupport namespace

https://gerrit.wikimedia.org/r/921880

Change 921882 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] FlatPhpFFS::class: Move to FileFormatSupport namespace

https://gerrit.wikimedia.org/r/921882

Change 921883 had a related patch set uploaded (by Wangombe; author: Wangombe):

[translatewiki@master] Update group configurations for FlatPhpFormat

https://gerrit.wikimedia.org/r/921883

Change 922044 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] IniFFS::class: Move to FileFormatSupport namespace

https://gerrit.wikimedia.org/r/922044

Change 922056 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] JavaScriptFFS::class: Move to FileFormatSupport namespace

https://gerrit.wikimedia.org/r/922056

Change 920590 merged by jenkins-bot:

[translatewiki@master] Update group configurations for JsonFormat

https://gerrit.wikimedia.org/r/920590

Change 923260 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] MessageGroupConfigurationParser: Call getExtraSchema() if present

https://gerrit.wikimedia.org/r/923260

Change 923260 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] MessageGroupConfigurationParser: Call getExtraSchema() if present

https://gerrit.wikimedia.org/r/923260

Change 920989 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] GettextFFS::class: Move to FileFormatSupport namespace

https://gerrit.wikimedia.org/r/920989

Change 922044 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] IniFFS::class: Move to FileFormatSupport namespace

https://gerrit.wikimedia.org/r/922044

Change 921030 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] AppleFFS::class: Move to FileFormatSupport namespace

https://gerrit.wikimedia.org/r/921030

Change 928551 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] AndroidXmlFormat::class - add missing type declarations

https://gerrit.wikimedia.org/r/928551

Change 921027 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] AmdFFS::class: Move to FileFormatSupport namespace

https://gerrit.wikimedia.org/r/921027

Change 921024 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] YamlFFS::class: Move to FileFormatSupport namespace

https://gerrit.wikimedia.org/r/921024

Change 928551 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] AndroidXmlFormat: Further code improvements

https://gerrit.wikimedia.org/r/928551

Change 921880 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] DtdFFS::class: Move to FileFormatSupport namespace

https://gerrit.wikimedia.org/r/921880

Change 921028 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] JavaFFS::class: Move to FileFormatSupport namespace

https://gerrit.wikimedia.org/r/921028

Change 921882 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] FlatPhpFFS::class: Move to FileFormatSupport namespace

https://gerrit.wikimedia.org/r/921882

Change 922056 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] JavaScriptFFS::class: Remove unused File Format

https://gerrit.wikimedia.org/r/922056

Change 921031 merged by jenkins-bot:

[translatewiki@master] Update group configurations for AppleFormat

https://gerrit.wikimedia.org/r/921031

Change 921025 merged by jenkins-bot:

[translatewiki@master] Update group configurations for YamlFormat

https://gerrit.wikimedia.org/r/921025

Change 921883 merged by jenkins-bot:

[translatewiki@master] Update group configurations for FlatPhpFormat

https://gerrit.wikimedia.org/r/921883

Change 921029 merged by jenkins-bot:

[translatewiki@master] Update group configurations for JavaFormat

https://gerrit.wikimedia.org/r/921029

Change 921022 merged by jenkins-bot:

[translatewiki@master] Update group configurations for GettextFormat.

https://gerrit.wikimedia.org/r/921022

Following classes are now pending

  • AppleInfoPlistFfs - Unused. Can be removed
  • GettextParseException
  • GettextPluralException
  • PremadeIntuitionTextdomains
  • PremadeMediawikiExtensionGroups
  • XliffFFS - Unused. Can be removed

Change 931885 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] GettextParseException: Move to namespace

https://gerrit.wikimedia.org/r/931885

Change 931886 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] GettextPluralException: Move to namespace

https://gerrit.wikimedia.org/r/931886

Change 932198 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] PremadeMediawikiExtensionGroups: Move to namespace

https://gerrit.wikimedia.org/r/932198

Change 932199 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] AppleInfoPlistFfs: Remove unused file format

https://gerrit.wikimedia.org/r/932199

Change 931495 had a related patch set uploaded (by Abijeet Patro; author: Wangombe):

[mediawiki/extensions/Translate@master] XliffFFS: Remove unused FileFormatSupport class.

https://gerrit.wikimedia.org/r/931495

Change 932791 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] AppleInfoPlistFfs: Remove unused FileFormatSupport class

https://gerrit.wikimedia.org/r/932791

Change 932793 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] GettextPluralException: move to FileFormatSupport namespace

https://gerrit.wikimedia.org/r/932793

Change 932793 abandoned by Wangombe:

[mediawiki/extensions/Translate@master] GettextPluralException: move to FileFormatSupport namespace

Reason:

done in Id6905e31a1e258b9d026c9f217b681e5d60478fe

https://gerrit.wikimedia.org/r/932793

Change 932791 abandoned by Wangombe:

[mediawiki/extensions/Translate@master] AppleInfoPlistFfs: Remove unused FileFormatSupport class

Reason:

Done in I516ec0f7ae181f87bf2d980935b74a1c06c4c920

https://gerrit.wikimedia.org/r/932791

Change 931495 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] XliffFFS: Remove unused FileFormatSupport class.

https://gerrit.wikimedia.org/r/931495

Change 932199 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] AppleInfoPlistFfs: Remove unused file format

https://gerrit.wikimedia.org/r/932199

Change 931885 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] GettextParseException: Move to namespace

https://gerrit.wikimedia.org/r/931885

Change 931886 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] GettextPluralException: Move to namespace

https://gerrit.wikimedia.org/r/931886

Change 933123 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] PremadeIntuitionTextdomains: Move to namespace

https://gerrit.wikimedia.org/r/933123

Change 932198 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] PremadeMediawikiExtensionGroups: Move to namespace

https://gerrit.wikimedia.org/r/932198

Change 933123 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] PremadeIntuitionTextdomains: Move to namespace

https://gerrit.wikimedia.org/r/933123

All classes have been moved from the ffs folder to namespaces as defined. Leaving it open to address any issues that we might encounter.

Change 934726 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Rename some instances of FFS to file format

https://gerrit.wikimedia.org/r/934726

Change 934726 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Rename some instances of FFS to file format

https://gerrit.wikimedia.org/r/934726