Move namespaced extensions to use PSR-4 autoloading
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Reedy
	Dec 15 2017, 2:02 AM

Description

Some, but not all extensions use their own PHP namespacing.
http://www.php-fig.org/psr/psr-4/ explains the idea behind this task.

Basic process. See https://gerrit.wikimedia.org/r/#/c/398320/ for an example of some of these steps

Swap extension.json to use AutoloadNamespaces instead of AutoloadClasses
Under "requires", set the "MediaWiki" version requirement to >= 1.31.0
Move any PHP files deemed necessary
PHPCodeSniffer helps us stick to same coding standards across MediaWiki and it's extensions. This is still work in progress, and some sniffs are still excluded in the file .phpcs.xml (and those exclusions should get removed, in the long run). Disable MediaWiki.Files.ClassMatchesFilename.NotMatch, MediaWiki.Files.ClassMatchesFilename.WrongCase and MediaWiki.Files.OneClassPerFile.MultipleFound in the file .phpcs.xml if these entries exist as exclusions.
Fix any resultant test failures from any of the changes above.

Details

	Subject	Repo	Branch	Lines +/-
	Uses PSR-4 autoloader	mediawiki/extensions/ProofreadPage	master	+10 -47
	Follow up for PSR-4 work	mediawiki/extensions/ORES	master	+6 -4

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T182943 Move namespaced extensions to use PSR-4 autoloading
Resolved		None	T183260 Move Wikidata-related extensions to make use of PSR-4 autoloading (except Wikibase)
Open		None	T278278 Adopt PSR-4 namespaces in WMF-deployed extensions/skins
Open		None	T278279 Namespace MW Tarball Bundled Extensions/Skins
Resolved		Reedy	T301204 Namespace remaining Vector classes
Open		None	T193166 Adopt PSR-4 namespaces in Translate and modernize code
Resolved		abi_	T267100 Move insertables to the src/ folder.
Resolved		abi_	T299019 Move SpecialPages to namespace and use service injection
Resolved		abi_	T299022 Move webservice consumers to namespace and use service injection
Resolved		Wangombe	T308513 Namespace classes inside the util folder
Resolved		Wangombe	T312006 Move classes under tag folder to namespace
Resolved	PRODUCTION ERROR	abi_	T315889 Error: Class 'TranslatablePage' not found
Resolved	BUG REPORT	abi_	T315708 Edits to translated pages left unpatrolled
Resolved	PRODUCTION ERROR	Urbanecm	T315657 Fatal exception of type "TypeError" from TranslatableBundleLogFormatter.php
Resolved	PRODUCTION ERROR	Umherirrender	T315412 TypeError: Return value of MediaWiki\Extension\Translate\PageTranslation\RenderTranslationPageJob::getUser() must be an instance of User, null returned
Resolved	BUG REPORT	Nikerabbit	T318484 Translate job execution time seems to have significantly increase
Resolved		abi_	T312007 Remove the RevTag class
Resolved		Wangombe	T312008 Move classes under api folder to namespace
Resolved	PRODUCTION ERROR	abi_	T313836 MediaWiki\Extension\Translate\TtmServer\ServiceCreationFailure: Unknown type for name 'Apertium': cxserver
Resolved	PRODUCTION ERROR	abi_	T313608 Marking translations as reviewed fails
Resolved	BUG REPORT	abi_	T315726 Translation sandbox on translatewiki doesn't offer any test translations
Resolved		Wangombe	T313242 Move classes in the Translate root directory to namespace
Resolved		None	T327712 Review CentralNotice patch for Translate namespace change
Resolved		Wangombe	T333820 Modernize code under ffs/ directory
Resolved		Wangombe	T335342 Modernize code under ttmserver/ directory
Resolved		Wangombe	T340724 Modernize code under util/ directory
Resolved		Wangombe	T348496 Modernize code under util/ directory starting with T*
Open		None	T340723 Modernize code under messagegroups/ directory
Resolved		Wangombe	T340725 Move renaming i18n files in the Translate root directory under i18n
Resolved		ori	T280263 Namespace extension and use AutoloadNamespaces

Event Timeline

Reedy created this task.Dec 15 2017, 2:02 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 15 2017, 2:02 AM

Reedy updated the task description. (Show Details)Dec 15 2017, 2:04 AM

Reedy updated the task description. (Show Details)

Aklapper updated the task description. (Show Details)Dec 15 2017, 4:11 PM

Legoktm merged a task: T183062: Migrate extensions to use PSR-4 autoloader instead of manually maintained list of classes.Dec 16 2017, 9:18 PM

Legoktm updated the task description. (Show Details)

Legoktm added subscribers: Ladsgroup, thiemowmde.

WMDE-leszek subscribed.Dec 18 2017, 8:43 AM

Help with improving the task description is welcome, so a new contributor can understand what they are doing and don't only blindly try to copy the example Gerrit change. :) PHP namespaces = http://php.net/manual/en/language.namespaces.php ?
What's the reason that all extensions should use their own PHP namespacing?

This documentation will definitely help students understand why we are doing this: http://www.php-fig.org/psr/psr-4/

Change 398829 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Follow up for PSR-4 work

https://gerrit.wikimedia.org/r/398829

gerritbot added a project: Patch-For-Review.Dec 18 2017, 1:00 PM

Change 398829 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Follow up for PSR-4 work

https://gerrit.wikimedia.org/r/398829

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Dec 18 2017, 5:00 PM

Aklapper updated the task description. (Show Details)Dec 19 2017, 10:26 AM

@Reedy: How can a contributor identify such an extension? Any list to gather somehow?
What's a good chunk (number of extensions) for one GCI task?

Change 401082 had a related patch set uploaded (by Tpt; owner: Tpt):
[mediawiki/extensions/ProofreadPage@master] Uses PSR-4 autoloader

https://gerrit.wikimedia.org/r/401082

Change 401082 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Uses PSR-4 autoloader

https://gerrit.wikimedia.org/r/401082

WMDE-leszek closed subtask T183260: Move Wikidata-related extensions to make use of PSR-4 autoloading (except Wikibase) as Resolved.Jan 2 2018, 2:43 PM

Aklapper edited projects, added Epic; removed Patch-For-Review.Feb 11 2018, 10:07 PM

Paladox subscribed.Aug 9 2018, 11:14 PM

Addshore mentioned this in T88258: Convert WikibaseRepository, WikibaseClient, WikibaseLib and WikibaseView to use extension registration.Aug 18 2018, 5:15 PM

In T182943#3862228, @Aklapper wrote:

@Reedy: How can a contributor identify such an extension? Any list to gather somehow?
What's a good chunk (number of extensions) for one GCI task?

Yes, using the awesome code search tool, there are some extensions still doing this: https://codesearch.wmflabs.org/search/?q=%22AutoloadClasses%22%3A%20%7B&i=nope&files=&repos=

xSavitar updated the task description. (Show Details)Sep 21 2018, 9:55 PM

xSavitar updated the task description. (Show Details)Sep 21 2018, 9:57 PM

xSavitar added a project: Google-Code-in-2018.

xSavitar moved this task from Proposed tasks to Missing mentors on the Google-Code-in-2018 board.

Aklapper removed a project: Google-Code-in-2017.Oct 15 2018, 7:13 PM

Reedy removed projects: Google-Code-in-2018, MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Feb 11 2021, 1:33 AM

Reedy updated the task description. (Show Details)

Reedy updated the task description. (Show Details)Mar 24 2021, 12:24 AM

Reedy added a subtask: T193166: Adopt PSR-4 namespaces in Translate and modernize code.Mar 24 2021, 12:26 AM

Reedy added a subtask: T278278: Adopt PSR-4 namespaces in WMF-deployed extensions/skins.

Reedy added a subtask: T278279: Namespace MW Tarball Bundled Extensions/Skins.Mar 24 2021, 4:26 AM