Page MenuHomePhabricator
Create Task
Maniphest T312008

Move classes under api folder to namespace
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Move the following classes to namespace:

In addition to moving the classes to namespace:

  • Add dependency injection
  • Remove usage of deprecated methods
  • Use strict types
  • Check for external users of the class / methods

Details

SubjectRepoBranchLines +/-
Remove temp variable from Utilities.phpmediawiki/extensions/Translatemaster+1 -3
QueryMessageTranslationsActionApi: Add strict types; move to namespacemediawiki/extensions/Translatemaster+55 -53
Remove remaining references to api directoriesmediawiki/extensions/Translatemaster+1 -2
TranslationStashActionApi: Fix incorrect constructor dependenciesmediawiki/extensions/Translatewmf/1.39.0-wmf.22+3 -4
TranslatorSandboxActionApi: Pass user object when sending emailmediawiki/extensions/Translatemaster+7 -7
QueryMessageGroupStatsActionApi: Add strict types and move to namespacemediawiki/extensions/Translatemaster+15 -17
QueryLanguageStatsActionApi: Add strict types and move to namespacemediawiki/extensions/Translatemaster+14 -14
QueryStatsActionApi: Add strict types and move to namespacemediawiki/extensions/Translatemaster+37 -31
TranslationStashActionApi: Fix incorrect constructor dependenciesmediawiki/extensions/Translatemaster+3 -4
TranslationStashActionApi: Use strict types and add to namespacemediawiki/extensions/Translatemaster+48 -20
TranslatorSandboxActionApi: Use strict types and add to namespacemediawiki/extensions/Translatemaster+100 -42
TtmServerActionApi: Use strict types and add to namespacemediawiki/extensions/Translatemaster+130 -103
ReviewTranslationActionApi: Move to namespace and add strict typesmediawiki/extensions/Translatewmf/1.39.0-wmf.21+353 -301
AggregateGroupsActionApi: Add strict types and move to namespacemediawiki/extensions/Translatemaster+27 -21
QueryMessageGroupsActionApi: Add strict types; move to namespacemediawiki/extensions/Translatemaster+58 -39
CheckTranslationActionApi: Add strict types and move to namespacemediawiki/extensions/Translatemaster+20 -12
SearchTranslationsActionApi: Add strict types and move to namespacemediawiki/extensions/Translatemaster+55 -22
QueryMessageCollectionActionApi: add strict types and move to namespacemediawiki/extensions/Translatemaster+78 -47
ReviewTranslationActionApi: Move to namespace and add strict typesmediawiki/extensions/Translatemaster+353 -301
ManageMessageGroupsActionApi: Add strict types; move to namespacemediawiki/extensions/Translatemaster+86 -68
QueryManageMessageGroupsActionApi: Add strict types; move to namespacemediawiki/extensions/Translatemaster+40 -34
Use MessageGroupReview as a servicemediawiki/extensions/Translatemaster+140 -90
GroupReviewActionApi: Add strict types and move to namespacemediawiki/extensions/Translatemaster+73 -58
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

abi_ claimed this task.Jul 4 2022, 11:53 AM
abi_ triaged this task as Medium priority.
abi_ created this task.
abi_ removed a project: MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).
abi_ updated the task description. (Show Details)
abi_ set the point value for this task to 8.
abi_ edited subscribers, added: Wangombe; removed: awight.
Pginer-WMF added a project: Language-Team (Language-2022-July-September).Jul 4 2022, 12:28 PM
Pginer-WMF moved this task from Quarter Backlog to Priority: Localization infrastructure on the Language-Team (Language-2022-July-September) board.
gerritbot added a comment.Jul 4 2022, 2:45 PM

Change 810937 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] ReviewTranslationActiveApi: Move to namespace and add strict types

https://gerrit.wikimedia.org/r/810937

gerritbot added a project: Patch-For-Review.Jul 4 2022, 2:45 PM
abi_ moved this task from Priority: Localization infrastructure to In Progress on the Language-Team (Language-2022-July-September) board.Jul 4 2022, 7:47 PM
gerritbot added a comment.Jul 5 2022, 8:10 AM

Change 811209 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] SearchTranslationsActionApi: Add strict types and move to namespace

https://gerrit.wikimedia.org/r/811209

gerritbot added a comment.Jul 6 2022, 7:58 AM

Change 811588 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] GroupReviewActionApi: Add strict types and move to namespace

https://gerrit.wikimedia.org/r/811588

gerritbot added a comment.Jul 7 2022, 11:29 AM

Change 811968 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] CheckTranslationActionApi: Add strict types and move to namespace

https://gerrit.wikimedia.org/r/811968

gerritbot added a comment.Jul 7 2022, 4:22 PM

Change 812030 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] QueryStatsActionApi: Add strict types and move to namespace

https://gerrit.wikimedia.org/r/812030

abi_ updated the task description. (Show Details)Jul 7 2022, 4:25 PM
gerritbot added a comment.Jul 8 2022, 8:12 AM

Change 812237 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] QueryLanguageStatsActionApi: Add strict types and move to namespace

https://gerrit.wikimedia.org/r/812237

gerritbot added a comment.Jul 8 2022, 8:12 AM

Change 812238 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] QueryMessageGroupStatsActionApi: Add strict types and move to namespace

https://gerrit.wikimedia.org/r/812238

abi_ updated the task description. (Show Details)Jul 8 2022, 8:14 AM
gerritbot added a comment.Jul 11 2022, 12:07 PM

Change 812858 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] QueryManageMessageGroupsActionApi: Add strict types; move to namespace

https://gerrit.wikimedia.org/r/812858

Wangombe updated the task description. (Show Details)Jul 11 2022, 12:09 PM
gerritbot added a comment.Jul 11 2022, 4:16 PM

Change 812906 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Add MessageGroupReview as a service

https://gerrit.wikimedia.org/r/812906

gerritbot added a comment.Jul 12 2022, 12:53 PM

Change 813237 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] ManageMessageGroupsActionApi: Add strict types; move to namespace

https://gerrit.wikimedia.org/r/813237

Wangombe updated the task description. (Show Details)Jul 12 2022, 3:27 PM
gerritbot added a comment.Jul 13 2022, 10:45 AM

Change 813610 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] QueryMessageCollectionActionApi: dd strict types and move to namespace

https://gerrit.wikimedia.org/r/813610

Wangombe updated the task description. (Show Details)Jul 13 2022, 10:46 AM
gerritbot added a comment.Jul 13 2022, 12:32 PM

Change 813626 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] QueryMessageGroupsActionApi: Add strict types; move to namespace

https://gerrit.wikimedia.org/r/813626

Wangombe updated the task description. (Show Details)Jul 13 2022, 12:32 PM
gerritbot added a comment.Jul 18 2022, 5:56 AM

Change 811588 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] GroupReviewActionApi: Add strict types and move to namespace

https://gerrit.wikimedia.org/r/811588

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 18 2022, 6:00 AM
gerritbot added a comment.Jul 18 2022, 6:50 AM

Change 812858 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] QueryManageMessageGroupsActionApi: Add strict types; move to namespace

https://gerrit.wikimedia.org/r/812858

gerritbot added a comment.Jul 18 2022, 7:57 AM

Change 812906 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Use MessageGroupReview as a service

https://gerrit.wikimedia.org/r/812906

gerritbot added a comment.Jul 18 2022, 8:41 AM

Change 813237 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] ManageMessageGroupsActionApi: Add strict types; move to namespace

https://gerrit.wikimedia.org/r/813237

Pginer-WMF moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.Jul 18 2022, 11:21 AM
gerritbot added a comment.Jul 19 2022, 9:20 AM

Change 810937 merged by Wangombe:

[mediawiki/extensions/Translate@master] ReviewTranslationActionApi: Move to namespace and add strict types

https://gerrit.wikimedia.org/r/810937

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.22; 2022-07-25); removed MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 19 2022, 10:00 AM
Wangombe claimed this task.Jul 19 2022, 11:23 AM
gerritbot added a comment.Jul 19 2022, 1:40 PM

Change 815292 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] ApiAggregateGroups: Add strict types and move to namespace

https://gerrit.wikimedia.org/r/815292

Wangombe updated the task description. (Show Details)Jul 19 2022, 1:41 PM
gerritbot added a comment.Jul 19 2022, 2:23 PM

Change 815299 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] QueryMessageTranslationsActionApi: Add strict types; move to namespace

https://gerrit.wikimedia.org/r/815299

Wangombe updated the task description. (Show Details)Jul 19 2022, 2:23 PM
gerritbot added a comment.Jul 19 2022, 3:55 PM

Change 813610 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] QueryMessageCollectionActionApi: add strict types and move to namespace

https://gerrit.wikimedia.org/r/813610

gerritbot added a comment.Jul 20 2022, 8:48 AM

Change 815689 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] TranslatorSandboxActionApi: Use strict types and add to namespace

https://gerrit.wikimedia.org/r/815689

Wangombe updated the task description. (Show Details)Jul 20 2022, 8:49 AM
gerritbot added a comment.Jul 20 2022, 10:40 AM

Change 811209 merged by Wangombe:

[mediawiki/extensions/Translate@master] SearchTranslationsActionApi: Add strict types and move to namespace

https://gerrit.wikimedia.org/r/811209

gerritbot added a comment.Jul 20 2022, 10:53 AM

Change 811968 merged by Wangombe:

[mediawiki/extensions/Translate@master] CheckTranslationActionApi: Add strict types and move to namespace

https://gerrit.wikimedia.org/r/811968

gerritbot added a comment.Jul 20 2022, 11:33 AM

Change 813626 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] QueryMessageGroupsActionApi: Add strict types; move to namespace

https://gerrit.wikimedia.org/r/813626

gerritbot added a comment.Jul 20 2022, 12:09 PM

Change 815703 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] TranslationStashActionApi: Use strict types and add to namespace

https://gerrit.wikimedia.org/r/815703

Wangombe updated the task description. (Show Details)Jul 20 2022, 12:09 PM
gerritbot added a comment.Jul 20 2022, 12:46 PM

Change 815708 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] TtmServerActionApi: Use strict types and add to namespace

https://gerrit.wikimedia.org/r/815708

Wangombe updated the task description. (Show Details)Jul 20 2022, 12:46 PM
gerritbot added a comment.Jul 20 2022, 2:36 PM

Change 815299 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] QueryMessageTranslationsActionApi: Add strict types; move to namespace

https://gerrit.wikimedia.org/r/815299

gerritbot added a comment.Jul 20 2022, 2:45 PM

Change 815292 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] AggregateGroupsActionApi: Add strict types and move to namespace

https://gerrit.wikimedia.org/r/815292

gerritbot added a comment.Jul 24 2022, 4:17 PM

Change 816272 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@wmf/1.39.0-wmf.21] ReviewTranslationActionApi: Move to namespace and add strict types

https://gerrit.wikimedia.org/r/816272

gerritbot added a comment.Jul 25 2022, 8:06 AM

Change 816272 merged by jenkins-bot:

[mediawiki/extensions/Translate@wmf/1.39.0-wmf.21] ReviewTranslationActionApi: Move to namespace and add strict types

https://gerrit.wikimedia.org/r/816272

Stashbot added a comment.Jul 25 2022, 8:15 AM

Mentioned in SAL (#wikimedia-operations) [2022-07-25T08:15:41Z] <kartik@deploy1002> Synchronized php-1.39.0-wmf.21/extensions/Translate: Backport: [[gerrit:816272|ReviewTranslationActionApi: Move to namespace and add strict types (T312008 T313608)]] (duration: 03m 09s)

Stashbot mentioned this in T313608: Marking translations as reviewed fails.Jul 25 2022, 8:15 AM
gerritbot added a comment.Jul 25 2022, 1:16 PM

Change 815708 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TtmServerActionApi: Use strict types and add to namespace

https://gerrit.wikimedia.org/r/815708

gerritbot added a comment.Jul 25 2022, 3:15 PM

Change 815689 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslatorSandboxActionApi: Use strict types and add to namespace

https://gerrit.wikimedia.org/r/815689

gerritbot added a comment.Jul 25 2022, 3:49 PM

Change 815703 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslationStashActionApi: Use strict types and add to namespace

https://gerrit.wikimedia.org/r/815703

gerritbot added a comment.Jul 26 2022, 4:49 AM

Change 816885 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] TranslationStashActionApi: Fix incorrect constructor dependencies

https://gerrit.wikimedia.org/r/816885

gerritbot added a comment.Jul 26 2022, 4:52 AM

Change 816778 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@wmf/1.39.0-wmf.22] TranslationStashActionApi: Fix incorrect constructor dependencies

https://gerrit.wikimedia.org/r/816778

gerritbot added a comment.Jul 26 2022, 5:48 AM

Change 816885 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslationStashActionApi: Fix incorrect constructor dependencies

https://gerrit.wikimedia.org/r/816885

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.23; 2022-08-01); removed MW-1.39-notes (1.39.0-wmf.22; 2022-07-25).Jul 26 2022, 6:01 AM
gerritbot added a comment.Jul 26 2022, 6:36 AM

Change 812030 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] QueryStatsActionApi: Add strict types and move to namespace

https://gerrit.wikimedia.org/r/812030

gerritbot added a comment.Jul 26 2022, 6:37 AM

Change 812237 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] QueryLanguageStatsActionApi: Add strict types and move to namespace

https://gerrit.wikimedia.org/r/812237

gerritbot added a comment.Jul 26 2022, 12:49 PM

Change 812238 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] QueryMessageGroupStatsActionApi: Add strict types and move to namespace

https://gerrit.wikimedia.org/r/812238

gerritbot added a comment.Jul 27 2022, 1:34 PM

Change 817779 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] TranslatorSandboxActionApi: Pass user object when sending email

https://gerrit.wikimedia.org/r/817779

gerritbot added a comment.Jul 27 2022, 1:56 PM

Change 817779 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslatorSandboxActionApi: Pass user object when sending email

https://gerrit.wikimedia.org/r/817779

Nikerabbit added a subtask: T313836: MediaWiki\Extension\Translate\TtmServer\ServiceCreationFailure: Unknown type for name 'Apertium': cxserver.Jul 28 2022, 8:29 AM
Nikerabbit added a subtask: T313608: Marking translations as reviewed fails.
Nikerabbit updated the task description. (Show Details)Jul 28 2022, 8:32 AM
Nikerabbit removed a project: Patch-For-Review.Jul 28 2022, 8:50 AM
Nikerabbit moved this task from In Progress to Check after deployment on the Language-Team (Language-2022-July-September) board.
gerritbot added a comment.Aug 1 2022, 6:07 AM

Change 816778 abandoned by Abijeet Patro:

[mediawiki/extensions/Translate@wmf/1.39.0-wmf.22] TranslationStashActionApi: Fix incorrect constructor dependencies

Reason:

Not required.

https://gerrit.wikimedia.org/r/816778

gerritbot added a comment.Aug 2 2022, 5:44 AM

Change 819435 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Remove remaining references to api folder

https://gerrit.wikimedia.org/r/819435

gerritbot added a project: Patch-For-Review.Aug 2 2022, 5:44 AM
Wangombe closed this task as Resolved.Aug 2 2022, 6:29 AM
Nikerabbit moved this task from Check after deployment to Done on the Language-Team (Language-2022-July-September) board.Aug 2 2022, 7:17 AM
Nikerabbit removed a project: Patch-For-Review.
gerritbot added a comment.Aug 2 2022, 1:29 PM

Change 819435 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Remove remaining references to api directories

https://gerrit.wikimedia.org/r/819435

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.25; 2022-08-15); removed MW-1.39-notes (1.39.0-wmf.23; 2022-08-01).Aug 2 2022, 2:00 PM
Nikerabbit added a subtask: T315726: Translation sandbox on translatewiki doesn't offer any test translations.Aug 22 2022, 8:26 AM
gerritbot added a comment.Feb 20 2023, 8:08 AM

Change 890231 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Remove temp variable from Utilities.php

https://gerrit.wikimedia.org/r/890231

gerritbot added a project: Patch-For-Review.Feb 20 2023, 8:08 AM
gerritbot added a comment.Feb 20 2023, 10:11 AM

Change 890231 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Remove temp variable from Utilities.php

https://gerrit.wikimedia.org/r/890231

Maintenance_bot removed a project: Patch-For-Review.Feb 20 2023, 10:29 AM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.24; 2023-02-20).Feb 20 2023, 11:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits