Maniphest T335342

Modernize code under ttmserver/ directory
Open, MediumPublic
Actions

Assigned To

None

Authored By

	abi_
	Apr 25 2023, 10:15 AM

Tags

Referenced Files

None

Subscribers

Description

Per parent task:

Namespace code and put under src/
Add type declarations and strict types
Use constructor service injection where possible
Update file, class and method comments per current practices
When removing the directory (namespacing the last file), configuration mentioning it should be removed. Starting point: grep -RP --exclude-dir=i18n/ '(?<!\$)ttmserver' .

Details

	Subject	Repo	Branch	Lines +/-
	DatabaseTTMServer: Move to namespace	mediawiki/extensions/Translate	master	+66 -69

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T182943 Move namespaced extensions to use PSR-4 autoloading
		Open		None	T278278 Adopt PSR-4 namespaces in WMF-deployed extensions/skins
		Open		None	T193166 Adopt PSR-4 namespaces in Translate and modernize code
		Open		None	T335342 Modernize code under ttmserver/ directory

Event Timeline

abi_ created this task.Apr 25 2023, 10:15 AM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptApr 25 2023, 10:15 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 911757 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] DatabaseTTMServer: Move to namespace

https://gerrit.wikimedia.org/r/911757

gerritbot added a project: Patch-For-Review.Apr 25 2023, 10:18 AM

Change 911757 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] DatabaseTTMServer: Move to namespace

https://gerrit.wikimedia.org/r/911757

Use constructor service injection where possible

Is it possible at all? TTM servers are instantiated by MediaWiki\Extension\Translate\TtmServer\TtmServerFactory, not by MediaWiki core.

Nikerabbit triaged this task as Medium priority.May 22 2023, 11:13 AM

Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.

Nikerabbit removed a project: Patch-For-Review.

Nikerabbit mentioned this in T340724: Modernize code under util/ directory .Jun 29 2023, 10:22 AM

Nikerabbit mentioned this in T340723: Modernize code under messagegroups/ directory .