Page MenuHomePhabricator
Create Task
Maniphest T335342

Modernize code under ttmserver/ directory
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Per parent task:

  • Namespace code and put under src/
  • Add type declarations and strict types
  • Use constructor service injection where possible
  • Update file, class and method comments per current practices
  • When removing the directory (namespacing the last file), configuration mentioning it should be removed. Starting point: grep -RP --exclude-dir=i18n/ '(?<!\$)ttmserver' .

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
CrossLanguageTranslationSearchQuery: Move to TtmServer namespacemediawiki/extensions/Translatemaster+29 -34
TTMServer: Move to TtmSever namespacemediawiki/extensions/Translatemaster+92 -117
Update reference to ElasticSearchTtmServeroperations/mediawiki-configmaster+1 -1
Update reference to ElasticSearchTtmServertranslatewikimaster+1 -1
Update reference to TtmServertranslatewikimaster+1 -1
TTMServer: Rename to TtmServermediawiki/extensions/Translatemaster+21 -29
Remove reference to ttmserver/ foldermediawiki/extensions/Translatemaster+1 -2
FuzzyLikeThis: Add strict types and perform code improvements.mediawiki/extensions/Translatemaster+39 -124
FuzzyLikeThis: Move to TtmServermediawiki/extensions/Translatemaster+5 -12
Rename TTMServerMessageUpdateJob to TtmServerMessageUpdateJobmediawiki/extensions/Translatemaster+1 -1
Fix TtmServerMessageUpdateJob class namemediawiki/extensions/Translatemaster+1 -1
TtmServerMessageUpdateJob: Declare strict types on methodsmediawiki/extensions/Translatemaster+52 -76
FuzzyLikeThis: Move to TtmServerNamespacemediawiki/extensions/Translatemaster+129 -215
FakeTTMServer: Rename to FakeTtmServermediawiki/extensions/Translatemaster+14 -14
TTMServerMessageUpdateJob: Move to TtmServer namespacemediawiki/extensions/Translatemaster+28 -19
ElasticSearchTTMServer: Move to TtmServer namespacemediawiki/extensions/Translatemaster+59 -88
TtmServerMessageUpdateJob: Declare strict typesmediawiki/extensions/Translatemaster+29 -62
TtmServer: Add to TtmServer namespacemediawiki/extensions/Translatemaster+23 -47
ElasticSearchTtmServer: Move to TtmServer namespacemediawiki/extensions/Translatemaster+6 -10
ElasticSearchTtmServer: Declare strict types on methods.mediawiki/extensions/Translatemaster+33 -61
TtmServerException: Move to TtmServer namespacemediawiki/extensions/Translatemaster+22 -13
TtmServer: Move to src/TtmServermediawiki/extensions/Translatemaster+2 -2
RemoteTTMServer: Move to TtmServer namespacemediawiki/extensions/Translatemaster+10 -15
Move FakeTtmServer to TtmServer namespacemediawiki/extensions/Translatemaster+25 -28
DatabaseTTMServer: Move to namespacemediawiki/extensions/Translatemaster+66 -69
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

abi_ created this task.Apr 25 2023, 10:15 AM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptApr 25 2023, 10:15 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Apr 25 2023, 10:18 AM

Change 911757 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] DatabaseTTMServer: Move to namespace

https://gerrit.wikimedia.org/r/911757

gerritbot added a project: Patch-For-Review.Apr 25 2023, 10:18 AM
gerritbot added a comment.Apr 25 2023, 10:40 AM

Change 911757 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] DatabaseTTMServer: Move to namespace

https://gerrit.wikimedia.org/r/911757

Tacsipacsi updated the task description. (Show Details)Apr 25 2023, 1:25 PM
Tacsipacsi subscribed.
  • Use constructor service injection where possible

Is it possible at all? TTM servers are instantiated by MediaWiki\Extension\Translate\TtmServer\TtmServerFactory, not by MediaWiki core.

Nikerabbit triaged this task as Medium priority.May 22 2023, 11:13 AM
Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.
Nikerabbit removed a project: Patch-For-Review.
Nikerabbit mentioned this in T340724: Modernize code under util/ directory .Jun 29 2023, 10:22 AM
Nikerabbit mentioned this in T340723: Modernize code under messagegroups/ directory .
Pginer-WMF added a project: LPL Essential (LPL Essential 2024 Jul-Oct).Jul 2 2024, 4:07 PM
Wangombe changed the task status from Open to In Progress.Jul 2 2024, 4:46 PM
Wangombe claimed this task.
Wangombe moved this task from Sprint Backlog to In Progress on the LPL Essential (LPL Essential 2024 Jul-Oct) board.
gerritbot added a comment.Jul 3 2024, 9:41 AM

Change #1051703 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] CrossLanguageTranslationSearchQuery: Move to TtmServer namespace

https://gerrit.wikimedia.org/r/1051703

gerritbot added a project: Patch-For-Review.Jul 3 2024, 9:41 AM

Change #1051704 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Move FakeTtmServer to TtmServer namespace

https://gerrit.wikimedia.org/r/1051704

gerritbot added a comment.Jul 3 2024, 9:41 AM

Change #1051705 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] RemoteTTMServer: Move to TtmServer namespace

https://gerrit.wikimedia.org/r/1051705

gerritbot added a comment.Jul 3 2024, 9:42 AM

Change #1051706 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] TtmServerException: Move to TtmServer namespace

https://gerrit.wikimedia.org/r/1051706

gerritbot added a comment.Jul 3 2024, 9:42 AM

Change #1051707 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] FuzzyLikeThis: Move to TtmServer

https://gerrit.wikimedia.org/r/1051707

gerritbot added a comment.Jul 3 2024, 9:42 AM

Change #1051708 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] TTMServer: Move to TtmServer namespace

https://gerrit.wikimedia.org/r/1051708

gerritbot added a comment.Jul 4 2024, 2:40 PM

Change #1052126 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] FakeTTMServer: Rename to FakeTtmServer

https://gerrit.wikimedia.org/r/1052126

gerritbot added a comment.Jul 5 2024, 1:34 PM

Change #1051703 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] CrossLanguageTranslationSearchQuery: Move to TtmServer namespace

https://gerrit.wikimedia.org/r/1051703

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.13; 2024-07-09).Jul 5 2024, 2:00 PM
gerritbot added a comment.Jul 7 2024, 9:40 AM

Change #1052415 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] TtmServer: Move to TtmServer namespace

https://gerrit.wikimedia.org/r/1052415

gerritbot added a comment.Jul 8 2024, 2:26 PM

Change #1052756 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] TtmServer: Add to TtmServer namespace

https://gerrit.wikimedia.org/r/1052756

gerritbot added a comment.Jul 9 2024, 7:45 AM

Change #1051704 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Move FakeTtmServer to TtmServer namespace

https://gerrit.wikimedia.org/r/1051704

gerritbot added a comment.Jul 9 2024, 7:54 AM

Change #1051705 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] RemoteTTMServer: Move to TtmServer namespace

https://gerrit.wikimedia.org/r/1051705

ReleaseTaggerBot edited projects, added: MW-1.43-notes (1.43.0-wmf.14; 2024-07-16); removed: MW-1.43-notes (1.43.0-wmf.13; 2024-07-09).Jul 9 2024, 8:00 AM
gerritbot added a comment.Jul 9 2024, 9:02 AM

Change #1052925 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] ElasticSearchTTMServer: rename to ElasticSearchTtmServer

https://gerrit.wikimedia.org/r/1052925

gerritbot added a comment.Jul 9 2024, 11:06 AM

Change #1052926 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] ElasticSearchTtmServer: Move to TtmServer

https://gerrit.wikimedia.org/r/1052926

gerritbot added a comment.Jul 9 2024, 11:10 AM

Change #1052952 had a related patch set uploaded (by Wangombe; author: Wangombe):

[translatewiki@master] Update reference to ElasticSearchTtmServer

https://gerrit.wikimedia.org/r/1052952

gerritbot added a comment.Jul 10 2024, 1:20 PM

Change #1052415 abandoned by Wangombe:

[mediawiki/extensions/Translate@master] TtmServer: Move to src/TtmServer

Reason:

Addressed in Id70a969ff2c02b11a1d28231749c47b5eb0cac7b

https://gerrit.wikimedia.org/r/1052415

gerritbot added a comment.Jul 11 2024, 11:43 AM

Change #1051706 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TtmServerException: Move to TtmServer namespace

https://gerrit.wikimedia.org/r/1051706

gerritbot added a comment.Jul 16 2024, 8:56 AM

Change #1054497 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] FuzzyLikeThis: Add strict types and perform code imporvements.

https://gerrit.wikimedia.org/r/1054497

gerritbot added a comment.Jul 17 2024, 9:59 AM

Change #1054858 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] ElasticSearchTTMServer: Move to TtmServer namespace

https://gerrit.wikimedia.org/r/1054858

gerritbot added a comment.Jul 17 2024, 9:59 AM

Change #1052926 abandoned by Wangombe:

[mediawiki/extensions/Translate@master] ElasticSearchTtmServer: Declare strict types on methods.

Reason:

Addressed in Ia9562f5d349cb773f3b2fb9106eb9f2493949d95

https://gerrit.wikimedia.org/r/1052926

gerritbot added a comment.Jul 17 2024, 9:59 AM

Change #1052925 abandoned by Wangombe:

[mediawiki/extensions/Translate@master] ElasticSearchTtmServer: Move to TtmServer namespace

Reason:

Addressed in Ia9562f5d349cb773f3b2fb9106eb9f2493949d95

https://gerrit.wikimedia.org/r/1052925

gerritbot added a comment.Jul 17 2024, 11:48 AM

Change #1054869 had a related patch set uploaded (by Wangombe; author: Wangombe):

[operations/mediawiki-config@master] Update reference to ElasticSearchTtmServer

https://gerrit.wikimedia.org/r/1054869

gerritbot added a comment.Jul 17 2024, 12:46 PM

Change #1054875 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] TTMServer: Move to TtmSever namespace

https://gerrit.wikimedia.org/r/1054875

gerritbot added a comment.Jul 17 2024, 12:57 PM

Change #1051708 abandoned by Wangombe:

[mediawiki/extensions/Translate@master] TTMServer: Rename to TtmServer

Reason:

Adressed in I1a90841db3d325447ee6c57a0680d1a3cf85cfd3

https://gerrit.wikimedia.org/r/1051708

gerritbot added a comment.Jul 17 2024, 12:57 PM

Change #1052756 abandoned by Wangombe:

[mediawiki/extensions/Translate@master] TtmServer: Add to TtmServer namespace

Reason:

Addressed in I1a90841db3d325447ee6c57a0680d1a3cf85cfd3

https://gerrit.wikimedia.org/r/1052756

gerritbot added a comment.Jul 17 2024, 12:58 PM

Change #1054875 abandoned by Wangombe:

[mediawiki/extensions/Translate@master] TTMServer: Move to TtmSever namespace

Reason:

Addressed in I1a90841db3d325447ee6c57a0680d1a3cf85cfd3

https://gerrit.wikimedia.org/r/1054875

gerritbot added a comment.Jul 17 2024, 1:34 PM

Change #1054875 restored by Wangombe:

[mediawiki/extensions/Translate@master] TTMServer: Move to TtmSever namespace

https://gerrit.wikimedia.org/r/1054875

gerritbot added a comment.Jul 17 2024, 1:56 PM

Change #1054883 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] FuzzyLikeThis: Move to TtmServerNamespace

https://gerrit.wikimedia.org/r/1054883

gerritbot added a comment.Jul 17 2024, 1:59 PM

Change #1054497 abandoned by Wangombe:

[mediawiki/extensions/Translate@master] FuzzyLikeThis: Add strict types and perform code imporvements.

Reason:

Concerns addressed in I7ab49e41d856b915169d0699aec9412e0db48856

https://gerrit.wikimedia.org/r/1054497

gerritbot added a comment.Jul 17 2024, 1:59 PM

Change #1051707 abandoned by Wangombe:

[mediawiki/extensions/Translate@master] FuzzyLikeThis: Move to TtmServer

Reason:

Concerns addressed in I7ab49e41d856b915169d0699aec9412e0db48856

https://gerrit.wikimedia.org/r/1051707

gerritbot added a comment.Jul 18 2024, 7:12 AM

Change #1054876 had a related patch set uploaded (by Wangombe; author: Wangombe):

[translatewiki@master] Update reference to TtmServer

https://gerrit.wikimedia.org/r/1054876

gerritbot added a comment.Jul 31 2024, 7:48 AM

Change #1058561 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] TTMServerMessageUpdateJob: Move to TtmServer namespace

https://gerrit.wikimedia.org/r/1058561

gerritbot added a comment.Jul 31 2024, 10:17 AM

Change #1058576 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] TtmServerMessageUpdateJob: Declare strict types

https://gerrit.wikimedia.org/r/1058576

gerritbot added a comment.Aug 1 2024, 7:55 AM

Change #1059013 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] TtmServerMessageUpdateJob: Declare strict types on methods

https://gerrit.wikimedia.org/r/1059013

gerritbot added a comment.Aug 1 2024, 1:52 PM

Change #1058576 abandoned by Wangombe:

[mediawiki/extensions/Translate@master] TtmServerMessageUpdateJob: Declare strict types

Reason:

Done in Id7d1857e6459b03d93a85af59461ec700190712e

https://gerrit.wikimedia.org/r/1058576

gerritbot added a comment.Aug 5 2024, 8:40 AM

Change #1054858 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] ElasticSearchTTMServer: Move to TtmServer namespace

https://gerrit.wikimedia.org/r/1054858

ReleaseTaggerBot edited projects, added: MW-1.43-notes (1.43.0-wmf.17; 2024-08-06); removed: MW-1.43-notes (1.43.0-wmf.14; 2024-07-16).Aug 5 2024, 9:00 AM
gerritbot added a comment.Aug 6 2024, 3:01 AM

Change #1058561 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TTMServerMessageUpdateJob: Move to TtmServer namespace

https://gerrit.wikimedia.org/r/1058561

ReleaseTaggerBot edited projects, added: MW-1.43-notes (1.43.0-wmf.18; 2024-08-13); removed: MW-1.43-notes (1.43.0-wmf.17; 2024-08-06).Aug 6 2024, 4:00 AM
gerritbot added a comment.Aug 6 2024, 1:11 PM

Change #1052126 abandoned by Wangombe:

[mediawiki/extensions/Translate@master] FakeTTMServer: Rename to FakeTtmServer

Reason:

addressed in I46c7b88cd41c9516d0c5230485e49734ef7fd763

https://gerrit.wikimedia.org/r/1052126

gerritbot added a comment.Aug 8 2024, 1:07 PM

Change #1051708 restored by Wangombe:

[mediawiki/extensions/Translate@master] TTMServer: Rename to TtmServer

https://gerrit.wikimedia.org/r/1051708

gerritbot added a comment.Aug 8 2024, 1:24 PM

Change #1051707 restored by Wangombe:

[mediawiki/extensions/Translate@master] FuzzyLikeThis: Move to TtmServer

https://gerrit.wikimedia.org/r/1051707

gerritbot added a comment.Aug 8 2024, 1:34 PM

Change #1054497 restored by Wangombe:

[mediawiki/extensions/Translate@master] FuzzyLikeThis: Add strict types and perform code imporvements.

https://gerrit.wikimedia.org/r/1054497

gerritbot added a comment.Aug 8 2024, 2:12 PM

Change #1054883 abandoned by Wangombe:

[mediawiki/extensions/Translate@master] FuzzyLikeThis: Move to TtmServerNamespace

Reason:

Change delta is too large to review effectively. Reverting to I83f0a34c1e8ffb10279167e17c3c872ad7453c7b and I99bc02ed57075c5f2b27eda7fb7e317fcf300f92

https://gerrit.wikimedia.org/r/1054883

gerritbot added a comment.Aug 8 2024, 2:27 PM

Change #1054875 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TTMServer: Move to TtmSever namespace

https://gerrit.wikimedia.org/r/1054875

gerritbot added a comment.Aug 8 2024, 2:42 PM

Change #1059013 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TtmServerMessageUpdateJob: Declare strict types on methods

https://gerrit.wikimedia.org/r/1059013

gerritbot added a comment.Aug 8 2024, 3:22 PM

Change #1060870 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Translate@master] Fix TtmServerMessageUpdateJob class name

https://gerrit.wikimedia.org/r/1060870

gerritbot added a comment.Aug 8 2024, 3:24 PM

Change #1060872 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Rename TTMServerMessageUpdateJob to TtmServerMessageUpdateJob

https://gerrit.wikimedia.org/r/1060872

gerritbot added a comment.Aug 8 2024, 3:30 PM

Change #1060870 abandoned by Jakob:

[mediawiki/extensions/Translate@master] Fix TtmServerMessageUpdateJob class name

Reason:

Done in I241101eb3a8d8ff5988aa4869ebd995a7e81c646. I uploaded it first though!! :)

https://gerrit.wikimedia.org/r/1060870

gerritbot added a comment.Aug 8 2024, 4:57 PM

Change #1060872 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Rename TTMServerMessageUpdateJob to TtmServerMessageUpdateJob

https://gerrit.wikimedia.org/r/1060872

gerritbot added a comment.Aug 9 2024, 4:20 PM

Change #1051707 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] FuzzyLikeThis: Move to TtmServer

https://gerrit.wikimedia.org/r/1051707

gerritbot added a comment.Aug 12 2024, 7:50 AM

Change #1061946 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Remove reference to ttmserver/ folder

https://gerrit.wikimedia.org/r/1061946

gerritbot added a comment.Aug 13 2024, 4:30 AM

Change #1054497 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] FuzzyLikeThis: Add strict types and perform code improvements.

https://gerrit.wikimedia.org/r/1054497

ReleaseTaggerBot edited projects, added: MW-1.43-notes (1.43.0-wmf.19; 2024-08-20); removed: MW-1.43-notes (1.43.0-wmf.18; 2024-08-13).Aug 13 2024, 5:00 AM
gerritbot added a comment.Aug 13 2024, 3:28 PM

Change #1061946 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Remove reference to ttmserver/ folder

https://gerrit.wikimedia.org/r/1061946

gerritbot added a comment.Aug 20 2024, 5:05 PM

Change #1051708 abandoned by Wangombe:

[mediawiki/extensions/Translate@master] TTMServer: Rename to TtmServer

Reason:

Merged in I1a90841db3d325447ee6c57a0680d1a3cf85cfd3

https://gerrit.wikimedia.org/r/1051708

abi_ set the point value for this task to 8.Sep 19 2024, 4:47 AM
abi_ mentioned this in T375190: Improve how translation service configuration class is defined.Sep 19 2024, 1:12 PM
abi_ mentioned this in T375194: Review default value for TranslateTranslationDefaultService.Sep 19 2024, 1:30 PM
abi_ closed this task as Resolved.Sep 19 2024, 1:38 PM
abi_ moved this task from In Progress to Done on the LPL Essential (LPL Essential 2024 Jul-Oct) board.

I've created follow up tasks to make configuration changes:

  • T375194: Review default value for TranslateTranslationDefaultService
  • T375190: Improve how translation service configuration class is defined

This task can be resolved since all code changes have been made and deployed for a while now.

gerritbot added a comment.Sep 20 2024, 3:51 AM

Change #1054876 abandoned by Wangombe:

[translatewiki@master] Update reference to TtmServer

Reason:

TtmServer is used in various places. T375194 was created to decide what to do.

https://gerrit.wikimedia.org/r/1054876

gerritbot added a comment.Sep 20 2024, 3:51 AM

Change #1052952 abandoned by Wangombe:

[translatewiki@master] Update reference to ElasticSearchTtmServer

Reason:

TtmServer is used in various places. T375194 was created to decide what to do.

https://gerrit.wikimedia.org/r/1052952

gerritbot added a comment.Sep 20 2024, 3:51 AM

Change #1054869 abandoned by Wangombe:

[operations/mediawiki-config@master] Update reference to ElasticSearchTtmServer

Reason:

TtmServer is used in various places. T375194 was created to decide what to do.

https://gerrit.wikimedia.org/r/1054869

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits