Page MenuHomePhabricator

Diff link giving wrong diff when page title has symbols (&, =)
Closed, ResolvedPublic

Description

I was browsing something out of curiousity and noticed that a diff wouldn't function the way you would expect it to.
The diff in question: https://en.wikipedia.org/w/index.php?title=User_talk:7%266%3Dthirteen&diff=prev&oldid=1142280354
Where the app takes me: https://en.wikipedia.org/w/index.php?title=User_talk%3A7&diff=1048278494&oldid=1047239704&variant=en

I don't really have any computer science background but I have found a lot of bugs that get reported to phab by others. Basically what I'm saying is I'm not sure what I'm doing. This is the first time I've tried to do file a phab ticket by myself. My best guess is that something about the username is causing the issue, like the symbols.

Event Timeline

@Clovermoss, I added Dmitry and Jazmin as subscribers to the ticket, removed the release tag, and added the Android App Backlog that the team is triaging every week.

@Clovermoss Good catch!
Please don't feel put off by Phabricator; your bug reports are welcome in any venue. When writing a Phab task, just put Wikipedia-Android-App-Backlog in the "Tags" field, so that we see it right away. The "Release FY2023-24" board consists of tickets that we have already discussed and committed to building/fixing in the coming quarter(s).

@Clovermoss Actually, could you just clarify how exactly you arrived at the diff in question? i.e. in which screen in the app were you before tapping on the diff and seeing that it's incorrect?

Dbrant claimed this task.

Should already be resolved a while ago. Please reopen if this is still an issue.

jeremyb renamed this task from Diff link giving wrong diff when user in question has symbols in username to Diff link giving wrong diff when page title has symbols (&, =).Sep 9 2024, 7:14 PM

@Clovermoss Actually, could you just clarify how exactly you arrived at the diff in question? i.e. in which screen in the app were you before tapping on the diff and seeing that it's incorrect?

@Clovermoss I also am unsure the exact steps you used, please let us know if you can still make this happen. I was able to view that diff in the app. went to that user page, hamburger, edit history, scroll way back to the right time, click the entry.

FYI for future reference when you wrap a URL in square brackets in phabricator it seems to include the final bracket in the link generated. I fixed that here.