Page MenuHomePhabricator

For [[MediaWiki:Lqt hist comment edited/en]] external link icon is shown
Closed, ResolvedPublic

Description

Because that link is considered external...


Version: unspecified
Severity: normal
Whiteboard: gci2013

Details

Reference
bz33394

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz33394.
bzimport added a subscriber: Unknown Object (MLST).
liangent created this task.Dec 28 2011, 4:52 AM

I think r98690 might fix this, When it's eventually pushed out.

(In reply to comment #1)

I think r98690 might fix this, When it's eventually pushed out.

I don't think so. I spotted it on translatewiki just now which is running trunk.

Adding many blockers of bug 38638 to the list of "easy" bugs, to mark them as candidates for [[mw:Google Code-in]] tasks (gci2013). If you think this bug is not suitable, remove the keyword.

It feels ugly but we can just do this:

  • 'lqt_hist_comment_edited' => 'Comment text [$2 edited]',

+ 'lqt_hist_comment_edited' => 'Comment text <span class="plainlinks">[$2 edited]</span>',

aditya.iiita102 wrote:

Seems fixed

I think this issue is already resolved. Please confirm.

Attached:

The link should just show as a regular blue link. No icon is needed since it is an on-site link.

Change 118212 had a related patch set uploaded by Adi.iiita:
Fixed padlock on thread history for LiquidThreads Bug 33394

https://gerrit.wikimedia.org/r/118212

Change 118212 merged by jenkins-bot:
Fixed padlock on thread history for LiquidThreads extension

https://gerrit.wikimedia.org/r/118212

All patches in this report are merged - assuming this bug is FIXED.
If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.