Page MenuHomePhabricator

[JS] Remove dispatch method
Closed, ResolvedPublic2 Estimated Story Points

Description

Description

Remove the dispatch() method from the Javascript client library.

The dispatch() method was initially introduced during early iterations of the Metrics Platform that used the monoschema. Now that we've pivoted to using the data contract model, this and related methods should be removed in favor the the api submit methods.

This task is dependent on making sure no instruments are currently using monoschema to send events.

Acceptance Criteria

Notes

  1. The JavaScript client can be found here: https://gitlab.wikimedia.org/repos/data-engineering/metrics-platform/-/tree/main/js?ref_type=heads
  2. You'll need to update the JavaScript client once the dispatch() method has been removed. The instructions to do that are here: https://wikitech.wikimedia.org/wiki/Experimentation_Lab/Deploy_client_libraries#JavaScript

Details

Related Changes in Gerrit:
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Removed dispatch method and supporting methods from JS clientrepos/data-engineering/metrics-platform!107sfaciT354822-remove-dispatch-methodmain
Customize query in GitLab

Event Timeline

phuedx renamed this task from [Javascript] Remove dispatch method to [JS] Remove dispatch method.Jan 16 2024, 11:47 AM
phuedx moved this task from Backlog to Client improvements on the Metrics Platform board.
phuedx set the point value for this task to 2.Jan 16 2024, 11:51 AM

Hi and thank you for your interest! Please check thoroughly https://www.mediawiki.org/wiki/New_Developers (and all of its communication section!). The page covers how to get started, assigning tasks, task status, how to find a codebase, how to create patches, where to ask general development questions and where to get help with setup problems, and how to ask good questions. Thanks a lot! :)

Can you please share the repository link?

Aklapper added a subscriber: VirginiaPoundstone.

@VirginiaPoundstone: This seems to be about the Metrics Platform code base thus re-adding that code base project tag (people need to find code bases, see previous comment).

phuedx raised the priority of this task from Low to High.
phuedx added a project: Technical-Debt.
phuedx subscribed.

Unassigning @Abhii5599 due to inactivity since their last comment.

@Abhii5599: If you'd like to work on this task, then please let me know 😄

phuedx removed a project: good first task.

I'm removing the good first task tag as this involves work in multiple repositories.

Change #1203001 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[mediawiki/extensions/EventLogging@master] lib: Update lib/metrics-platform to v4.3.0

https://gerrit.wikimedia.org/r/1203001

Change #1203002 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[mediawiki/vendor@master] Upgrading wikimedia/metrics-platform (4.2.4 => 4.3.0)

https://gerrit.wikimedia.org/r/1203002

Change #1203001 merged by jenkins-bot:

[mediawiki/extensions/EventLogging@master] lib: Update lib/metrics-platform to v4.3.0

https://gerrit.wikimedia.org/r/1203001

Change #1203002 merged by jenkins-bot:

[mediawiki/vendor@master] Upgrading wikimedia/metrics-platform (4.2.4 => 4.3.0)

https://gerrit.wikimedia.org/r/1203002