Page MenuHomePhabricator
Create Task
Maniphest T354905

migrate MediaWiki.timing.editResponseTime to statslib
Closed, DuplicatePublic
Actions

Description

Follow the migration process as outlined below.

  • Secure/Conduct a code review.
  • Deploy the changes to production via the train (https://wikitech.wikimedia.org/wiki/Deployments/Train).
  • Verify that the changes have been successfully implemented.
  • Update the dashboard by replacing the old Graphite metric with the new Prometheus metric.

Please follow the guidelines and standards outlined in the provided documentation:

https://www.mediawiki.org/wiki/Manual:Stats for detailed guidance on the conversion process.
https://drive.google.com/file/d/12yQEuOapkML1vb9MgCaX1QzbLBdXE6X2/view for a video tutorial on the conversion process.
https://docs.google.com/presentation/d/1SZWf_D3mWNX-XHN8PHYI84LDZr6GUQC2AMhZ9mQXCI0/edit#slide=id.g2795460c956_0_23 for slides on the best practices for converting metrics to statslib.

Details

SubjectRepoBranchLines +/-
Migrate `editResponseTime` metric to Prometheus storemediawiki/extensions/WikimediaEventsmaster+37 -18
Migrate `editResponseTime` metric to Prometheus storemediawiki/extensions/WikimediaEventsmaster+30 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

lmata created this task.Jan 11 2024, 9:35 PM
lmata mentioned this in T354908: evaluate and migrate in-use parsoid metrics to statslib.Jan 11 2024, 9:39 PM
lmata mentioned this in T350592: EPIC: migrate in use metrics and dashboards to statslib.Jan 11 2024, 9:44 PM
lmata edited projects, added SRE Observability (FY2023/2024-Q3); removed SRE Observability (FY2023/2024-Q2).Jan 12 2024, 5:36 PM
gerritbot added a comment.Jan 15 2024, 12:05 PM

Change 990639 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/WikimediaEvents@master] Migrate `editResponseTime` metric to Prometheus store

https://gerrit.wikimedia.org/r/990639

gerritbot added a project: Patch-For-Review.Jan 15 2024, 12:05 PM
DAlangi_WMF claimed this task.Jan 15 2024, 12:07 PM
DAlangi_WMF edited projects, added MediaWiki-Platform-Team; removed MediaWiki-Platform-Team (Radar).
DAlangi_WMF moved this task from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
DAlangi_WMF moved this task from Current Sprint to Blocked/waiting on the MediaWiki-Platform-Team board.Jan 23 2024, 12:41 PM

Depends on: T355354 and T355361. Once that work is complete, we can make progress on this.

gerritbot added a comment.Jan 31 2024, 5:14 PM

Change 990639 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Migrate `editResponseTime` metric to Prometheus store

https://gerrit.wikimedia.org/r/990639

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.17; 2024-02-06).Jan 31 2024, 9:00 PM
DAlangi_WMF closed this task as Resolved.Feb 1 2024, 11:56 AM

The tasks that this depends on has been resolved and the patch for this task has been merged as well. Marking this as resolved.

gerritbot added a comment.Feb 7 2024, 5:21 PM

Change 998477 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/WikimediaEvents@master] Remove unused nullEditResponseTime metric

https://gerrit.wikimedia.org/r/998477

Krinkle closed this task as a duplicate of T356810: Migrate MediaWiki.timing.editResponseTime.* to statslib.Feb 7 2024, 5:42 PM
gerritbot added a comment.Feb 8 2024, 10:48 PM

Change 998973 had a related patch set uploaded (by Cwhite; author: Cwhite):

[mediawiki/extensions/WikimediaEvents@master] Migrate `editResponseTime` metric to Prometheus store

https://gerrit.wikimedia.org/r/998973

gerritbot added a comment.Feb 9 2024, 9:36 PM

Change 998973 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Migrate `editResponseTime` metric to Prometheus store

https://gerrit.wikimedia.org/r/998973

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.18; 2024-02-13); removed MW-1.42-notes (1.42.0-wmf.17; 2024-02-06).Feb 9 2024, 10:00 PM
DAlangi_WMF mentioned this in T356810: Migrate MediaWiki.timing.editResponseTime.* to statslib.Feb 27 2024, 10:38 AM
lmata moved this task from Inbox to Done on the SRE Observability (FY2023/2024-Q3) board.Apr 4 2024, 6:11 PM
CDanis mentioned this in T363914: Discrepancy between Graphite & Prometheus editResponseTime counts.May 1 2024, 3:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits