Page MenuHomePhabricator

Migrate MediaWiki.timing.editResponseTime.* to statslib
Closed, ResolvedPublic

Description

Follow the migration process as outlined below.

Secure/Conduct code review(s).
Deploy the changes to production via the train (https://wikitech.wikimedia.org/wiki/Deployments/Train).
Verify that the changes have been successfully implemented.
Update the relevant dashboard(s) by replacing the old Graphite metric(s) with the new Prometheus metric(s).
Please follow the guidelines and standards outlined in the provided documentation:

https://www.mediawiki.org/wiki/Manual:Stats for detailed guidance on the conversion process.
https://drive.google.com/file/d/12yQEuOapkML1vb9MgCaX1QzbLBdXE6X2/view for a video tutorial on the conversion process.
https://docs.google.com/presentation/d/1SZWf_D3mWNX-XHN8PHYI84LDZr6GUQC2AMhZ9mQXCI0/edit#slide=id.g2795460c956_0_23 for slides on the best practices for converting metrics to statslib.

Metric set:

  • MediaWiki.timing.editResponseTime.$percentile
  • MediaWiki.timing.editResponseTime.page.*
  • MediaWiki.timing.editResponseTime.user.*
  • MediaWiki.timing.editResponseTime.page.*.sample_rate
  • MediaWiki.timing.editResponseTime.entry.*
  • MediaWiki.timing.editResponseTime.user.*.sample_rate
  • MediaWiki.timing.editResponseTime.sample_rate
  • MediaWiki.timing.editResponseTime.entry.*.sample_rate

Event Timeline

lmata renamed this task from Migrate <metric(s)> to statslib to Migrate MediaWiki.timing.editResponseTime.* to statslib.Feb 6 2024, 10:07 PM
lmata updated the task description. (Show Details)
lmata updated the task description. (Show Details)

@Krinkle marked T354905: migrate MediaWiki.timing.editResponseTime to statslib as a duplicate of this task but all the work (linked patches) happened in the duplicate instead. Since the duplicate has been long done and resolved, this is resolved as well.

I'll further verify that the WikimediaEvents extension which happens to be where these metrics are emitted from has been fully covered and nothing is left to be done there wrt to the editResponseTime metric. After my verification, if everything is clean, I'll resolve this task.

DAlangi_WMF updated the task description. (Show Details)

Per https://codesearch.wmcloud.org/search/?q=editResponseTime&files=&excludeFiles=&repos=, they've all been migrated to use StatsFactory (StatsLib).