Page MenuHomePhabricator

Review Request: PlaceNewSection extension
Open, Needs TriagePublic

Description

Hello! We would like to deploy this extension in Ruwiki and we really need your help with the support and maintenance of this extension: Since DiscussionTools require some fixes to work with it (highlightning, for example). Tell me if you need anything else from me and if you can help :)

The PlaceNewSection extension introduces two magic words, __ADDNEWSECTIONBELOW__ and __ADDNEWSECTIONABOVE__, that control placement of new talk page sections. Adding __ADDNEWSECTIONBELOW__ create a way to post new topics on top.

Related: T313165: Allow posting new sections to top of page on a per-page basis by DiscussionTools

Project Information

Event Timeline

We talked about this in some Editing team meetings a while ago, and at the time we felt that we didn't think there were any security issues with it, but we wouldn't want to deploy this to WMF wikis without making some changes to how it works. I don't know whether you'd like to put off formal security review until after anything like that happened...

@DLynch Hi! What changes are you talking about? :)

My recollection was that in particular there was debate about whether it should be implemented as new magic words, or as parser functions. @cscott may want to speak more on that.

We also felt it'd need to work with the DiscussionTools new-topic tool. Then, given that and the relative tininess of it, it might make sense to just fold it into DiscussionTools via a patch, rather than needing to maintain inter-extension dependencies on that kind of placement code.

My recollection was that in particular there was debate about whether it should be implemented as new magic words, or as parser functions. @cscott may want to speak more on that.

We also felt it'd need to work with the DiscussionTools new-topic tool. Then, given that and the relative tininess of it, it might make sense to just fold it into DiscussionTools via a patch, rather than needing to maintain inter-extension dependencies on that kind of placement code.

This extension currently works with DT and this is the main reason why I am asking for it to be enabled, as several wikis still have the creation of new topics broken and everyone has to sign messages using ~~~~. Please give me some hints on my next steps :)

Sorry, I specifically meant the client-side part of DT — my understanding is that currently it’ll correctly place the new topic wherever it’s configured to, but the DT editor will appear at the bottom of the page always instead of where the insertion will happen.

Sorry, I specifically meant the client-side part of DT — my understanding is that currently it’ll correctly place the new topic wherever it’s configured to, but the DT editor will appear at the bottom of the page always instead of where the insertion will happen.

@Ernstkm, hi! Can you make the extension support DT? :)

@Ernstkm, hi! Can you make the extension support DT? :)

As long as PlaceNewSection continues to shamble along on our internal wiki, with the built-in Talk: pages, I won't be able to justify spending any more time on it. Sorry 'bout that.

It's a small miracle that I was able to patch it to work in the 1.3x days!