Flow\Tests\SpamFilter\ConfirmEditTest::testValidateDoesntBlowUp: RuntimeException: Database backend disabled
Closed, ResolvedPublic
Actions

Description

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php81-noselenium-docker/25784/console

This is blocking merges to other repos such as OATHAuth.

07:23:43 There was 1 error:
07:23:43 
07:23:43 1) Flow\Tests\SpamFilter\ConfirmEditTest::testValidateDoesntBlowUp
07:23:43 RuntimeException: Database backend disabled
07:23:43 
07:23:43 /workspace/src/includes/libs/rdbms/loadbalancer/LoadBalancerDisabled.php:72
07:23:43 /workspace/src/includes/libs/rdbms/lbfactory/LBFactory.php:562
07:23:43 /workspace/src/includes/libs/rdbms/lbfactory/LBFactory.php:535
07:23:43 /workspace/src/includes/libs/rdbms/DBAccessObjectUtils.php:114
07:23:43 /workspace/src/includes/user/User.php:402
07:23:43 /workspace/src/includes/user/UserGroupManager.php:334
07:23:43 /workspace/src/includes/Permissions/PermissionManager.php:1585
07:23:43 /workspace/src/includes/Permissions/PermissionManager.php:1536
07:23:43 /workspace/src/extensions/Flow/includes/Model/AbstractRevision.php:256
07:23:43 /workspace/src/extensions/Flow/includes/Model/AbstractRevision.php:283
07:23:43 /workspace/src/extensions/Flow/tests/phpunit/integration/SpamFilter/ConfirmEditTest.php:41

Details

Subject	Repo	Branch	Lines +/-
tests: Add ConfirmEditTest to Database group	mediawiki/extensions/Flow	REL1_41	+2 -0
tests: Add ConfirmEditTest to Database group	mediawiki/extensions/Flow	REL1_40	+2 -0
tests: Add ConfirmEditTest to Database group	mediawiki/extensions/Flow	REL1_39	+2 -0
tests: Add ConfirmEditTest to Database group	mediawiki/extensions/Flow	master	+2 -0

Customize query in gerrit

Event Timeline

taavi triaged this task as Unbreak Now! priority.Feb 4 2024, 9:37 AM

taavi created this task.

Restricted Application added a project: Growth-Team. · View Herald TranscriptFeb 4 2024, 9:37 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

taavi added a project: LibUp.Feb 4 2024, 1:52 PM

taavi moved this task from Backlog to Common build issues on the LibUp board.

Michael subscribed.Feb 5 2024, 2:18 PM

Not sure if it is related, but I'm seeing that error on a LibUp change for the ArticlePlaceholder extensions on the REL1_41 branch. It tries to run GeoData extension tests and there is always an interaction with DiscussionTools in the stacktrace. It works fine on master though.

I'm not adding the respective tags here, because I'm not sure that it is actually the same root cause.

14:10:44 1) GeoData\Test\TagTest::testLooseTagParsing with data set #0 ('{{#coordinates: 10|20|primary}}', GeoData\Coord Object (...))
14:10:44 RuntimeException: Database backend disabled
14:10:44 
14:10:44 /workspace/src/includes/libs/rdbms/loadbalancer/LoadBalancerDisabled.php:96
14:10:44 /workspace/src/includes/cache/LinkCache.php:442
14:10:44 /workspace/src/includes/cache/LinkCache.php:477
14:10:44 /workspace/src/includes/page/PageStore.php:189
14:10:44 /workspace/src/includes/page/PageStore.php:155
14:10:44 /workspace/src/includes/page/PageStore.php:327
14:10:44 /workspace/src/includes/title/Title.php:3847
14:10:44 /workspace/src/includes/title/Title.php:2603
14:10:44 /workspace/src/extensions/DiscussionTools/includes/Hooks/HookUtils.php:99
14:10:44 /workspace/src/extensions/DiscussionTools/includes/Hooks/HookUtils.php:367
14:10:44 /workspace/src/extensions/DiscussionTools/includes/Hooks/ParserHooks.php:66
14:10:44 /workspace/src/includes/HookContainer/HookContainer.php:161
14:10:44 /workspace/src/includes/HookContainer/HookRunner.php:2903
14:10:44 /workspace/src/includes/parser/Parser.php:1690
14:10:44 /workspace/src/includes/parser/Parser.php:654
14:10:44 /workspace/src/extensions/GeoData/tests/phpunit/TagTest.php:39
14:10:44 /workspace/src/extensions/GeoData/tests/phpunit/TagTest.php:77
14:10:44 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97

https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php74-noselenium-docker/43530/console

In T356589#9513197, @Michael wrote:

Not sure if it is related, but I'm seeing that error on a LibUp change for the ArticlePlaceholder extensions on the REL1_41 branch. It tries to run GeoData extension tests and there is always an interaction with DiscussionTools in the stacktrace. It works fine on master though.

I don't see Flow anywhere in that stack trace so I suspect that has a different cause.

Sgs moved this task from Inbox to Up Next on the Growth-Team board.Feb 6 2024, 4:04 PM

KStoller-WMF moved this task from Up Next to Sprint 7 (Growth Team) on the Growth-Team board.Feb 6 2024, 5:45 PM

KStoller-WMF edited projects, added Growth-Team (Sprint 7 (Growth Team)); removed Growth-Team.

Change 997930 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/Flow@master] tests: Add ConfirmEditTest to Database group

https://gerrit.wikimedia.org/r/997930

gerritbot added a project: Patch-For-Review.Feb 6 2024, 6:21 PM

Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 7 (Growth Team)) board.Feb 6 2024, 6:24 PM

Change 997930 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] tests: Add ConfirmEditTest to Database group

https://gerrit.wikimedia.org/r/997930

Maintenance_bot removed a project: Patch-For-Review.Feb 6 2024, 7:30 PM

taavi closed this task as Resolved.Feb 6 2024, 9:06 PM

taavi assigned this task to Urbanecm_WMF.

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.18; 2024-02-13).Feb 6 2024, 10:01 PM

Change #1031471 had a related patch set uploaded (by Reedy; author: Urbanecm):

[mediawiki/extensions/Flow@REL1_41] tests: Add ConfirmEditTest to Database group

https://gerrit.wikimedia.org/r/1031471

Change #1031472 had a related patch set uploaded (by Reedy; author: Urbanecm):

[mediawiki/extensions/Flow@REL1_40] tests: Add ConfirmEditTest to Database group

https://gerrit.wikimedia.org/r/1031472

Change #1031473 had a related patch set uploaded (by Reedy; author: Urbanecm):

[mediawiki/extensions/Flow@REL1_39] tests: Add ConfirmEditTest to Database group

https://gerrit.wikimedia.org/r/1031473

Change #1031473 merged by jenkins-bot: