Suggestion: Flip legend keys for inline diff
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Feb 9 2024, 4:23 PM

Description

In T350181#9526951, @Nux wrote:

Could you flip the legend in HTML? I think "removed" belongs on the left side, and this is where inline diff puts "removed".

I have CSS for that, but I think it would be better to do it in the structure.
.mw-diff-inline-legend {
	display:flex;
	flex-direction: row-reverse;
}

QA Results - Beta

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T357150 here

Details

	Subject	Repo	Branch	Lines +/-
	diff: Change order of inline diff legend elements	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T350181: Enable desktop diff page on mobile site
Mentioned Here: rMW1cc8210446bb: Merge "wfEscapeWikiText: add missing `\r!` case for symmetry"
T352491: Image thumbnails in Wikipedia Preview should have cursor:pointer;
T350181: Enable desktop diff page on mobile site

Event Timeline

Jdlrobson created this task.Feb 9 2024, 4:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 9 2024, 4:23 PM

Jdlrobson mentioned this in T350181: Enable desktop diff page on mobile site.Feb 9 2024, 4:25 PM

@Aklapper curiously, what makes this fall on Community Tech's radar?

Change 1003583 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/core@master] diff: Change order of inline diff legend elements

https://gerrit.wikimedia.org/r/1003583

gerritbot added a project: Patch-For-Review.Feb 15 2024, 5:00 AM

@JWheeler-WMF CommTech added the inline diff legend as part of Better-Diffs-2023.

This is a simple change; I've made a patch.

Samwilson moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Kanban) board.Feb 15 2024, 5:02 AM

Change 1003583 merged by jenkins-bot:

[mediawiki/core@master] diff: Change order of inline diff legend elements

https://gerrit.wikimedia.org/r/1003583

MusikAnimal moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Kanban) board.Feb 15 2024, 6:02 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 15 2024, 6:30 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.19; 2024-02-20).Feb 15 2024, 8:00 PM

@Samwilson "Content deleted" is now to the left for the inline diff legend as seen in the screenshot. This will move to Done. Thanks for all your work!

Status: ✅PASS
Environment: Beta: 1.42.0-alpha (1cc8210)
OS: macOS Sonoma 14.2.1
Browser: Chrome 121, Firefox 123, Safari 17.3, Edge 121
Skins. Vector 2022, Vector 2010, Minerva, Monobook, Timeless
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en.wikipedia.org/w/index.php?title=File%3AMediawiki_diffView.JPG&diff=449475711&oldid=449471099
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=File%3AFedov_31.jpg&diff=614265&oldid=614264

✅AC1: https://phabricator.wikimedia.org/T352491

Previous	Latest Patch

GMikesell-WMF updated the task description. (Show Details)Feb 15 2024, 10:06 PM

GMikesell-WMF moved this task from QA 🐛 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.

MusikAnimal closed this task as Resolved.Feb 16 2024, 3:28 PM

MusikAnimal claimed this task.

MusikAnimal reassigned this task from MusikAnimal to Samwilson.

MusikAnimal subscribed.

In T357150#9544477, @JWheeler-WMF wrote:

@Aklapper curiously, what makes this fall on Community Tech's radar?

@JWheeler-WMF Hi! Herald. (For venues to bring up general questions about Phabricator, please see the links on the frontpage - thanks a lot!)

Suggestion: Flip legend keys for inline diffClosed, ResolvedPublicBUG REPORTActions