[DOT] Perform necessary redirect after editing terms in termbox v2 / mobile termbox
Closed, ResolvedPublic
Actions

Description

The edit request made by the termbox may create a temporary account, in which case the API will return (once T357024 is implemented) a URL that we need to redirect to.

Details

Subject	Repo	Branch	Lines +/-
termbox: update to 2024-03-14-121904-production	operations/deployment-charts	master	+2 -2
Process temp user authentication redirects in API edit responses	mediawiki/extensions/Wikibase	master	+44 -2
Redirect from termbox if edit creates new temporary user	wikibase/termbox	master	+254 -78

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
In Progress	Niharika	T324492 Temporary accounts - MVP
Open	None	T326816 Update features for IP Masking
Open	None	T326908 Update WMDE Engineering-owned products that may be affected by IP Masking
Resolved	Arian_Bozorg	T351968 Update Wikidata-related extensions for IP Masking
Resolved	Arian_Bozorg	T357020 [DOT] Perform necessary redirects after creating temporary account in Wikidata-related extensions
Resolved	ArthurTaylor	T357151 [DOT] Perform necessary redirect after editing terms in termbox v2 / mobile termbox

Event Timeline

Lucas_Werkmeister_WMDE created this task.Feb 9 2024, 4:23 PM

Lucas_Werkmeister_WMDE mentioned this in T357020: [DOT] Perform necessary redirects after creating temporary account in Wikidata-related extensions.Feb 9 2024, 4:26 PM

Lucas_Werkmeister_WMDE moved this task from Incoming to [DOT] By Project on the wmde-wikidata-tech board.

ArthurTaylor moved this task from Incoming to Unified DOT Backlog on the Wikidata Dev Team board.Feb 12 2024, 7:42 AM

Lucas_Werkmeister_WMDE moved this task from [DOT] By Project to [DOT] Prioritized on the wmde-wikidata-tech board.Feb 12 2024, 10:45 AM

ArthurTaylor edited projects, added Wikidata Dev Team (Wikidata.org Slice); removed Wikidata Dev Team.Feb 13 2024, 8:10 AM

ArthurTaylor moved this task from In Task Breakdown to Ready for Development on the Wikidata Dev Team (Wikidata.org Slice) board.

Maintenance_bot moved this task from [DOT] Prioritized to Ongoing on the wmde-wikidata-tech board.Feb 13 2024, 8:29 AM

ArthurTaylor claimed this task.Feb 13 2024, 12:42 PM

ArthurTaylor moved this task from Ready for Development to In Development on the Wikidata Dev Team (Wikidata.org Slice) board.

Lucas_Werkmeister_WMDE added a project: Wikidata-Termbox.Feb 14 2024, 9:29 AM

Change 1004733 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[wikibase/termbox@master] Redirect from termbox if edit creates new temporary user

https://gerrit.wikimedia.org/r/1004733

gerritbot added a project: Patch-For-Review.Feb 19 2024, 3:23 PM

The changes are ready and the tests pass locally. The CI build fails - apparently it doesn't like bringing in dependent changes (this change Depends-On T357499 in the current implementation). We can wait for T357499 to get merged and then re-run the CI for this.

ArthurTaylor removed ArthurTaylor as the assignee of this task.Feb 20 2024, 8:45 AM

ArthurTaylor subscribed.

ArthurTaylor moved this task from Ready for Peer Review to In Development on the Wikidata Dev Team (Wikidata.org Slice) board.Feb 20 2024, 9:21 AM

ArthurTaylor claimed this task.Feb 20 2024, 9:37 AM

Okay - CI error was unrelated to Depends-On. I found the failing build and made a fix - that's passing again now.

ArthurTaylor removed ArthurTaylor as the assignee of this task.Feb 20 2024, 9:55 AM

ArthurTaylor moved this task from In Development to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.

Change 1007851 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Process temp user authentication redirects in API edit responses

https://gerrit.wikimedia.org/r/1007851

ArthurTaylor assigned this task to Lucas_Werkmeister_WMDE.Mar 1 2024, 1:09 PM

ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.

Change 1004733 merged by jenkins-bot:

[wikibase/termbox@master] Redirect from termbox if edit creates new temporary user

https://gerrit.wikimedia.org/r/1004733

ArthurTaylor mentioned this in rWBTB094cf73d8c51: Redirect from termbox if edit creates new temporary user.Mar 1 2024, 1:22 PM

Change 1007851 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Process temp user authentication redirects in API edit responses

https://gerrit.wikimedia.org/r/1007851

I think we can close this directly and do the verification in the parent task.

Maintenance_bot removed a project: Patch-For-Review.Mar 1 2024, 2:30 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.21; 2024-03-05).Mar 1 2024, 4:00 PM

Change #1007643 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[operations/deployment-charts@master] termbox: update to 2024-03-14-121904-production

https://gerrit.wikimedia.org/r/1007643

gerritbot added a project: Patch-For-Review.Apr 5 2024, 2:02 PM

Change #1007643 merged by jenkins-bot: