ipblocks/block divergence in write-both mode
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	tstarling
	Feb 13 2024, 12:12 AM

Description

Beta currently has $wgBlockTargetMigrationStage = SCHEMA_COMPAT_READ_OLD | SCHEMA_COMPAT_WRITE_BOTH. @dom_walden reports that differences between the two tables have developed in some wikis.

In T355034#9534177, @dom_walden wrote:

@tstarling If an autoblock exists for an IP and I try to create a block for the same IP, it gets inserted into ipblocks but not into block/block_target. On Special:Block, I see the message The block could not be made, but no existing block was found for "<ip>". If this problem persists, please report it. even though the block is created. Also happens when creating a global block and select the option to create a local block (except I don't see the message). Let me know if you would like me to raise a separate bug.

Did the maintenance scripts run correctly on beta? I notice that en_rtlwiki has nothing in block but has 4 (non-expired) blocks in ipblocks.

On enwiki beta, there are a few rows in ipblocks that are not in block. For example, there is a block against RebeccawlqphbcvaeFiora in ipblocks but not block. They all seem to have ipb_user=0, which I assume is wrong. Perhaps leftover from the actor migration project.

In dewiki beta, there is an extra block with timestamp 2024-02-12 08:59:41, which is long after the migration script finished:

MariaDB [dewiki]> select bl_id,bl_timestamp,ipb_timestamp from ipblocks,block,block_target where ipb_id=bl_id and bl_target=bt_id and bl_id>15942;
+-------+----------------+----------------+
| bl_id | bl_timestamp   | ipb_timestamp  |
+-------+----------------+----------------+
| 15944 | 20240208072137 | 20240208072137 |
| 15947 | 20240212141929 | 20240212141929 |
| 15948 | 20240212090038 | 20240212085941 |
| 15949 | 20240212094313 | 20240212090038 |
| 15950 | 20240212094539 | 20240212094450 |
| 15951 | 20240212094703 | 20240212094620 |
| 15952 | 20240212095221 | 20240212094703 |
+-------+----------------+----------------+

I'll isolate and fix the bugs, then truncate the tables on beta and run the migration script again.

Details

	Subject	Repo	Branch	Lines +/-
	block: Include bt_auto in acquireTarget() conditions	mediawiki/core	master	+6 -2
	block: When inserting in write-both mode, ensure the ID remains synchronised	mediawiki/core	master	+13 -1

Customize query in gerrit

Related Objects

Mentioned In: T355034: Deploy new block_target schema
Mentioned Here: rMW15251666a985: Merge "Clarify that partial action blocks block an action sitewide"
T355034: Deploy new block_target schema

Event Timeline

tstarling created this task.Feb 13 2024, 12:12 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 13 2024, 12:12 AM

tstarling mentioned this in T355034: Deploy new block_target schema.Feb 13 2024, 12:13 AM

Change 1002683 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] block: When inserting in write-both mode, ensure the ID remains synchronised

https://gerrit.wikimedia.org/r/1002683

gerritbot added a project: Patch-For-Review.Feb 13 2024, 12:21 AM

In DatabaseBlockStore::acquireTarget(), the conditions do not include bt_auto. That's a major bug and it explains Dom's report about blocking an IP that's already autoblocked, and also the missing block on beta dewiki.

Change 1002713 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] block: Include bt_auto in acquireTarget() conditions

https://gerrit.wikimedia.org/r/1002713

tstarling added a project: Community-Tech (CommTech-Kanban).Feb 13 2024, 6:24 AM

tstarling moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Kanban) board.

Change 1002683 merged by jenkins-bot:

[mediawiki/core@master] block: When inserting in write-both mode, ensure the ID remains synchronised

https://gerrit.wikimedia.org/r/1002683

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.19; 2024-02-20).Feb 14 2024, 7:01 AM

Change 1002713 merged by jenkins-bot:

[mediawiki/core@master] block: Include bt_auto in acquireTarget() conditions

https://gerrit.wikimedia.org/r/1002713

Maintenance_bot removed a project: Patch-For-Review.Feb 16 2024, 10:30 PM

HMonroy moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Kanban) board.Feb 16 2024, 11:27 PM

Mentioned in SAL (#wikimedia-releng) [2024-02-19T02:54:01Z] <TimStarling> on deployment-deploy03 truncate tables block and block_target on all beta wikis T357366

Mentioned in SAL (#wikimedia-releng) [2024-02-19T02:57:45Z] <TimStarling> on deployment-deploy03 running foreachwiki maintenance/migrateBlocks.php again (T355034, T357366)

I have not been able to find a case where the IDs in ipblocks are different from those in block.

I can also create a regular block against an IP if that IP is also autoblocked, without any issue.

I have not found any other inconsistencies.

I also ran the attached query against all the wikis on beta and found no inconsistencies (except those noted in the last paragraph of T355034#9534177).

monitor.txt2 KBDownload

Test environment: Mainly https://en.wikipedia.beta.wmflabs.org MediaWiki 1.42.0-alpha (1525166) 12:18, 20 February 2024.

MusikAnimal closed this task as Resolved.Feb 21 2024, 8:01 PM

	F42002255: monitor.txt
	Feb 20 2024, 2:30 PM

ipblocks/block divergence in write-both modeClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

ipblocks/block divergence in write-both mode
Closed, ResolvedPublic
Actions