Page MenuHomePhabricator

Automatically allow <pages> tag in message translations
Closed, ResolvedPublicBUG REPORT

Description

The i18n bot change https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ProofreadPage/+/1003329 had to be manually merged because the message translation included a <pages> tag, which is unrecognized by Jenkins job configuration:

[mediawiki-i18n-check-docker@2] $ /bin/bash /tmp/jenkins17006128558641712628.sh
+ cd src
++ pwd
+ git config --global --add safe.directory /srv/jenkins/workspace/mediawiki-i18n-check-docker@2/src
++ mktemp
+ additions=/tmp/tmp.qc6S2C9qmT
+ git show FETCH_HEAD -U0
+ grep '^+'
+ contains_disallowed_html /tmp/tmp.qc6S2C9qmT
+ cat /tmp/tmp.qc6S2C9qmT
+ sed -E -e 's/<\/? ?(abbr|span|br|strong|em|pre|nowiki|charinsert|b|del|code|kbd|p|tt|div|i|big|sup|sub|samp|var|small|h1|h2|h3|h4|u|ol|ul|li|mark|user|page|hr|templatestyles|NDL|math|syntaxhighlight|templatedata|pagelist|bdi|ref|dt|dd|dl)( ((class|id|title|lang|xml:lang|dir|xmlns|display|alttext)=\\?["'\''][^=<>"'\'']*\\?["'\'']))* ?\/?>//g' -e 's/<!--//g' -e 's/<https?:\/\/[a-zA-Z0-9./-]*>//g'
+ grep '<'
+	"proofreadpage_nosuch_index_category-desc": "Uma etiqueta <pages/> faz referência a uma página de índice que não existe.",
+ echo 'HTML detected. Manual review required'
HTML detected. Manual review required
+ exit 1

<pagelist> from the same ProofreadPage extension are already recognized, so <pages> should be recognized, too.

Event Timeline

Change 1003764 had a related patch set uploaded (by Amire80; author: Amire80):

[integration/config@master] Change <page> to <pages> in message XML tag checks

https://gerrit.wikimedia.org/r/1003764

Note: the <page> is added in T222216: Improve i18n CI checker which mentions (in parent task) usage in Toolforge tools.

Change 1003764 merged by jenkins-bot:

[integration/config@master] Add <pages> to message XML tag checks

https://gerrit.wikimedia.org/r/1003764