Page MenuHomePhabricator
Create Task
Maniphest T357794

Update CodeMirror integrations in preparation for CodeMirror 6 upgrade
Open, Stalled, Needs TriagePublic
Actions

Description

This task tracks changes needed to extensions and skins for compatibility with CodeMirror 6 (T259059).

Deployed at Wikimedia
Others

Details

SubjectRepoBranchLines +/-
Make VisualEditor CodeMirror styles target CodeMirror 6mediawiki/skins/Timelessmaster+7 -3
ResizingDragBar: force CodeMirror to have 100% heightmediawiki/extensions/WikiEditormaster+7 -0
CodeMirrorWikiEditor: Remove hack to fix height in WikiEditormediawiki/extensions/CodeMirrormaster+3 -53
ext.charinsert.js: remove special CodeMirror handlingmediawiki/extensions/CharInsertmaster+2 -8
extension.json: register 'proofread-page' in CodeMirrorContentModelsmediawiki/extensions/ProofreadPagemaster+5 -0
CM6: use textarea height unless WikiEditor's Realtime Preview is loadedmediawiki/extensions/CodeMirrormaster+80 -16
CodeMirror: default to using the same height as the textareamediawiki/extensions/CodeMirrormaster+11 -3
ext.proofreadpage.page.edit: fixes for CodeMirror 6 compatibilitymediawiki/extensions/ProofreadPagemaster+32 -7
HelpPanelLogger: add check for CodeMirror 6 elementmediawiki/extensions/GrowthExperimentsmaster+1 -1
Remove unnecessary CodeMirror skin stylesmediawiki/skins/Timelessmaster+0 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

MusikAnimal created this task.Feb 16 2024, 5:02 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptFeb 16 2024, 5:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
MusikAnimal raised the priority of this task from Medium to Needs Triage.Feb 16 2024, 5:02 PM
MusikAnimal edited projects, added Community-Tech (CommTech-Kanban); removed Community-Tech.
MusikAnimal moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Kanban) board.
gerritbot added a comment.Feb 16 2024, 5:04 PM

Change 1004201 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CharInsert@master] ext.charinsert.js: remove special CodeMirror handling

https://gerrit.wikimedia.org/r/1004201

gerritbot added a project: Patch-For-Review.Feb 16 2024, 5:04 PM
MusikAnimal mentioned this in T259059: Upgrade to CodeMirror 6.Feb 16 2024, 5:05 PM
MusikAnimal added a parent task: T259059: Upgrade to CodeMirror 6.
gerritbot added a comment.Feb 20 2024, 3:14 AM

Change 1004802 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/GrowthExperiments@master] HelpPanelLogger: add check for CodeMirror 6 element

https://gerrit.wikimedia.org/r/1004802

gerritbot added a comment.Feb 20 2024, 5:12 AM

Change 1004807 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/ProofreadPage@master] ext.proofreadpage.page.edit.css: fixes for CodeMirror 6 compatibility

https://gerrit.wikimedia.org/r/1004807

MusikAnimal updated the task description. (Show Details)Feb 20 2024, 4:46 PM
MusikAnimal updated the task description. (Show Details)Feb 20 2024, 4:49 PM
Restricted Application added a subscriber: Lens0021. · View Herald TranscriptFeb 20 2024, 4:49 PM
gerritbot added a comment.Feb 20 2024, 10:13 PM

Change 1005178 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/skins/Timeless@master] Remove unnecessary CodeMirror skin styles

https://gerrit.wikimedia.org/r/1005178

MusikAnimal updated the task description. (Show Details)Feb 20 2024, 10:18 PM
MusikAnimal updated the task description. (Show Details)Feb 20 2024, 10:21 PM
MusikAnimal moved this task from Backlog to CodeMirror 6 migration on the MediaWiki-extensions-CodeMirror board.Feb 20 2024, 10:53 PM
gerritbot added a comment.Feb 22 2024, 9:20 PM

Change 1005841 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] CodeMirror: default to using the same height as the textarea

https://gerrit.wikimedia.org/r/1005841

gerritbot added a comment.Feb 22 2024, 9:29 PM

Change 1005178 merged by jenkins-bot:

[mediawiki/skins/Timeless@master] Remove unnecessary CodeMirror skin styles

https://gerrit.wikimedia.org/r/1005178

MusikAnimal updated the task description. (Show Details)Feb 22 2024, 9:47 PM
MusikAnimal changed the task status from Open to In Progress.Feb 24 2024, 4:16 AM
MusikAnimal moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Kanban) board.

This is still in progress but there are patches awaiting review.

MusikAnimal updated the task description. (Show Details)Feb 24 2024, 4:26 AM
gerritbot added a comment.Feb 24 2024, 11:46 AM

Change 1004802 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] HelpPanelLogger: add check for CodeMirror 6 element

https://gerrit.wikimedia.org/r/1004802

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.20; 2024-02-27).Feb 24 2024, 1:00 PM
MusikAnimal updated the task description. (Show Details)Feb 24 2024, 11:15 PM
gerritbot added a comment.Feb 27 2024, 3:30 AM

Change 1005841 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] CodeMirror: default to using the same height as the textarea

https://gerrit.wikimedia.org/r/1005841

gerritbot added a comment.Feb 27 2024, 3:45 AM

Change 1004807 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] ext.proofreadpage.page.edit: fixes for CodeMirror 6 compatibility

https://gerrit.wikimedia.org/r/1004807

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.21; 2024-03-05); removed MW-1.42-notes (1.42.0-wmf.20; 2024-02-27).Feb 27 2024, 4:00 AM
MusikAnimal updated the task description. (Show Details)Feb 27 2024, 8:23 PM
MusikAnimal moved this task from Review/Feedback 💬 to In Development 💻 on the Community-Tech (CommTech-Kanban) board.
gerritbot added a comment.Feb 28 2024, 5:45 AM

Change 1007035 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] CM6: use textarea height unless WikiEditor's ResizingDragBar is present

https://gerrit.wikimedia.org/r/1007035

MusikAnimal moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Kanban) board.Feb 29 2024, 11:30 PM
gerritbot added a comment.Mar 1 2024, 1:14 AM

Change 1007747 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/ProofreadPage@master] extension.json: register 'proofread-page' in CodeMirrorContentModels

https://gerrit.wikimedia.org/r/1007747

MusikAnimal updated the task description. (Show Details)Mar 1 2024, 1:15 AM
gerritbot added a comment.Mar 1 2024, 1:16 AM

Change 1007746 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] Hooks: further limit where CodeMirror RL modules are loaded

https://gerrit.wikimedia.org/r/1007746

gerritbot added a comment.Mar 5 2024, 7:37 AM

Change 1007035 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] CM6: use textarea height unless WikiEditor's Realtime Preview is loaded

https://gerrit.wikimedia.org/r/1007035

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.22; 2024-03-12); removed MW-1.42-notes (1.42.0-wmf.21; 2024-03-05).Mar 5 2024, 10:01 AM
MusikAnimal updated the task description. (Show Details)Mar 7 2024, 12:47 AM
gerritbot added a comment.Mar 7 2024, 9:29 PM

Change 1009608 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/WikiEditor@master] ResizingDragBar: force CodeMirror to have 100% height

https://gerrit.wikimedia.org/r/1009608

gerritbot added a comment.Mar 7 2024, 9:30 PM

Change 1009609 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] CodeMirrorWikiEditor: Remove hack to fix height in WikiEditor

https://gerrit.wikimedia.org/r/1009609

gerritbot added a comment.Mar 11 2024, 10:26 PM

Change 1007747 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] extension.json: register 'proofread-page' in CodeMirrorContentModels

https://gerrit.wikimedia.org/r/1007747

gerritbot added a comment.Mar 11 2024, 11:15 PM

Change 1004201 merged by jenkins-bot:

[mediawiki/extensions/CharInsert@master] ext.charinsert.js: remove special CodeMirror handling

https://gerrit.wikimedia.org/r/1004201

gerritbot added a comment.Mar 13 2024, 11:35 PM

Change 1009608 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] ResizingDragBar: force CodeMirror to have 100% height

https://gerrit.wikimedia.org/r/1009608

gerritbot added a comment.Mar 13 2024, 11:35 PM

Change 1009609 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] CodeMirrorWikiEditor: Remove hack to fix height in WikiEditor

https://gerrit.wikimedia.org/r/1009609

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.23; 2024-03-19); removed MW-1.42-notes (1.42.0-wmf.22; 2024-03-12).Mar 14 2024, 1:00 AM
MusikAnimal removed a project: Community-Tech (CommTech-Kanban).Mar 14 2024, 6:07 PM

That should be it for WMF-deployed integrations. I'll work on the others in my spare time.

gerritbot added a comment.Aug 20 2024, 8:49 PM

Change #1064101 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/skins/Timeless@master] Make VisualEditor CodeMirror styles target CodeMirror 6

https://gerrit.wikimedia.org/r/1064101

gerritbot added a comment.Aug 21 2024, 2:51 AM

Change #1064101 merged by jenkins-bot:

[mediawiki/skins/Timeless@master] Make VisualEditor CodeMirror styles target CodeMirror 6

https://gerrit.wikimedia.org/r/1064101

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.20; 2024-08-27).Aug 21 2024, 3:00 AM
Func removed a project: Patch-For-Review.Wed, Dec 11, 6:50 PM
MusikAnimal changed the task status from In Progress to Stalled.Thu, Dec 12, 10:47 PM

Remaining integrations will have to be fixed by respective maintainers.

I'll send an email to wikitech-l soon announcing the deprecations, as part of T373720.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits