Page MenuHomePhabricator
Create Task
Maniphest T357812

`DOMCompat::querySelector( $fragment, 'mw\\:editsection' )` throws "InvalidArgumentException: Unknown Selector: :editsection"
Closed, ResolvedPublic
Actions

Description

DOMCompat::querySelector( $fragment, 'mw\\:editsection' ) throws "InvalidArgumentException: Unknown Selector: :editsection" (when $fragment is a DOMDocumentFragment). It works when called on a DOMElement.

Details

SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to 0.19.0-a23mediawiki/vendormaster+209 -79
Bump wikimedia/zest-css dependency to 3.0.1mediawiki/services/parsoidmaster+1 -1
Update wikimedia/zest-css to 3.0.1mediawiki/vendormaster+153 -100
Correctly handle tag and class names with special charactersmediawiki/libs/Zestmaster+85 -3
Fix matching tag names that require escaping in doc fragmentsmediawiki/libs/Zestmaster+14 -5
Customize query in gerrit

Event Timeline

matmarex created this task.Feb 16 2024, 7:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 16 2024, 7:24 PM
gerritbot added a comment.Feb 17 2024, 3:08 AM

Change 1004290 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/libs/Zest@master] Fix matching tag names that require escaping in doc fragments

https://gerrit.wikimedia.org/r/1004290

gerritbot added a project: Patch-For-Review.Feb 17 2024, 3:08 AM

Change 1004291 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Remove workaround for T357812

https://gerrit.wikimedia.org/r/1004291

ihurbain assigned this task to cscott.Feb 22 2024, 3:17 PM
ihurbain moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.
ihurbain added a project: Content-Transform-Team-WIP.
gerritbot added a comment.Feb 24 2024, 5:21 PM

Change 1006092 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/libs/Zest@master] Correctly handle tag and class names with special characters

https://gerrit.wikimedia.org/r/1006092

gerritbot added a comment.Feb 27 2024, 12:40 AM

Change 1004290 abandoned by Bartosz Dziewoński:

[mediawiki/libs/Zest@master] Fix matching tag names that require escaping in doc fragments

Reason:

Let's use Scott's version

https://gerrit.wikimedia.org/r/1004290

MSantos moved this task from Backlog to Code Review on the Content-Transform-Team-WIP board.Mar 4 2024, 3:54 PM
MSantos added a project: Essential-Work.Mar 4 2024, 4:00 PM
ssastry moved this task from Code Review to To Verify on the Content-Transform-Team-WIP board.Mar 5 2024, 9:58 PM
gerritbot added a comment.Mar 11 2024, 5:02 PM

Change 1006092 merged by jenkins-bot:

[mediawiki/libs/Zest@master] Correctly handle tag and class names with special characters

https://gerrit.wikimedia.org/r/1006092

matmarex closed this task as Resolved.Mar 11 2024, 6:53 PM
matmarex removed a project: Patch-For-Review.
gerritbot added a comment.Mar 11 2024, 7:08 PM

Change 1010291 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Update wikimedia/zest-css to 3.0.1

https://gerrit.wikimedia.org/r/1010291

gerritbot added a project: Patch-For-Review.Mar 11 2024, 7:09 PM
gerritbot added a comment.Mar 11 2024, 7:11 PM

Change 1010292 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] Bump wikimedia/zest-css dependency to 3.0.1

https://gerrit.wikimedia.org/r/1010292

gerritbot added a comment.Mar 16 2024, 2:02 PM

Change 1010291 merged by jenkins-bot:

[mediawiki/vendor@master] Update wikimedia/zest-css to 3.0.1

https://gerrit.wikimedia.org/r/1010291

gerritbot added a comment.Mar 16 2024, 2:02 PM

Change 1010292 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Bump wikimedia/zest-css dependency to 3.0.1

https://gerrit.wikimedia.org/r/1010292

gerritbot added a comment.Mar 16 2024, 4:24 PM

Change 1011398 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.19.0-a23

https://gerrit.wikimedia.org/r/1011398

gerritbot added a comment.Mar 16 2024, 7:13 PM

Change 1011398 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.19.0-a23

https://gerrit.wikimedia.org/r/1011398

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.23; 2024-03-19).Mar 16 2024, 10:00 PM
gerritbot added a comment.Wed, Apr 17, 3:22 PM

Change #1004291 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Remove workaround for T357812

https://gerrit.wikimedia.org/r/1004291

Maintenance_bot removed a project: Patch-For-Review.Wed, Apr 17, 3:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL