Page MenuHomePhabricator

Dialog: fix the text size in the dialog's title on Desktop
Open, Stalled, Needs TriagePublicBUG REPORT

Description

Background

The title in the Codex Dialog was implemented incorrectly on desktop, displaying @font-size-large (18px) instead of the intended @font-size-medium (16px) designed for desktop. This has resulted in a misalignment between the Codex demo and the Figma design. Moreover, the base font size of 14px on Desktop is 4px smaller than the title font size, which is causing the title to appear larger than it should.

This is affecting the Wikifunctions project where this Dialog is being used.

Captura de pantalla 2024-02-20 a las 11.46.37.png (538×910 px, 55 KB)

These are the right font tokens used:

Desktop:

  • Title: @font-size-medium (16px) @line-height-xxx-small @font-weight-bold
  • Body: @font-size-small (14px) @line-height-medium @font-weight-normal
  • Subtitle and Footer texts: @font-size-small (14px) @line-height-small @font-weight-normal

Mobile:

  • Title: @font-size-large (18px) @line-height-xxx-small @font-weight-bold
  • Body: @font-size-medium (16px) @line-height-medium @font-weight-normal
  • Subtitle text: @font-size-medium (16px) @line-height-xx-small @font-weight-normal
  • Footer text: @font-size-small (14px) @line-height-small @font-weight-normal

Design spec

Open questions

Add here the questions to be answered in order to design and implement the component

Acceptance criteria (or Done)

Event Timeline

bmartinezcalvo changed the subtype of this task from "Task" to "Bug Report".
CCiufo-WMF triaged this task as Medium priority.Feb 20 2024, 6:43 PM
CCiufo-WMF changed the task status from Open to Stalled.Mar 13 2024, 5:21 PM
CCiufo-WMF moved this task from Up Next to Backlog on the Design-System-Team board.

This is blocked pending next steps from the discussions in T358038.

CCiufo-WMF raised the priority of this task from Medium to Needs Triage.Mar 13 2024, 5:28 PM