Mobile labels are incorrect for font size
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Feb 21 2024, 2:20 AM

Description

Steps to replicate the issue (include links if applicable):

Visit Special:MobileOptions

What happens?:

medium is incorrectly labelled as standard

What should have happened instead?:

small should be labelled standard
the middle option should be labelled "Medium"

New settings logged in.png (1×360 px, 55 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

https://phabricator.wikimedia.org/T358074#9570820

QA Results - Beta

AC	Status	Details
1	✅	T358074#9570820

QA Results - Prod

AC	Status	Details
1	✅	T358074#9570827

Details

	Subject	Repo	Branch	Lines +/-
	Change font-size "Small" label to "Standard"	mediawiki/extensions/MobileFrontend	wmf/1.42.0-wmf.19	+6 -6
	Change font-size "Small" label to "Standard"	mediawiki/extensions/MobileFrontend	master	+6 -6

Customize query in gerrit

Related Objects

Mentioned In: T357332: Verify 1.42.0-wmf.19 deployment

Event Timeline

Jdlrobson created this task.Feb 21 2024, 2:20 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 21 2024, 2:20 AM

NightWolf1223 subscribed.Feb 21 2024, 2:28 AM

CX_Zoom subscribed.Feb 21 2024, 4:30 AM

ovasileva triaged this task as High priority.Feb 21 2024, 7:00 PM

Jdlrobson updated the task description. (Show Details)Feb 22 2024, 5:42 PM

JScherer-WMF updated the task description. (Show Details)Feb 22 2024, 5:44 PM

ovasileva set the point value for this task to 1.Feb 22 2024, 5:44 PM

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (FY2023-24 Q3 Sprint 3) board.

Jan will write the patch and we will backport it today.

Change 1005812 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/extensions/MobileFrontend@master] Change font-size "Small" label to "Standard"

https://gerrit.wikimedia.org/r/1005812

gerritbot added a project: Patch-For-Review.Feb 22 2024, 6:10 PM

Jdlrobson claimed this task.Feb 22 2024, 6:14 PM

Jdlrobson moved this task from Ready for Development to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 3) board.

Jdlrobson added a subscriber: Jdrewniak.

Change 1005695 had a related patch set uploaded (by Jdlrobson; author: Jdrewniak):

[mediawiki/extensions/MobileFrontend@wmf/1.42.0-wmf.19] Change font-size "Small" label to "Standard"

https://gerrit.wikimedia.org/r/1005695

Jdrewniak reassigned this task from Jdlrobson to Edtadros.Feb 22 2024, 7:16 PM

Jdrewniak moved this task from Code Review to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 3) board.

Change 1005812 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Change font-size "Small" label to "Standard"

https://gerrit.wikimedia.org/r/1005812

Change 1005695 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@wmf/1.42.0-wmf.19] Change font-size "Small" label to "Standard"

https://gerrit.wikimedia.org/r/1005695

Mentioned in SAL (#wikimedia-operations) [2024-02-22T21:21:38Z] <cjming@deploy2002> Started scap: Backport for [[gerrit:1005695|Change font-size "Small" label to "Standard" (T358074)]]

Maintenance_bot removed a project: Patch-For-Review.Feb 22 2024, 9:30 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-22T21:35:54Z] <cjming@deploy2002> cjming and jdlrobson: Backport for [[gerrit:1005695|Change font-size "Small" label to "Standard" (T358074)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-02-22T21:50:46Z] <cjming@deploy2002> Finished scap: Backport for [[gerrit:1005695|Change font-size "Small" label to "Standard" (T358074)]] (duration: 29m 07s)

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.19; 2024-02-20).Feb 23 2024, 1:00 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit Special:MobileOptions
medium is incorrectly labelled as standard
✅ AC1: small should be labelled "Standard"
see below
✅ AC2: the middle option should be labelled "Medium"
see below

Edtadros updated the task description. (Show Details)Feb 23 2024, 1:20 AM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit Special:MobileOptions
medium is incorrectly labelled as standard
✅ AC1: small should be labelled "Standard"
see below
✅ AC2: the middle option should be labelled "Medium"
see below

Edtadros updated the task description. (Show Details)Feb 23 2024, 1:38 AM

Everything is as intended

Edtadros mentioned this in T357332: Verify 1.42.0-wmf.19 deployment.Feb 24 2024, 12:33 AM

	F42046174: Screenshot 2024-02-22 at 9.41.51 AM.png
	Feb 22 2024, 5:42 PM

	F42053136: screenshot 559.png
	Feb 23 2024, 1:35 AM

	F42050421: screenshot 556.png
	Feb 23 2024, 1:18 AM

Mobile labels are incorrect for font sizeClosed, ResolvedPublic1 Estimated Story PointsBUG REPORTActions

Description

QA Results - Beta

QA Results - Prod

Details

Related Objects

Event Timeline

Test Result - Beta

QA Steps

Test Result - Prod

QA Steps

Mobile labels are incorrect for font size
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions