Update ApiFeedRecentChanges for temporary accounts
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Feb 22 2024, 4:54 PM

Description

ApiFeedRecentChanges was mostly updated for temporary accounts by T343322: IP Masking: Update Recent changes filters user registration filters for IP Masking (based on local testing). However, the API help description needs updating in a similar way as done in 1941f28f609e88da1677f0beb99468bb77748040 so that the hideanons flag can be indicated as applying to temporary accounts if temporary accounts are enabled.

Acceptance criteria

Have the hideanons parameter help text for the ApiFeedRecentChanges API updated so that it indicates setting this to true will hide temporary accounts. This should only be using the updated text if temporary accounts are enabled.

QA Results - Local

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T358249 here
2	✅	https://phabricator.wikimedia.org/T358249

Details

	Subject	Repo	Branch	Lines +/-
	Update help text for 'hideanons' in ApiFeedRecentChanges API	mediawiki/core	master	+65 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
		Restricted Task
Resolved	kostajh	T294511 2021 Security Team wikireplicas audit
Declined	None	T284948 Raw IPs of logged-out users disclosed in wiki-replicas
In Progress	Niharika	T324492 Temporary accounts - MVP
Open	None	T326816 Update features for temporary accounts
Open	None	T331637 Update features in MediaWiki core for IP Masking
Resolved	Dreamy_Jazz	T341228 Update action API to handle temporary users
Resolved	Dreamy_Jazz	T358249 Update ApiFeedRecentChanges for temporary accounts

Event Timeline

Dreamy_Jazz created this task.Feb 22 2024, 4:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 22 2024, 4:54 PM

Dreamy_Jazz mentioned this in T341228: Update action API to handle temporary users.Feb 22 2024, 4:58 PM

Change 1005803 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Update help text for 'hideanons' in ApiFeedRecentChanges API

https://gerrit.wikimedia.org/r/1005803

gerritbot added a project: Patch-For-Review.Feb 22 2024, 5:14 PM

Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.Feb 22 2024, 5:16 PM

Dreamy_Jazz set the point value for this task to 1.

Change 1005803 merged by jenkins-bot:

[mediawiki/core@master] Update help text for 'hideanons' in ApiFeedRecentChanges API

https://gerrit.wikimedia.org/r/1005803

Maintenance_bot removed a project: Patch-For-Review.Feb 22 2024, 7:30 PM

Suggested QA steps:

Enable temporary accounts on your wiki
Load Special:ApiSandbox
Select the feedrecentchanges API and scrol down to the hideanons setting
Verify that the setting looks like the following:

Turn off temporary accounts on your wiki
Repeat steps 2 and 3
Verify that the setting looks like the following:

@Dreamy_Jazz hideanons parameter help text for the ApiFeedRecentChanges text if temporary accounts are enabled are now updated to display "Hide changes made by anonymous users and temporary accounts." as seen in the .webm below. Temp accounts that are off display "Hide changes made by anonymous users". This will be moved to Done. Thanks for all your work and steps!

Status: ✅PASS
Environment: Beta: 1.42.0-alpha (d5ff499)
OS: macOS Sonoma 14.2.1
Browser: Chrome 121
Skins. Vector 2022
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en.m.wikipedia.beta.wmflabs.org/wiki/Cat#

Core: commit 19f444618d2b4b7053a1ca30921534e938a6d3ec Thu Feb 22 19:51:13 2024

✅AC1: https://phabricator.wikimedia.org/T358249- **TempAccount On**

✅AC2: https://phabricator.wikimedia.org/T358249- **TempAccount Off**

GMikesell-WMF updated the task description. (Show Details)Feb 23 2024, 12:09 AM

GMikesell-WMF moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.20; 2024-02-27).Feb 23 2024, 1:00 AM

Thanks for the QA. Marking this as resolved.

	F42050644: T358249_TempOff_APISandbox.webm
	Feb 23 2024, 12:08 AM

	F42050640: T358249_TempOn_APISandbox.webm
	Feb 23 2024, 12:08 AM

	F42048018: image.png
	Feb 22 2024, 7:47 PM

	F42048036: image.png
	Feb 22 2024, 7:47 PM

Update ApiFeedRecentChanges for temporary accountsClosed, ResolvedPublic1 Estimated Story PointsActions