Page MenuHomePhabricator

Search panel should use the same direction as the interface
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
MusikAnimal
Mar 8 2024, 4:16 AM
Referenced Files
F45732352: T359611_CM6_EnRTL.webm
Apr 10 2024, 10:17 PM
F45731560: 2024-04-10_15-02-59.png
Apr 10 2024, 10:17 PM
F45731529: 2024-04-10_15-01-28.png
Apr 10 2024, 10:17 PM
F45731888: 2024-04-10_14-56-51.png
Apr 10 2024, 10:17 PM
F45731399: 2024-04-10_14-56-51.png
Apr 10 2024, 10:17 PM
F45731362: 2024-04-10_14-55-46.png
Apr 10 2024, 10:17 PM
F45731337: 2024-04-10_14-54-23.png
Apr 10 2024, 10:17 PM
F45732824: T359611_CM6_En_Search.webm
Apr 10 2024, 10:17 PM

Description

This is a follow-up to T359589: CodeMirror 6: Cursor is offset when viewing a mix of LTR/RTL interfaces and page langauge

Steps to replicate the issue (include links if applicable):

What happens?:

The search panel is shown in left-to-right, matching the page language (en).

What should have happened instead?:

The direction should be shown right-to-left, matching the interface language (en-rtl)

QA Results - Beta

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald Transcript
MusikAnimal renamed this task from Search panel should use the same direction and language as the interface to Search panel should use the same direction as the interface.Mar 25 2024, 11:58 PM
MusikAnimal claimed this task.
MusikAnimal updated the task description. (Show Details)

Change #1014138 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] CM6: ensure search panel is in the same direction as the interface lang

https://gerrit.wikimedia.org/r/1014138

Change #1014138 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] CM6: ensure search panel is in the same direction as the interface lang

https://gerrit.wikimedia.org/r/1014138

@MusikAnimal Everything seems to be fine except for the Timeless Skin as seen in the video below. It still reads as LTR besides RTL.

Status: โŒ Fail
Environment: Beta: 1.43.0-alpha (d8e8369)
OS: macOS Sonoma 14.4.1
Browser: Chrome 123, Firefox 123, Safari 17.3
Skins. Vector 2022, Vector 2010, Minerva, Monobook, Timeless
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en.wikipedia.beta.wmflabs.org/wiki/Dog?action=edit&uselang=en-rtl

โœ…AC1: https://phabricator.wikimedia.org/T359611

EN-RTL SearchEn Search

SKINS

Vector 2010MinervaMonobook
2024-04-10_14-54-23.png (1ร—3 px, 920 KB)
2024-04-10_14-55-46.png (1ร—3 px, 565 KB)
2024-04-10_14-56-51.png (1ร—3 px, 857 KB)

Browers

ChromeFirefoxSafari
2024-04-10_14-56-51.png (1ร—3 px, 857 KB)
2024-04-10_15-01-28.png (1ร—1 px, 555 KB)
2024-04-10_15-02-59.png (1ร—2 px, 650 KB)

โŒIssue
The search panel is shown in left-to-right, matching the page language (en)besides en-rtl

Timeless Skin

@MusikAnimal Everything seems to be fine except for the Timeless Skin as seen in the video below. It still reads as LTR besides RTL.

โ€ฆ

โŒIssue
The search panel is shown in left-to-right, matching the page language (en)besides en-rtl

Thanks for checking! This looks like an issue with Timeless itself, per https://gerrit.wikimedia.org/g/mediawiki/skins/Timeless/+/6dc3d2c902a6840b2a616e1b538951979666a175/resources/libraries/shared.css#24

It's going by the site language rather than the user's language. From reading the relevant commit, it looks like the developer copied styles from MediaWiki Core. Those styles have presumably since been fixed, but have not been copied or whatever over to Timeless. T280747 was linked to as the task. I can comment there with my findings.

I think this issue can be ignored for our purposes, as it likely exists elsewhere on the wikis.

I've left a note at T280747#9705647. Moving back to QA in case there's anything else. I don't think it's worth the effort to investigate a fix for Timeless for something this minor, but if anyone disagrees, let me know :)

@MusikAnimal With the minor issue being noted on T280747#9705647 and no other issues coming across as mentioned above, I will move this to Done. Thanks for all your work!

Status: โœ…PASS
Environment: Beta: 1.43.0-alpha (e77edc8)
OS: macOS Sonoma 14.4.1
Browser: Chrome 123, Firefox 123, Safari 17.3
Skins. Vector 2022, Vector 2010, Minerva, Monobook, Timeless
Device: MBA M2
Emulated Device:: n/a
Other Tested Beta Wikis: Wikiquote, Wikisource, Meta, Wikibook, Wikinews, Wiktionary
Test Links:**
https://en.wikipedia.beta.wmflabs.org/wiki/Dog?action=edit&uselang=en-rtl