Using RequestContext::getMain in service wiring code should be avoided as documented on the core ServiceWiring.php and discussed in the declined T218555. In favour of T330109.
The service wiring in Vector skin is using the web request and the user to instance the FeatureManager.
It would be better to have a factory to get called from the skin with the RequestContext and creating the manager from that information.
This would avoid the technical debt with the request.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Create a FeatureManagerFactory | mediawiki/skins/Vector | master | +400 -331 |
Change 990131 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/skins/Vector@master] Create a FeatureManagerFactory
Change 990131 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Create a FeatureManagerFactory
No QA needed, this change can be checked by pixel as it is stability and refactoring, expectation is no apparent change. Local Pixel passes for me.