Page MenuHomePhabricator
Create Task
Maniphest T360577

Split experimental tokens output into separate CSS and Less files
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Currently, the theme-wikimedia-ui-experimental.less generated by the tokens package contains two things:

  • A :root block with CSS variable definitions for a subset of tokens, e.g. --color-base: #202122;
  • A list of Less variable definitions for all tokens, some expressed as CSS vars (e.g. @color-base: var( --color-base );) and some as hard-coded values (e.g. @opacity-medium: 0.65;)

As requested in T358059#9620816, these two things should be output in separate files.

Details

SubjectRepoBranchLines +/-
Update imports for experimental file split in Codexmediawiki/skins/MinervaNeuemaster+9 -7
Update Codex from v1.3.5 to v1.3.6mediawiki/coremaster+1 K -276
[WIP] Codex: Split experimental filesmediawiki/coremaster+377 -794
tokens: Add a new format for experimental CSS outputdesign/codexmain+82 -30
tokens: Split experimental build and change how it's produceddesign/codexmain+94 -70
Customize query in gerrit

Related Objects
Search...

Event Timeline

Catrope triaged this task as High priority.Mar 20 2024, 9:45 PM
Catrope created this task.
Restricted Application edited projects, added Design-System-Team; removed Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)). · View Herald TranscriptMar 20 2024, 9:45 PM
Catrope claimed this task.Mar 20 2024, 9:45 PM
Catrope mentioned this in T358059: Use Codex experimental build in Minerva to allow codex components to appear in night mode.
Catrope edited projects, added Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)); removed Design-System-Team.
Catrope moved this task from Committed to In Progress on the Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)) board.
Catrope changed the subtype of this task from "Spike" to "Task".
gerritbot added a comment.Mar 20 2024, 11:57 PM

Change 1013153 had a related patch set uploaded (by Catrope; author: Catrope):

[design/codex@main] tokens: Split experimental build and change how it's produced

https://gerrit.wikimedia.org/r/1013153

gerritbot added a project: Patch-For-Review.Mar 20 2024, 11:57 PM
Catrope changed the point value for this task from 1 to 2.Mar 20 2024, 11:57 PM
Catrope moved this task from In Progress to Code Review on the Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)) board.Mar 21 2024, 12:15 AM
gerritbot added a comment.Mar 21 2024, 5:06 PM

Change #1013344 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[design/codex@main] tokens: Add a new format for experimental CSS output

https://gerrit.wikimedia.org/r/1013344

gerritbot added a comment.Mar 21 2024, 11:37 PM

Change #1013153 abandoned by Catrope:

[design/codex@main] tokens: Split experimental build and change how it's produced

Reason:

Superseded for now by https://gerrit.wikimedia.org/r/c/design/codex/+/1013344 ; but we may want to pick out pieces of this change later

https://gerrit.wikimedia.org/r/1013153

gerritbot added a comment.Mar 26 2024, 9:29 PM

Change #1013344 merged by jenkins-bot:

[design/codex@main] tokens: Add a new format for experimental CSS output

https://gerrit.wikimedia.org/r/1013344

gerritbot added a comment.Mar 26 2024, 9:45 PM

Change #1014618 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] [WIP] Codex: Split experimental files

https://gerrit.wikimedia.org/r/1014618

gerritbot added a comment.Mar 26 2024, 9:45 PM

Change #1014619 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/skins/MinervaNeue@master] [WIP] Update imports for experimental file split in Codex

https://gerrit.wikimedia.org/r/1014619

Catrope moved this task from Code Review to Pending Release on the Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)) board.Mar 26 2024, 9:50 PM
gerritbot added a comment.Tue, Apr 2, 10:14 PM

Change #1016452 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from v1.3.5 to v1.3.6

https://gerrit.wikimedia.org/r/1016452

gerritbot added a comment.Tue, Apr 2, 10:18 PM

Change #1014618 abandoned by Catrope:

[mediawiki/core@master] [WIP] Codex: Split experimental files

Reason:

https://gerrit.wikimedia.org/r/1014618

gerritbot added a comment.Wed, Apr 3, 3:23 AM

Change #1016452 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.3.5 to v1.3.6

https://gerrit.wikimedia.org/r/1016452

gerritbot added a comment.Wed, Apr 3, 4:29 AM

Change #1014619 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Update imports for experimental file split in Codex

https://gerrit.wikimedia.org/r/1014619

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.26; 2024-04-09).Wed, Apr 3, 3:02 PM
Volker_E closed this task as Resolved.Thu, Apr 4, 9:16 PM
Volker_E removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL