Page MenuHomePhabricator

Remove angle brackets from apihelp-wikilambda_function_call-example-generic-pair
Closed, ResolvedPublicBUG REPORT

Description

The L10n bot change https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/1012976 had to be manually merged because the message translation includes a string that looks like an XML tag that is unrecognized by Jenkins job configuration:

+ sed -E -e 's/<\/? ?(abbr|b|bdi|big|br|charinsert|code|dd|del|div|dl|dt|em|h1|h2|h3|h4|hr|i|kbd|li|mark|math|NDL|nowiki|ol|p|page|pagelist|pages|pre|ref|samp|small|span|strong|sub|sup|syntaxhighlight|templatedata|templatestyles|tt|u|ul|user|var)( ((alttext|class|dir|display|id|lang|title|xml:lang|xmlns)=\\?["'\''][^=<>"'\'']*\\?["'\'']))* ?\/?>//g' -e 's/<!--//g' -e 's/<https?:\/\/[a-zA-Z0-9./-]*>//g'
+ grep '<'
+	"apihelp-wikilambda_function_call-example-generic-pair": "קריאה לפונקציה שמחזירה את האיבר השני של מבנה Pair<String,Pair<String,Bool>>",
+ echo 'HTML detected. Manual review required'
HTML detected. Manual review required
+ exit 1

The string in question is Pair<String,Pair<String,Bool>>. The easy fix is to change < into &lt;.

(It would also be nice to change "Pair" and "Bool" to their wikifunctions.org names—"Typed pair" and "Boolean".)

Event Timeline

Change 1013154 had a related patch set uploaded (by Jforrester; author: Amire80):

[mediawiki/extensions/WikiLambda@master] i18n: Improve apihelp-wikilambda_function_call-example-generic-pair

https://gerrit.wikimedia.org/r/1013154

Jdforrester-WMF changed the task status from Open to In Progress.Mar 21 2024, 11:38 AM
Jdforrester-WMF reassigned this task from Amire80 to Aaharoni-WMF.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from To triage to To deploy on the Abstract Wikipedia team board.

Change 1013154 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] i18n: Improve apihelp-wikilambda_function_call-example-generic-pair

https://gerrit.wikimedia.org/r/1013154

MaryMunyoki reassigned this task from Aaharoni-WMF to Amire80.
MaryMunyoki added a subscriber: Aaharoni-WMF.