| matmarex | |
| Mar 28 2024, 4:19 PM |
| F43677180: image.png | |
| Mar 28 2024, 4:19 PM |
| F43677172: image.png | |
| Mar 28 2024, 4:19 PM |
Unexpected section edit links appear on some pages with Parsoid, for example compare:
(There's also a difference in rendering with the heading underline, since the TemplateStyles designed for old parser output don't apply, that will probably need to be fixed on-wiki.)
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Bump wikimedia/parsoid to 0.19.0-a25 | mediawiki/vendor | master | +18 K -8 K | |
| Literal html headings don't get section edit links | mediawiki/services/parsoid | master | +34 -6 |
Change #1015436 had a related patch set uploaded (by Arlolra; author: Arlolra):
[mediawiki/services/parsoid@master] Literal html headings are never editable
Change #1015436 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Literal html headings don't get section edit links
Change #1017782 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.19.0-a25
Change #1017782 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.19.0-a25
Post deploy and purge, seems resolved.
(There's also a difference in rendering with the heading underline, since the TemplateStyles designed for old parser output don't apply, that will probably need to be fixed on-wiki.)
I'm not sure if anything was done on-wiki but the underline is no longer there. Could have been due to the wrong class being added before.
Ah yes, previously the page had <div class="mw-heading"> wrappers on those headings, but they are not supposed to be there for tags written as <h2> in the wikitext (per T353489), and this has also been fixed by your change.