Page MenuHomePhabricator

Page state routing triggers DiscussionTools warning, e.g. #!/deploycal/current
Closed, ResolvedPublic

Description

The #!/ prefix is an old convention that reserves this prefix for dynamic state within web apps and gadgets. It is, for example, used at https://wikitech.wikimedia.org/wiki/Deployments#!/deploycal/current. This currently triggers the "This topic could not be found. It might have been deleted or moved." warning every time.

We could easily move away form this prefix, but that wouldn't help in this case since DT would still emit the same warning. In this case, I think this prefix might actually offer a way to handle this in a more scalable way that doesn't require DT to hardcode every gadget's dynamic hash in existence. While not impossible, this prefix might be acceptable to opt-out more generally from DT reporting its failed attempt to search the archive as an error.

I see that DT already ignores #/ for the same purpose. I suggest excluding #!/ as well.

Context:

Related:

Event Timeline

Krinkle renamed this task from Page state routing triggers DiscussionTools warning, e.g. #!/deploycal/test to Page state routing triggers DiscussionTools warning, e.g. #!/deploycal/current.Mar 28 2024, 11:21 PM

Change #1015426 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/DiscussionTools@master] Also don't check for moved topics on fragments starting with `!/`

https://gerrit.wikimedia.org/r/1015426

We could easily move away form this prefix, but that wouldn't help in this case since DT would still emit the same warning. In this case, I think this prefix might actually offer a way to handle this in a more scalable way that doesn't require DT to hardcode every gadget's dynamic hash in existence. While not impossible, this prefix might be acceptable to opt-out more generally from DT reporting its failed attempt to search the archive as an error.

See also T349498. Having one prefix for all applications would help, but whether it's !/ or / probably doesn't make much difference as those are both valid content IDs if you have a heading starting == /foo == or == !/foo ==.

Change #1015426 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Also don't check for moved topics on fragments starting with `!/`

https://gerrit.wikimedia.org/r/1015426