Page MenuHomePhabricator

docs: amend form guidelines for complex combinations
Closed, ResolvedPublic

Description

Background

CodexHTMLForm used by Multiblocks have already let some more complex combinations of form components surface.
We should be explicit in the constructing forms guidelines.

Questions

image.png (1×1 px, 91 KB)

  • The buttons should feature more spacing in-between. I'd opt for spacing-75 equal to connected Radios. This will decrease false clicking and also follow a similar rule – elements that are connected with each other or in a group should get spacing-75 while unconnected elements get spacing-100
  • Adding a note about connected fields featuring a specific (as above, my recommendation were spacing-75) spacing

See for example, only here to be concerned about spacings

image.png (618×1 px, 84 KB)

  • (Minor) the 16px spacing between Amount and Time input is wrongly offset

Acceptance criteria

  • Buttons side-by-side, with exception toolbar tools, feature spacing-75
    • Images are also all updated
    • Dialog buttons are updated
  • Images are fixed in regards to spacing indicators

Event Timeline

A decision here might also affect Dialog button spacing.

Another example to be amended:

image.png (142×912 px, 13 KB)

@Volker_E Where is that example from you shared above?

Change #1017315 had a related patch set uploaded (by Catrope; author: Dtorsani):

[design/codex@main] docs: Adjust spacing guidance between buttons from 8 to 12px

https://gerrit.wikimedia.org/r/1017315

Change #1017315 had a related patch set uploaded (by VolkerE; author: Dtorsani):

[design/codex@main] docs: Adjust spacing guidance between buttons from 8 to 12px

https://gerrit.wikimedia.org/r/1017315

Change #1017315 merged by jenkins-bot:

[design/codex@main] docs, Dialog: Adjust spacing and guidance between buttons from 8 to 12px

https://gerrit.wikimedia.org/r/1017315

It's from the FlaggedRevision extension.

@Volker_E Where is that example from you shared above?

Change #1020918 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/core@master] Update Codex from 1.3.6 to 1.4.0

https://gerrit.wikimedia.org/r/1020918

Change #1020918 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from 1.3.6 to 1.4.0

https://gerrit.wikimedia.org/r/1020918