Page MenuHomePhabricator

[SW] [REPO][CLIENT] Use ObjectCacheFactory in Wikibase
Closed, ResolvedPublic

Description

T358346 introduces the ObjectCacheFactory service to MediaWiki core, replacing several static ObjectCache methods that are now deprecated; we should migrate to that service.

While we’re at it, I think we can also resolve three or four cache-related subtasks of T277464: [EPIC] Multiple Wikibase service wiring tests fail when run as unit tests: T281706, T281708, and T281710 (all using getLocalServerInstance()), as well as T281709 (using ObjectCache::getInstance( $cacheType )).

Event Timeline

Lucas_Werkmeister_WMDE renamed this task from Use ObjectCacheFactory in Wikibase to [SW] [REPO][CLIENT] Use ObjectCacheFactory in Wikibase.Apr 11 2024, 12:07 PM

Change #1029110 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/Wikibase@master] Fix: Use objectCacheFactory instead of deprecate objectCache method

https://gerrit.wikimedia.org/r/1029110

Change #1029110 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use ObjectCacheFactory instead of deprecated ObjectCache methods

https://gerrit.wikimedia.org/r/1029110

While we’re at it, I think we can also resolve three or four cache-related subtasks of T277464: [EPIC] Multiple Wikibase service wiring tests fail when run as unit tests: T281706, T281708, and T281710 (all using getLocalServerInstance()), as well as T281709 (using ObjectCache::getInstance( $cacheType )).

The last one resolved itself already; I just uploaded changes to fix the other three (they were simple to fix now).

Change #1036616 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Migrate remaining ObjectCache uses to ObjectCacheFactory

https://gerrit.wikimedia.org/r/1036616

Change #1036616 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Migrate remaining ObjectCache uses to ObjectCacheFactory

https://gerrit.wikimedia.org/r/1036616