⚓ T281706 Make ViewFactoryTest a proper unit test

	Subject	Repo	Branch	Lines +/-
	Use ObjectCacheFactory in ViewFactory service wiring	mediawiki/extensions/Wikibase	master	+10 -1

Status	Assigned	Task
Invalid	None	T108946 [Epic] Improve the development infrastructure
Open	None	T84948 MediaWiki core unit tests should be true unit tests (tracking)
Open	None	T96458 Separate Wikibase unit tests from integration tests
Resolved	kostajh	T266441 MediaWikiUnitTestCase should prevent access to MediaWikiServices
Stalled	None	T277464 [EPIC] Multiple Wikibase service wiring tests fail when run as unit tests
Open	Collins	T363770 Replace deprecated ObjectCache factory methods in Wikimedia deployed code
Resolved	ItamarWMDE	T361949 [SW] [REPO][CLIENT] Use ObjectCacheFactory in Wikibase
Resolved	Lucas_Werkmeister_WMDE	T281706 Make ViewFactoryTest a proper unit test

Lucas_Werkmeister_WMDE created this task.May 3 2021, 1:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 3 2021, 1:03 PM

Lucas_Werkmeister_WMDE mentioned this in T281709: Make PropertyLabelResolverTest a proper unit test.May 3 2021, 1:16 PM

Lucas_Werkmeister_WMDE mentioned this in T277464: [EPIC] Multiple Wikibase service wiring tests fail when run as unit tests.May 3 2021, 1:18 PM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)May 3 2021, 3:35 PM

Lucas_Werkmeister_WMDE mentioned this in T281710: Make PropertyOrderProviderTest a proper unit test.May 3 2021, 3:45 PM

Lucas_Werkmeister_WMDE mentioned this in T281708: Make OtherProjectsSitesProviderTest a proper unit test.

Lucas_Werkmeister_WMDE updated the task description. (Show Details)

Addshore added a project: [DEPRECATED] wdwb-tech.Sep 21 2021, 10:49 AM

Addshore moved this task from Inbox to Subtasks on the [DEPRECATED] wdwb-tech board.

Lucas_Werkmeister_WMDE mentioned this in T291706: Make WikibaseRepo.BagOStuffSiteLinkConflictLookup a proper unit test.Sep 24 2021, 4:58 PM

A solution for this almost certainly requires T243233: MediaWiki should provide a LocalClusterObjectCache service.

That task was declined, but in the meantime, the local cluster instance was added to the service container anyway… as a “private” service, with an underscore prefix -.-

ObjectCache.php

public static function getLocalClusterInstance() {
	return MediaWikiServices::getInstance()->get( '_LocalClusterCache' );
}

ServiceWiring.php

'_LocalClusterCache' => static function ( MediaWikiServices $services ): BagOStuff {
	$mainConfig = $services->getMainConfig();
	$id = $mainConfig->get( MainConfigNames::MainCacheType );
	return $services->getObjectCacheFactory()->getInstance( $id );
},

But I still think we can implement this (along with T281708 and T281710). We can either get the _LocalClusterCache service, and just ignore that it’s not public / stable, or we can just copy+paste its three lines of service wiring and get the right cache depending on the main cache type from the ObjectCacheFactory (T358346) ourselves. (And in either case, we could also wrap this in a Wikibase service.)