Page MenuHomePhabricator
Create Task
Maniphest T363770

Replace deprecated ObjectCache factory methods in Wikimedia deployed code
Open, Needs TriagePublic
Actions

Description

Replace the static factory methods deprecated in T358346: Introduce ObjectCacheFactory to MediaWiki core with proper dependency injection:

  • ObjectCache::getInstance()
  • ObjectCache::newFromParams()
  • ObjectCache::newAnything()
  • ObjectCache::getLocalServerInstance()

(Not sure what's the deal with ObjectCache::getLocalClusterInstance(), which wasn't deprecated.)

A search indicates several repos need an update:

  • MediaWiki core
  • mediawiki/extensions/Translate
  • mediawiki/extensions/Wikibase (T361949)
  • mediawiki/extensions/CentralAuth
  • mediawiki/extensions/Echo
  • mediawiki/extensions/EventLogging
  • mediawiki/extensions/ExtensionDistributor
  • mediawiki/extensions/JsonConfig
  • mediawiki/extensions/Scribunto
  • mediawiki/extensions/SpamBlacklist
  • mediawiki/extensions/TitleBlacklist
  • mediawiki/extensions/TranslationNotifications
  • mediawiki/extensions/WikibaseQualityConstraints

Details

SubjectRepoBranchLines +/-
objectcache: Complete refactor of `ObjectCache.php`mediawiki/coremaster+183 -157
Fix:Use objectCacheFactory instead of the deprecated objectCache method.mediawiki/extensions/Gadgetsmaster+7 -4
Fix: Use ObjectCacheFactory methods instead of deprecated ObjectCache methodsmediawiki/extensions/TitleBlacklistmaster+2 -2
Fix: Use ObjectCacheFactory methods instead of deprecated ObjectCache methodsmediawiki/extensions/WikibaseQualityConstraintsmaster+1 -2
Fix: Use ObjectCacheFactory methods instead of deprecated ObjectCache methodsmediawiki/extensions/EventLoggingmaster+2 -2
Fix: Use ObjectCacheFactory instead of deprecated ObjectCache methodsmediawiki/extensions/JsonConfigmaster+2 -3
Fix: Use ObjectCacheFactory instead of deprecated ObjectCache Methodsmediawiki/extensions/OATHAuthmaster+3 -3
Fix: Use objectCacheFactory instead of deprecate objectCache methodmediawiki/extensions/Wikibasemaster+21 -11
Use ObjectCacheFactory instead of deprecated ObjectCache methodmediawiki/extensions/CentralAuthmaster+2 -2
Fix: Use objectCacheFactory instead of deprecated objectCache methodmediawiki/extensions/Translatemaster+13 -15
Use ObjectCacheFactory instead of deprecated ObjectCache methodmediawiki/extensions/Scribuntomaster+9 -6
Use ObjectCacheFactory instead of deprecated ObjectCache methodmediawiki/extensions/OAuthmaster+4 -3
Use ObjectCacheFactory instead of deprecated ObjectCache methodmediawiki/extensions/TranslationNotificationsmaster+2 -3
Use ObjectCacheFactory instead of deprecated ObjectCache methodmediawiki/extensions/Echomaster+3 -3
Use ObjectCacheFactory instead of deprecated ObjectCache methodmediawiki/extensions/ExtensionDistributormaster+5 -3
fix: use objectcachefactory methods instead of deprecated objectcache methodsmediawiki/coremaster+57 -49
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Tgr created this task.Mon, Apr 29, 10:25 PM
Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptMon, Apr 29, 10:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DAlangi_WMF subscribed.Tue, Apr 30, 9:06 AM

Not sure what's the deal with ObjectCache::getLocalClusterInstance(), which wasn't deprecated.

@Tgr, there are a few other methods in ObjectCache that I'll like to port (including what you mentioned) into ObjectCacheFactory and deprecate them in ObjectCache. But the main ones are done already and the rest are not too hard to achieve. The reason it wasn't deprecated at the time the patch was made was because the change was becoming relatively too large which would have made it slightly harder to attract reviewers or to fit in my brain at once :)

But for now, folks can begin migrating to the new methods, that's fine.

I'll see if I can get a patch up before the week runs out, should be like an hour or two worth of work :)

Collins claimed this task.Sun, May 5, 12:57 AM
gerritbot added a comment.Sun, May 5, 8:35 AM

Change #1027526 had a related patch set uploaded (by Slri; author: Slri):

[mediawiki/core@master] fix: use objectcachefactory methods instead of deprecated objectcache methods

https://gerrit.wikimedia.org/r/1027526

gerritbot added a project: Patch-For-Review.Sun, May 5, 8:35 AM
Jdforrester-WMF updated the task description. (Show Details)Sun, May 5, 10:11 AM
gerritbot added a comment.Sun, May 5, 11:08 AM

Change #1027526 merged by jenkins-bot:

[mediawiki/core@master] fix: use objectcachefactory methods instead of deprecated objectcache methods

https://gerrit.wikimedia.org/r/1027526

Maintenance_bot removed a project: Patch-For-Review.Sun, May 5, 11:30 AM
Collins updated the task description. (Show Details)Sun, May 5, 11:37 AM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.4; 2024-05-07).Sun, May 5, 12:00 PM
gerritbot added a comment.Wed, May 8, 7:53 AM

Change #1029110 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/Wikibase@master] Fix: Use objectCacheFactory instead of deprecate objectCache method

https://gerrit.wikimedia.org/r/1029110

gerritbot added a project: Patch-For-Review.Wed, May 8, 7:53 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Wed, May 8, 8:03 AM
Lucas_Werkmeister_WMDE added a subtask: T361949: [SW] [REPO][CLIENT] Use ObjectCacheFactory in Wikibase.
gerritbot added a comment.Wed, May 8, 8:07 AM

Change #1029116 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/Translate@master] Fix: Use objectCacheFactory instead of deprecated objectCache method

https://gerrit.wikimedia.org/r/1029116

gerritbot added a comment.Wed, May 8, 9:04 AM

Change #1029132 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/CentralAuth@master] Fix: Use objectCacheFactory instead of deprecated objectcache method

https://gerrit.wikimedia.org/r/1029132

gerritbot added a comment.Wed, May 8, 10:20 AM

Change #1029149 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/TranslationNotifications@master] Fix: Use objectCacheFactory instead of deprecated objectCache

https://gerrit.wikimedia.org/r/1029149

gerritbot added a comment.Wed, May 8, 11:29 PM

Change #1029299 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/Scribunto@master] Fix: Use objectCacheFactory instead of deprecated objectCahce method

https://gerrit.wikimedia.org/r/1029299

gerritbot added a comment.Mon, May 13, 11:17 AM

Change #1030914 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] objectcache: Complete refactor of `ObjectCache.php`

https://gerrit.wikimedia.org/r/1030914

DAlangi_WMF added a comment.Mon, May 13, 11:45 AM

(Not sure what's the deal with ObjectCache::getLocalClusterInstance(), which wasn't deprecated.)

@Tgr, here is the patch: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1030914 that completes the refactor and deprecates what you mentioned in the task and others.

gerritbot added a comment.Tue, May 14, 10:18 AM

Change #1031411 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/Echo@master] Fix: use objectCacheFactory instead of deprecated objectCache method

https://gerrit.wikimedia.org/r/1031411

gerritbot added a comment.Tue, May 14, 1:20 PM

Change #1031443 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/ExtensionDistributor@master] Fix: Use objectcachefactory instead of deprecated objectcache

https://gerrit.wikimedia.org/r/1031443

gerritbot added a comment.Tue, May 14, 4:26 PM

Change #1031508 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/OAuth@master] Fix: use objectcachefactory methods instead of deprecated objectcache methods

https://gerrit.wikimedia.org/r/1031508

gerritbot added a comment.Tue, May 14, 4:29 PM

Change #1031509 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/Gadgets@master] Fix:Use objectCacheFactory instead of the deprecated objectCache method.

https://gerrit.wikimedia.org/r/1031509

gerritbot added a comment.Tue, May 14, 7:34 PM

Change #1031443 merged by jenkins-bot:

[mediawiki/extensions/ExtensionDistributor@master] Use ObjectCacheFactory instead of deprecated ObjectCache method

https://gerrit.wikimedia.org/r/1031443

gerritbot added a comment.Tue, May 14, 7:54 PM

Change #1031411 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Use ObjectCacheFactory instead of deprecated ObjectCache method

https://gerrit.wikimedia.org/r/1031411

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.6; 2024-05-21); removed MW-1.43-notes (1.43.0-wmf.4; 2024-05-07).Tue, May 14, 8:00 PM
gerritbot added a comment.Tue, May 14, 8:10 PM

Change #1029149 merged by jenkins-bot:

[mediawiki/extensions/TranslationNotifications@master] Use ObjectCacheFactory instead of deprecated ObjectCache method

https://gerrit.wikimedia.org/r/1029149

gerritbot added a comment.Tue, May 14, 8:10 PM

Change #1031508 merged by jenkins-bot:

[mediawiki/extensions/OAuth@master] Use ObjectCacheFactory instead of deprecated ObjectCache method

https://gerrit.wikimedia.org/r/1031508

gerritbot added a comment.Tue, May 14, 8:32 PM

Change #1029299 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@master] Use ObjectCacheFactory instead of deprecated ObjectCache method

https://gerrit.wikimedia.org/r/1029299

gerritbot added a comment.Wed, May 15, 5:50 PM

Change #1029132 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Use ObjectCacheFactory instead of deprecated ObjectCache method

https://gerrit.wikimedia.org/r/1029132

Krinkle renamed this task from Replace deprecated ObjectCache factory methods in Wikimedia code to Replace deprecated ObjectCache factory methods in Wikimedia deployed code.Mon, May 20, 6:07 PM
Krinkle moved this task from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
Krinkle moved this task from Current Sprint to Inbox, needs triage on the MediaWiki-Platform-Team board.
gerritbot added a comment.Mon, May 20, 10:11 PM

Change #1034186 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/OATHAuth@master] Fix: Use ObjectCacheFactory instead of deprecated ObjectCache Methods

https://gerrit.wikimedia.org/r/1034186

gerritbot added a comment.Mon, May 20, 10:55 PM

Change #1034191 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/JsonConfig@master] Fix: Use ObjectCacheFactory instead of deprecated ObjectCache methods

https://gerrit.wikimedia.org/r/1034191

gerritbot added a comment.Mon, May 20, 11:59 PM

Change #1034198 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/EventLogging@master] Fix: Use ObjectCacheFactory methods instead of deprecated ObjectCache methods

https://gerrit.wikimedia.org/r/1034198

gerritbot added a comment.Tue, May 21, 12:20 AM

Change #1034201 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/WikibaseQualityConstraints@master] Fix: Use ObjectCacheFactory methods instead of deprecated ObjectCache methods

https://gerrit.wikimedia.org/r/1034201

gerritbot added a comment.Tue, May 21, 12:34 AM

Change #1034202 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/TitleBlacklist@master] Fix: Use ObjectCacheFactory methods instead of deprecated ObjectCache methods

https://gerrit.wikimedia.org/r/1034202

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL