Page MenuHomePhabricator

Link, docs: Clarify icon usage within Links
Closed, InvalidPublic1 Estimated Story Points



Currently, as of Codex v1.3.6, we have a misconception in our docs on icon usage within Links.
While the specifications already point out that there is only one specific icon put end of Link description

image.png (640×1 px, 82 KB)

“Link with icon” features
image.png (434×1 px, 48 KB)
as end icon and in normal size, which is against design agreements and common practice.


Clarify Link with Icon usage with correct use cases.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1023808 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] Link: Return to `x-small` rendering for :after icons

Turns out the change to rems was the origin of the wrongly rendered icon.

Volker_E renamed this task from docs: Clarify icon usage within Links to Link, docs: Clarify icon usage within Links.Apr 24 2024, 8:52 AM
Volker_E added a project: Regression.
egardner subscribed.

I'm closing this task as invalid because there are no clear acceptance criteria attached and we (the DST engineers) are somewhat confused about what actually needs to be done at this point.

Please file a new task with clear acceptance criteria about what specific changes are necessary and we can pick this up next sprint.

Change #1023808 abandoned by Eric Gardner:

[design/codex@main] Link: Use 12px icon for links.


Abandoning this patch because the acceptance criteria are not clear and it's becoming confusing. Feel free to file a new task with clearly-specified ACs and we can work on this next sprint.