Link, docs: Clarify icon usage within Links
Closed, InvalidPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Volker_E
	Thu, Apr 11, 11:44 PM

Description

Background

Currently, as of Codex v1.3.6, we have a misconception in our docs on icon usage within Links.
While the specifications already point out that there is only one specific icon put end of Link description

“Link with icon” features

as end icon and in normal size, which is against design agreements and common practice.

Goal

Clarify Link with Icon usage with correct use cases.

Details

	Subject	Repo	Branch	Lines +/-
	Link: Use 12px icon for links.	design/codex	main	+10 -12

Customize query in gerrit

Event Timeline

Volker_E created this task.Thu, Apr 11, 11:44 PM

Restricted Application added a project: Design-System-Team. · View Herald TranscriptThu, Apr 11, 11:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

CCiufo-WMF moved this task from Inbox to Up Next on the Design-System-Team board.Fri, Apr 12, 6:49 PM

CCiufo-WMF triaged this task as Low priority.Mon, Apr 15, 3:23 PM

CCiufo-WMF set the point value for this task to 1.Mon, Apr 15, 5:36 PM

CCiufo-WMF moved this task from Up Next to DST-Sprint-21 (2024-04-15 to 2024-04-26) on the Design-System-Team board.

CCiufo-WMF edited projects, added Design-System-Team (DST-Sprint-21 (2024-04-15 to 2024-04-26)); removed Design-System-Team.

Change #1023808 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] Link: Return to `x-small` rendering for :after icons

https://gerrit.wikimedia.org/r/1023808

gerritbot added a project: Patch-For-Review.Wed, Apr 24, 8:51 AM

Turns out the change to rems was the origin of the wrongly rendered icon.

Volker_E renamed this task from docs: Clarify icon usage within Links to Link, docs: Clarify icon usage within Links.Wed, Apr 24, 8:52 AM

Volker_E added a project: Regression.

Volker_E moved this task from Committed to Code Review on the Design-System-Team (DST-Sprint-21 (2024-04-15 to 2024-04-26)) board.

CCiufo-WMF moved this task from DST-Sprint-21 (2024-04-15 to 2024-04-26) to DST-Sprint-22 (2024-04-29 to 2024-05-10) on the Design-System-Team board.Tue, Apr 30, 4:00 PM

CCiufo-WMF edited projects, added Design-System-Team (DST-Sprint-22 (2024-04-29 to 2024-05-10)); removed Design-System-Team (DST-Sprint-21 (2024-04-15 to 2024-04-26)).

I'm closing this task as invalid because there are no clear acceptance criteria attached and we (the DST engineers) are somewhat confused about what actually needs to be done at this point.

Please file a new task with clear acceptance criteria about what specific changes are necessary and we can pick this up next sprint.

Change #1023808 abandoned by Eric Gardner:

[design/codex@main] Link: Use 12px icon for links.

Reason:

Abandoning this patch because the acceptance criteria are not clear and it's becoming confusing. Feel free to file a new task with clearly-specified ACs and we can work on this next sprint.