Page MenuHomePhabricator
Create Task
Maniphest T362473

Error thrown when applying a speedy deletion tag which has parameters
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Go to a page in the New Pages Feed
  • Go to the deletion flyout of the page triage toolbar
  • Choose a deletion tag with a param (e.g. G5)
  • Click "Mark for deletion"

What happens?:

  • The tag is applied, but the page does not refresh.
  • An error is thrown "PageTriage error type: Cannot read properties of undefined (reading 'replace')

File: delete.js
Page name: Main Page1
Skin: vector-2022
Dump of this.selectedTag: undefined"

  • Sometimes this error is in an alert box, and sometimes only in the console.

What should have happened instead?:
The tag should be applied and the page should refresh without errors.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
Latest master: 9739157caaa26b354fa22c7a5b974e1ebb97cc46

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
Do not send talk page notification when notif text or title is not definedmediawiki/extensions/PageTriagemaster+33 -3
Customize query in gerrit

Related Objects

Event Timeline

MPGuy2824 created this task.Apr 14 2024, 2:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 14 2024, 2:44 AM
DreamRimmer subscribed.Apr 14 2024, 2:55 AM
Novem_Linguae subscribed.Apr 14 2024, 2:55 AM

Has this worked in the past?

If so, let's 1) add a regression tag and 2) git bisect to figure out the patch that introduced the bug. This patch looks like it might have touched some code related to this.

Novem_Linguae moved this task from Backlog to Other bugs on the PageTriage board.Apr 14 2024, 2:56 AM
gerritbot added a comment.Apr 19 2024, 2:16 PM

Change #1021963 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/PageTriage@master] Do not send talk page notification when notif text or title is not defined

https://gerrit.wikimedia.org/r/1021963

Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptApr 19 2024, 2:16 PM
gerritbot added a project: Patch-For-Review.Apr 19 2024, 2:16 PM
Soda subscribed.Apr 19 2024, 2:26 PM
In T362473#9711646, @Novem_Linguae wrote:

Has this worked in the past?

If so, let's 1) add a regression tag and 2) git bisect to figure out the patch that introduced the bug. This patch looks like it might have touched some code related to this.

This is probably a old bug that resurfaced due to a config re-organization the recent tags patch does not appear to be the culprit

• Samwalton9-WMF moved this task from Inbox to Triaged on the Moderator-Tools-Team board.Apr 23 2024, 12:20 PM
jsn.sherman edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.May 15 2024, 7:12 PM
jsn.sherman moved this task from Ready to Code review on the Moderator-Tools-Team (Kanban) board.
jsn.sherman moved this task from Code review to Done on the Moderator-Tools-Team (Kanban) board.May 17 2024, 5:16 PM
gerritbot added a comment.May 17 2024, 5:39 PM

Change #1021963 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Do not send talk page notification when notif text or title is not defined

https://gerrit.wikimedia.org/r/1021963

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).May 17 2024, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 17 2024, 6:30 PM
Soda closed this task as Resolved.May 18 2024, 1:48 PM
Soda claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL