PHP Deprecated: The "post" source is deprecated, use "body" instead [Called from MediaWiki\Rest\Validator\ParamValidatorCallbacks::getValue]
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

None

Authored By

	dancy
	Apr 17 2024, 6:42 PM

Description

Error

mwversion: 1.43.0-wmf.1
reqId: 2dfefd8a-3017-4bdc-b6b2-505ae978a15e
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Deprecated: The "post" source is deprecated, use "body" instead [Called from MediaWiki\Rest\Validator\ParamValidatorCallbacks::getValue]

exception.trace

from /srv/mediawiki/php-1.43.0-wmf.1/includes/Rest/Validator/ParamValidatorCallbacks.php(60)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.43.0-wmf.1/includes/debug/MWDebug.php(379): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.43.0-wmf.1/includes/debug/MWDebug.php(350): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.43.0-wmf.1/includes/GlobalFunctions.php(798): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.43.0-wmf.1/includes/Rest/Validator/ParamValidatorCallbacks.php(43): wfDeprecatedMsg(string, string)
#5 /srv/mediawiki/php-1.43.0-wmf.1/includes/Rest/Validator/ParamValidatorCallbacks.php(60): MediaWiki\Rest\Validator\ParamValidatorCallbacks->getParamsFromSource(string)
#6 /srv/mediawiki/php-1.43.0-wmf.1/includes/libs/ParamValidator/TypeDef.php(120): MediaWiki\Rest\Validator\ParamValidatorCallbacks->getValue(string, NULL, array)
#7 /srv/mediawiki/php-1.43.0-wmf.1/includes/libs/ParamValidator/ParamValidator.php(525): Wikimedia\ParamValidator\TypeDef->getValue(string, array, array)
#8 /srv/mediawiki/php-1.43.0-wmf.1/includes/Rest/Validator/Validator.php(152): Wikimedia\ParamValidator\ParamValidator->getValue(string, array, array)
#9 /srv/mediawiki/php-1.43.0-wmf.1/includes/Rest/Handler.php(223): MediaWiki\Rest\Validator\Validator->validateParams(array)
#10 /srv/mediawiki/php-1.43.0-wmf.1/extensions/OAuth/src/Rest/Handler/AuthenticationHandler.php(99): MediaWiki\Rest\Handler->validate(MediaWiki\Rest\Validator\Validator)
#11 /srv/mediawiki/php-1.43.0-wmf.1/includes/Rest/Router.php(556): MediaWiki\Extension\OAuth\Rest\Handler\AuthenticationHandler->validate(MediaWiki\Rest\Validator\Validator)
#12 /srv/mediawiki/php-1.43.0-wmf.1/includes/Rest/Router.php(455): MediaWiki\Rest\Router->executeHandler(MediaWiki\Extension\OAuth\Rest\Handler\AccessToken)
#13 /srv/mediawiki/php-1.43.0-wmf.1/includes/Rest/EntryPoint.php(216): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#14 /srv/mediawiki/php-1.43.0-wmf.1/includes/MediaWikiEntryPoint.php(199): MediaWiki\Rest\EntryPoint->execute()
#15 /srv/mediawiki/php-1.43.0-wmf.1/rest.php(38): MediaWiki\MediaWikiEntryPoint->run()
#16 /srv/mediawiki/w/rest.php(3): require(string)
#17 {main}

Notes

This started during the 1.43.0-wmf.1 train rollout to group1. The rate is currently about 35 per 15 minutes. I'm making this a train blocker.

The relevant deprecation warning was added in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1017491 for T358560.

Details

Request URL: https://meta.wikimedia.org/w/rest.php/oauth2/access_token

Subject	Repo	Branch	Lines +/-
Revert "REST: Deprecate using "post" as the parameter source"	mediawiki/core	wmf/1.43.0-wmf.1	+30 -159
Revert "REST: Deprecate using "post" as the parameter source"	mediawiki/core	master	+30 -159
Replace deprecated PARAM_SOURCE => 'post' with 'body'	mediawiki/extensions/GrowthExperiments	master	+3 -3
Replace deprecated PARAM_SOURCE => 'post' with 'body'	mediawiki/extensions/OAuth	master	+31 -31

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	dancy	T361395 1.43.0-wmf.1 deployment blockers
		Resolved	PRODUCTION ERROR	None	T362817 PHP Deprecated: The "post" source is deprecated, use "body" instead [Called from MediaWiki\Rest\Validator\ParamValidatorCallbacks::getValue]

Event Timeline

dancy created this task.Apr 17 2024, 6:42 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2024, 6:42 PM

dancy triaged this task as Unbreak Now! priority.Apr 17 2024, 6:43 PM

dancy updated the task description. (Show Details)

dancy added a parent task: T361395: 1.43.0-wmf.1 deployment blockers.

Ping @daniel

matmarex added a project: MediaWiki-extensions-OAuth.Apr 17 2024, 6:58 PM

Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptApr 17 2024, 6:58 PM

I'm not familiar with the code, but it looks like we just need to replace PARAM_SOURCE => 'post' with PARAM_SOURCE => 'body' in a few places? I'll prepare a patch to do that.

Similar code is also found in the GrowthExperiments extension, I suppose the train just hasn't yet reached wikis where it's enabled: https://codesearch.wmcloud.org/deployed/?q=PARAM_SOURCE+%3D>+['"]post

Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 17 2024, 7:13 PM

In T362817#9724078, @matmarex wrote:

I'm not familiar with the code, but it looks like we just need to replace PARAM_SOURCE => 'post' with PARAM_SOURCE => 'body' in a few places? I'll prepare a patch to do that.

Thank you!

Change #1020904 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/OAuth@master] Replace deprecated PARAM_SOURCE => 'post' with 'body'

https://gerrit.wikimedia.org/r/1020904

Change #1020905 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/GrowthExperiments@master] Replace deprecated PARAM_SOURCE => 'post' with 'body'

https://gerrit.wikimedia.org/r/1020905

matmarex claimed this task.Apr 17 2024, 7:15 PM

Change #1020739 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Revert "REST: Deprecate using "post" as the parameter source"

https://gerrit.wikimedia.org/r/1020739

Change #1020910 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@wmf/1.43.0-wmf.1] Revert "REST: Deprecate using "post" as the parameter source"

https://gerrit.wikimedia.org/r/1020910

Probably best to revert for now, at least for 1.43.0-wmf.1, and then fix before Monday?

Sorry for the mess...

This may not have been such a good idea afterall. I'll think about it some more before re-submitting.

Change #1020904 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/OAuth@master] Replace deprecated PARAM_SOURCE => 'post' with 'body'

Reason:

Deprecation is being reverted instead

https://gerrit.wikimedia.org/r/1020904

Change #1020905 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/GrowthExperiments@master] Replace deprecated PARAM_SOURCE => 'post' with 'body'

Reason:

Deprecation is being reverted instead

https://gerrit.wikimedia.org/r/1020905

matmarex removed matmarex as the assignee of this task.Apr 17 2024, 8:01 PM

matmarex unsubscribed.Apr 17 2024, 8:19 PM

Change #1020739 merged by jenkins-bot:

[mediawiki/core@master] Revert "REST: Deprecate using "post" as the parameter source"

https://gerrit.wikimedia.org/r/1020739

Zabe subscribed.Apr 17 2024, 9:16 PM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.2; 2024-04-23).Apr 17 2024, 10:00 PM

Change #1020910 merged by jenkins-bot:

[mediawiki/core@wmf/1.43.0-wmf.1] Revert "REST: Deprecate using "post" as the parameter source"

https://gerrit.wikimedia.org/r/1020910

Mentioned in SAL (#wikimedia-operations) [2024-04-17T22:24:51Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:1020910|Revert "REST: Deprecate using "post" as the parameter source" (T362817)]]

Mentioned in SAL (#wikimedia-operations) [2024-04-17T22:27:58Z] <zabe@deploy1002> jforrester and zabe: Backport for [[gerrit:1020910|Revert "REST: Deprecate using "post" as the parameter source" (T362817)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-04-17T22:42:06Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:1020910|Revert "REST: Deprecate using "post" as the parameter source" (T362817)]] (duration: 17m 14s)

Zabe closed this task as Resolved.Apr 17 2024, 10:48 PM

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.1; 2024-04-16); removed MW-1.43-notes (1.43.0-wmf.2; 2024-04-23).Apr 17 2024, 11:00 PM

I wrote a proposal for an alternative to deprecating "post" parameters: T362850: REST: clarify the relationship between "post" and "body" parameters

Urbanecm_WMF subscribed.Apr 18 2024, 10:16 AM

daniel mentioned this in T362850: REST: clarify the relationship between "post" and "body" parameters.Apr 25 2024, 5:03 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 26 2024, 4:46 PM