Page MenuHomePhabricator

remove jquery-ui button() from toolbar
Closed, ResolvedPublic3 Estimated Story Points

Description

As of 2024-04-17, a quick search for .button() turns up 29 results in the PageTriage extension:
https://codesearch.wmcloud.org/things/?q=button%5C%28&files=&excludeFiles=&repos=Extension%3APageTriage
These all show up in the curation toolbar, which is undergoing an incremental migration to Vue.js (which would also allow for codex). Since the migration may take a while to be completed, we should start with simple method replacements where possible for the impacted modules.

for example, to disable/enable buttons in pure JavaScript, instead of :

$( '#idval' ).button( 'enable' );

do:

document.getElementById( 'idval' ).removeAttribute( 'disabled' );

instead of:

$( '#idval' ).button( 'disable' );

do:

document.getElementById( 'idval' ).setAttribute( 'disabled', 'disabled' );

Event Timeline

We estimated this as an 8 simply due to the time of dealing with each instance plus testing; we'll break it up into subtasks. Let's set each subtask to 3 points

Kgraessle updated the task description. (Show Details)

Change #1113576 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/PageTriage@master] Remove jquery-ui button() from PageTriage and replace with codex

https://gerrit.wikimedia.org/r/1113576

Scardenasmolinar changed the task status from Open to In Progress.Jan 22 2025, 11:10 PM
Scardenasmolinar assigned this task to Soda.
Scardenasmolinar set the point value for this task to 3.
Scardenasmolinar moved this task from Ready to Eng review on the Moderator-Tools-Team (Kanban) board.

I had one issue testing this locally, when you select tags the button is not updating with the number of tags selected, see screenshot below

Screenshot 2025-01-23 at 9.21.45 AM.png (463×592 px, 83 KB)

I had one issue testing this locally, when you select tags the button is not updating with the number of tags selected, see screenshot below

Screenshot 2025-01-23 at 9.21.45 AM.png (463×592 px, 83 KB)

Ah I missed that, should be fixed now!

We estimated this as an 8 simply due to the time of dealing with each instance plus testing; we'll break it up into subtasks. Let's set each subtask to 3 points

We definitely over estimated this one; this probably could have been a single 5 point task.

Change #1113576 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Remove jquery-ui button() from PageTriage and replace with codex

https://gerrit.wikimedia.org/r/1113576

Verified working as expected on enwiki beta.

leaving open until deployed to enwiki production.

@Samwalton9-WMF I think this is one either you or Jason needs to QA on enwiki.

@Samwalton9-WMF I think this is one either you or Jason needs to QA on enwiki.

I can test this, but not sure exactly what steps I should be going through - just clicking various buttons in the curation toolbar?

@Samwalton9-WMF I think this is one either you or Jason needs to QA on enwiki.

I can test this, but not sure exactly what steps I should be going through - just clicking various buttons in the curation toolbar?

Yep! Just to make sure the buttons still work as expected.

Resolving this on the basis we'd probably know by now if users were encountering any issues. I've asked in the PageTriage discord if there have been any unexpected behaviours, will re-open if so.