Page MenuHomePhabricator

[Refactor] Get rid of "auto/<#>" and "literal/<name>" internal ref IDs
Open, Needs TriagePublic

Description

These IDs shouldn't be necessary, it seems that they were only introduced to handle the one edge case in which an unnamed ref is reused, and then given a name after the page is saved. Instead, we would like to break this behavior into several pieces:

  • A new property such as originalNamewould make it possible to answer the question "was this a named ref in the last saved version of the document?", which is currently answered by matching "auto/" against the opaque, internal ID.
  • When an unnamed ref is reused, we would like to give it a name immediately.
  • The internal ID should be removed entirely.

Event Timeline

Change #1005798 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Use original ref name instead of parsing internal listKey

https://gerrit.wikimedia.org/r/1005798

Change #1023842 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Mark private MWReferenceModel setters as such

https://gerrit.wikimedia.org/r/1023842

Change #1023843 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Drop unused setters from MWReferenceModel class

https://gerrit.wikimedia.org/r/1023843

Change #1023849 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Drop separate MWReferenceModel.parentDoc property

https://gerrit.wikimedia.org/r/1023849

Change #1023842 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Mark private MWReferenceModel setters as such

https://gerrit.wikimedia.org/r/1023842

Change #1023843 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Drop unused setters from MWReferenceModel class

https://gerrit.wikimedia.org/r/1023843

Change #1005501 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Don't call things "attrs" that aren't mw.attrs

https://gerrit.wikimedia.org/r/1005501

Change #1023849 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Drop separate MWReferenceModel.parentDoc property

https://gerrit.wikimedia.org/r/1023849

Change #1031012 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Remove separate private deferDoc property in ve.dm.MWReferenceModel

https://gerrit.wikimedia.org/r/1031012

Change #1005501 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Don't call things "attrs" that aren't mw.attrs

https://gerrit.wikimedia.org/r/1005501

Change #1031012 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Remove separate private deferDoc property in ve.dm.MWReferenceModel

https://gerrit.wikimedia.org/r/1031012

thiemowmde moved this task from Doing to Sprint Backlog on the WMDE-TechWish-Sprint-2024-05-08 board.
thiemowmde subscribed.

Change #1005798 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Cite@master] Use original ref name instead of parsing internal listKey

https://gerrit.wikimedia.org/r/1005798