Page MenuHomePhabricator

Move ReferencePreviews i18n messages from Popups to Cite
Open, Needs TriagePublic

Description

There are still some i18n messages in the Page-Previews codebase that now should go to the Cite extension because it's responsible for the Reference Previews .

They are mostly prefixed with popups-refpreview-. Probably it's best to:

  • Look for some guideline how to do that, or ask Raymond what's best
  • Move i18n en and qqq to Cite and stick to the names and in parallel remove them from the Popups extension
  • Wait for the import of the translations and deployment.
  • Ask communities with overrides to either create a copy for the new key name, remove the override or put it on translate wiki
  • Rename keys in the Cite extension and add fall-backs for old messages to address on-wiki overrides

[] Copy any on-wiki message overrides and make it clear that the old keys are deprecated.
[] Remove the fallback mechanism for the popups- keys in Cite

  • Wait for the deployment of the renames
  • Ask the communities with override to remove the deprecated overrides

Note, that popups-refpreview-user-preference-label is part of the user settings that are still created by the Popups extension. See T363162: Move ReferencePreviews user setting creation from Popups to Cite

Event Timeline

@Raymond could you guide me in how to do this best? What would be most helpful?

Should we copy over and rename the messages with all their .json language variants to the new extension and let the bot sync it upstream with translate wiki?

or

Should we just copy the en and qqq parts, leave the name the same for now and you have some magic to sync the language variants? ( and then we rename it? )

or

Do you have some magic in the translate wiki to do all of that at once and then bot sync the messages magically into the codebase ^^'?

In T363156#9744886, @WMDE-Fisch hat geschrieben:

@Raymond could you guide me in how to do this best? What would be most helpful?

Should we copy over and rename the messages with all their .json language variants to the new extension and let the bot sync it upstream with translate wiki?

or

Should we just copy the en and qqq parts, leave the name the same for now and you have some magic to sync the language variants? ( and then we rename it? )

or

Do you have some magic in the translate wiki to do all of that at once and then bot sync the messages magically into the codebase ^^'?

@WMDE-Fisch How many messages have to be moved?

3rd solution should be OK, but both patched have to be merged at the (nearly) same time.

Change #1024633 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Copy ReferencePreviews i18n keys from Popups

https://gerrit.wikimedia.org/r/1024633

WMDE-Fisch moved this task from Doing to Sprint Backlog on the WMDE-TechWish-Sprint-2024-04-24 board.

Anybody feel free to grab this. I will not be able to work on this during the nest 2 1/2 weeks.

Change #1027515 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Copy ReferencePreviews related i18n messages over to Cite

https://gerrit.wikimedia.org/r/1027515

Change #1024633 abandoned by WMDE-Fisch:

[mediawiki/extensions/Cite@master] Copy ReferencePreviews i18n keys from Popups

Reason:

Using a different approach see I788c16c5bddc0df7f00dbbc39625b9adaa5bf184

https://gerrit.wikimedia.org/r/1024633

Change #1038702 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Popups@master] Remove most ReferencePreviews related i18n messages

https://gerrit.wikimedia.org/r/1038702

Change #1027515 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Move most ReferencePreviews related i18n messages over to Cite

https://gerrit.wikimedia.org/r/1027515

Change #1038702 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Remove most ReferencePreviews related i18n messages

https://gerrit.wikimedia.org/r/1038702

Move of the transtions were done today: Popups --> Cite

Change #1050646 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Rename ReferencePreviews i18n keys from Popups

https://gerrit.wikimedia.org/r/1050646

Resourceloader CI tests fail when I try to load message keys that do not exist in the code. So I changed the plan again \o/