Page MenuHomePhabricator
Create Task
Maniphest T363357

Show temporary account contributions from a given IP address on Special:IPContributions
Open, Needs TriagePublic
Actions

Description

Create a new special page, Special:IPContributions, that works like Special:Contributions but shows contributions from temporary accounts using a particular IP address.

  • Access is limited in the same way as IP reveal
  • Access is logged
  • Valid targets are an IP address or range (within the same limits as for Special:Contributions)

See T361867#9723850 for background.

Details

SubjectRepoBranchLines +/-
SpecialPageInitListHandler: Use TempUserConfigmediawiki/extensions/CheckUsermaster+6 -7
Display temp account contributions on Special:IPContributionsmediawiki/extensions/CheckUsermaster+618 -0
ipReveal.js: Link to Special:IPContributions from the revealed IPmediawiki/extensions/CheckUsermaster+13 -3
Follow-up fixes to tests of SpecialIPContributionsmediawiki/extensions/CheckUsermaster+30 -6
ContributionsSpecialPage: Do not run pager query if form is not validmediawiki/coremaster+5 -0
ContributionsSpecialPage: Make service properties visible to subclassesmediawiki/coremaster+7 -8
Revert "Show temp account edits on Special:Contributions for an IP address"mediawiki/extensions/CheckUsermaster+0 -339
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Apr 24 2024, 5:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 24 2024, 5:17 PM
Tchanders mentioned this in T363358: Create extendable parent classes for special pages showing contributions lists.Apr 24 2024, 5:21 PM
Tchanders mentioned this in T363362: Show temporary account deleted contributions from a given IP address on Special:IPContributions.Apr 24 2024, 5:25 PM
Tchanders added a parent task: T363362: Show temporary account deleted contributions from a given IP address on Special:IPContributions.
Tchanders mentioned this in T361867: Display contributions from temporary accounts on Special:Contributions for IP ranges.Apr 24 2024, 5:27 PM
Tchanders merged a task: T361867: Display contributions from temporary accounts on Special:Contributions for IP ranges.
Tchanders added subscribers: RP88, Dreamy_Jazz, kostajh.
Johannnes89 subscribed.Apr 24 2024, 6:17 PM
Tchanders claimed this task.May 1 2024, 10:57 AM
Tchanders moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)) board.
kostajh updated the task description. (Show Details)May 3 2024, 2:49 PM
gerritbot added a comment.May 7 2024, 5:57 PM

Change #1020820 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] ipReveal.js: Link to Special:IPContributions from the revealed IP

https://gerrit.wikimedia.org/r/1020820

gerritbot added a project: Patch-For-Review.May 7 2024, 5:57 PM

Change #1028877 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] WIP Display temp account contributions on Special:IPContributions

https://gerrit.wikimedia.org/r/1028877

Tchanders edited projects, added Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)); removed Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)).May 13 2024, 9:16 AM
Tchanders moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.May 13 2024, 9:28 AM
gerritbot added a comment.May 20 2024, 9:46 AM

Change #1034045 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] ContributionsSpecialPage: Make service properties visible to subclasses

https://gerrit.wikimedia.org/r/1034045

gerritbot added a comment.May 20 2024, 11:30 AM

Change #1034057 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] ContributionsSpecialPage: Do not run pager query if for is not valid

https://gerrit.wikimedia.org/r/1034057

gerritbot added a comment.May 20 2024, 5:50 PM

Change #1034133 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] Revert "Show temp account edits on Special:Contributions for an IP address"

https://gerrit.wikimedia.org/r/1034133

gerritbot added a comment.May 20 2024, 6:48 PM

Change #1034133 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Revert "Show temp account edits on Special:Contributions for an IP address"

https://gerrit.wikimedia.org/r/1034133

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).May 20 2024, 7:00 PM
gerritbot added a comment.May 21 2024, 1:22 PM

Change #1034045 merged by jenkins-bot:

[mediawiki/core@master] ContributionsSpecialPage: Make service properties visible to subclasses

https://gerrit.wikimedia.org/r/1034045

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.7; 2024-05-28); removed MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).May 21 2024, 2:00 PM
Tchanders moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.EditedMay 21 2024, 8:36 PM
  • Access is logged

Exactly how depends on the answer to T364902. We should spin this AC out into a separate task.

gerritbot added a comment.May 22 2024, 1:57 PM

Change #1034057 merged by jenkins-bot:

[mediawiki/core@master] ContributionsSpecialPage: Do not run pager query if form is not valid

https://gerrit.wikimedia.org/r/1034057

gerritbot added a comment.May 22 2024, 1:59 PM

Change #1028877 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Display temp account contributions on Special:IPContributions

https://gerrit.wikimedia.org/r/1028877

gerritbot added a comment.May 22 2024, 8:39 PM

Change #1035042 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Follow-up fixes to tests of SpecialIPContributions

https://gerrit.wikimedia.org/r/1035042

gerritbot added a comment.May 23 2024, 1:30 PM

Change #1035042 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Follow-up fixes to tests of SpecialIPContributions

https://gerrit.wikimedia.org/r/1035042

gerritbot added a comment.Tue, May 28, 12:09 PM

Change #1020820 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] ipReveal.js: Link to Special:IPContributions from the revealed IP

https://gerrit.wikimedia.org/r/1020820

Maintenance_bot removed a project: Patch-For-Review.Tue, May 28, 12:31 PM
Tchanders closed subtask T363358: Create extendable parent classes for special pages showing contributions lists as Resolved.Tue, May 28, 12:55 PM
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.8; 2024-06-04); removed MW-1.43-notes (1.43.0-wmf.7; 2024-05-28).Tue, May 28, 1:01 PM
Tchanders moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.Wed, May 29, 1:50 PM

Testing notes

Special:IPContributions should look like Special:Contributions, with the same form filters and the same information in the results lists.

Special:IPContributions should only accept an IP address or IP range target. It should never show results from fully registered users.

Special:IPContributions should only be available:

  • when temp accounts are enabled
  • to users with the checkuser-temporary-account-no-preference OR the checkuser-temporary-account right with the preference checked
Tchanders mentioned this in T366178: Add reciprocal links between Special:Contributions and Special:IPContributions.Wed, May 29, 1:54 PM
Dreamy_Jazz moved this task from General / Unsorted to Temporary account IP reveal on the CheckUser board.Fri, May 31, 11:47 AM
dom_walden edited projects, added Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)); removed Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)).Mon, Jun 3, 10:09 AM
dom_walden moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)) board.
Dreamy_Jazz closed subtask T366178: Add reciprocal links between Special:Contributions and Special:IPContributions as Resolved.Mon, Jun 3, 4:08 PM
Tchanders moved this task from Backlog to Create/update essential tools/anti-abuse management on the Temporary accounts board.Tue, Jun 4, 1:56 PM
Tchanders edited projects, added Temporary accounts (Create/update essential tools/anti-abuse management); removed Temporary accounts.
gerritbot added a comment.Fri, Jun 7, 12:46 PM

Change #1040149 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/CheckUser@master] SpecialPageInitListHandler: Use TempUserConfig

https://gerrit.wikimedia.org/r/1040149

gerritbot added a project: Patch-For-Review.Fri, Jun 7, 12:46 PM
gerritbot added a comment.Fri, Jun 7, 1:19 PM

Change #1040149 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] SpecialPageInitListHandler: Use TempUserConfig

https://gerrit.wikimedia.org/r/1040149

Maintenance_bot removed a project: Patch-For-Review.Fri, Jun 7, 1:30 PM
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.9; 2024-06-11); removed MW-1.43-notes (1.43.0-wmf.8; 2024-06-04).Fri, Jun 7, 2:00 PM
dom_walden edited projects, added Trust and Safety Product Sprint (Sprint 12 (Jun 24 - July 5)); removed Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)).Tue, Jun 25, 10:45 AM
dom_walden moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint 12 (Jun 24 - July 5)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL