Page MenuHomePhabricator
Create Task
Maniphest T363362

Show temporary account deleted contributions from a given IP address on Special:IPContributions
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Similarly to T363357, show deleted contributions on Special:IPContributions. This might involve making a separate pager and having a "deleted" mode for the special page, rather than combining the two lists into one.

Details

SubjectRepoBranchLines +/-
Add archived revisions mode for Special:IPContributionsmediawiki/extensions/CheckUsermaster+204 -29
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Apr 24 2024, 5:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 24 2024, 5:25 PM
Tchanders added a subtask: T363357: Show temporary account contributions from a given IP address on Special:IPContributions.Apr 24 2024, 5:25 PM
Tchanders added a parent task: T358852: [Epic] Display temporary account contributions on Special:Contributions for IP addresses and IP ranges.
Tchanders edited projects, added Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)); removed Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)).May 13 2024, 9:24 AM
TAdeleye_WMF set the point value for this task to 2.May 13 2024, 9:34 AM
Tchanders moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.May 13 2024, 9:39 AM
Dreamy_Jazz subscribed.May 28 2024, 5:01 PM

It would be nice to use a UNION query to combine the results like in Special:Investigate queries. However, this didn't seem to be an easy implementation when I tried it just now.

Dreamy_Jazz moved this task from General / Unsorted to Temporary account IP reveal on the CheckUser board.May 31 2024, 11:47 AM
Tchanders claimed this task.May 31 2024, 1:27 PM
Tchanders moved this task from Ready to In Progress on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.
Tchanders edited projects, added Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)); removed Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)).Jun 3 2024, 10:09 AM
Tchanders moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)) board.
gerritbot added a comment.Jun 3 2024, 5:28 PM

Change #1038403 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] WIP Add deleted mode for Special:IPContributions

https://gerrit.wikimedia.org/r/1038403

gerritbot added a project: Patch-For-Review.Jun 3 2024, 5:28 PM
Tchanders moved this task from Backlog to Create/update essential tools/anti-abuse management on the Temporary accounts board.Jun 4 2024, 12:58 PM
Tchanders edited projects, added Temporary accounts (Create/update essential tools/anti-abuse management); removed Temporary accounts.
PatchDemoBot added a comment.Jun 10 2024, 5:10 PM

Test wiki created on Patch demo by Tchanders using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/aa74df7536/w

Tchanders mentioned this in T367121: Design review and user testing for Special:IPContributions.Jun 10 2024, 9:16 PM
Tchanders mentioned this in T366510: Allow ContributionsPager to fetch and show revisions from the `revision` or `archive` table.Jun 13 2024, 4:08 PM
Tchanders added a comment.EditedJun 14 2024, 7:11 PM

Testing/review notes

Needs:

  • CheckUser loaded
  • Temp accounts enabled
  • A user with the right to reveal IP and the right to see deleted pages (deletedhistory)

Steps:

  • Make some contributions to an article from multiple temporary users using the same IP address
  • Delete the article
  • Visit Special:IPContributions/<theipaddress> and click on the "Deleted contributions" tab

What should be seen:

  • The contributions to the deleted article from all the temp accounts using that IP address
  • The rows should contain similar information and links, when compared to the rows in Special:DeletedContributions
  • The rows may contain additional information (e.g. diff size)
  • Special:IPContributions/<rangewiththeipaddress> should show the same rows (or more if there are contribitions from other IPs in the range)
Tchanders moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)) board.Jun 14 2024, 7:11 PM
Tchanders edited projects, added Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)); removed Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)).Jun 25 2024, 10:42 AM
Tchanders moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.
Dreamy_Jazz closed subtask T366510: Allow ContributionsPager to fetch and show revisions from the `revision` or `archive` table as Resolved.Jun 25 2024, 10:46 AM
Tchanders edited projects, added Temporary accounts (Blockers to testwiki deployment); removed Temporary accounts (Create/update essential tools/anti-abuse management).Wed, Jul 3, 3:04 PM
Tchanders closed subtask T363357: Show temporary account contributions from a given IP address on Special:IPContributions as Resolved.
gerritbot added a comment.Fri, Jul 5, 7:44 PM

Change #1038403 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add archived revisions mode for Special:IPContributions

https://gerrit.wikimedia.org/r/1038403

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.13; 2024-07-09).Fri, Jul 5, 8:00 PM
Tchanders moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.Tue, Jul 9, 8:41 AM
Maintenance_bot removed a project: Patch-For-Review.Tue, Jul 9, 7:52 PM
Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.Thu, Jul 11, 1:49 AM
Djackson-ctr subscribed.

I have verified the new code has been implemented and is functioning and displaying as expected.

image.png (382×890 px, 43 KB)

image.png (361×899 px, 41 KB)

kostajh closed this task as Resolved.Thu, Jul 11, 6:04 AM
Tchanders mentioned this in T370438: Improve feature parity between Special:Contributions and Special:DeletedContributions.Thu, Jul 18, 4:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits