| Jdlrobson | |
| Mon, Apr 29, 11:10 PM |
| F53045403: screenshot 329.png | |
| Tue, May 14, 12:57 AM |
| F53045222: screenshot 328.png | |
| Tue, May 14, 12:57 AM |
| F50772894: screenshot 312.png | |
| Tue, May 7, 11:55 PM |
| F50772884: screenshot 311.png | |
| Tue, May 7, 11:55 PM |
| F50772828: screenshot 315.png | |
| Tue, May 7, 11:55 PM |
| F50772798: screenshot 314.png | |
| Tue, May 7, 11:55 PM |
| F50772764: screenshot 313.png | |
| Tue, May 7, 11:55 PM |
| F50772735: screenshot 310.png | |
| Tue, May 7, 11:55 PM |
All elements appear in night theme without any color contrast issues
See red boxes for color contrast issues
Change #1027000 had a related patch set uploaded (by Simon04; author: Simon04):
[mediawiki/extensions/MultimediaViewer@master] Use Codex colors to fix dark mode
Change #1027000 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Use Codex colors to fix dark mode
Change #1027250 had a related patch set uploaded (by Jdlrobson; author: Simon04):
[mediawiki/extensions/MultimediaViewer@master] Fix Codex icons on progressive buttons in dark mode
...
...
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MultimediaViewer/+/1027000 changed the background in light mode to grey, which jars with the tab selector, and doesn't match the designs posted on T340258:
Status: ❌ Fail
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA
Test Artifact(s):
Visit a desktop page in night theme with image e.g. https://patchdemo.wmflabs.org/wikis/abfa33da2d/wiki/Dog?vectornightmode=1
Click image
Expected results
❌ AC1: All elements appear in night theme without any color contrast issues
Just noticed that this ended up on production on Commons even with the bug that @Esanders found and what @Edtadros brought up. You can see it on any file, example here.
Change #1029665 had a related patch set uploaded (by Simon04; author: Simon04):
[mediawiki/extensions/MultimediaViewer@master] Fix dialog background color
Change #1029665 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Fix dialog background color
Status: ❌ Fail
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA
Test Artifact(s):
Visit a desktop page in night theme with image e.g. https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Dog&vectornightmode=1
Click image
Expected results
❌ AC1: All elements appear in night theme without any color contrast issues
The remaining color contrast issues look like templates specific to that page and are not in our control so we can call this a pass.
