[Bug] MultimediaViewer is not compatible with desktop night theme
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Apr 29 2024, 11:10 PM

Description

NOTE: Blocked on T354889. Initially detected while testing patchdemo

Steps to reproduce

Visit a desktop page in night theme with image e.g. https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Dog&vectornightmode=1
Click image

Expected results

All elements appear in night theme without any color contrast issues

Actual results

See red boxes for color contrast issues

Screenshot 2024-04-29 at 4.09.11 PM.png (1×2 px, 1 MB)

Screenshot 2024-04-29 at 4.09.30 PM.png (1×2 px, 1 MB)

Screenshot 2024-04-29 at 4.09.47 PM.png (698×1 px, 166 KB)

Screenshot 2024-04-29 at 4.10.07 PM.png (1×1 px, 162 KB)

Screenshot 2024-04-29 at 4.08.48 PM.png (1×2 px, 1 MB)

Environments observed

Browser version:
OS version:
Device model:
Device language:

QA Results - Beta

AC	Status	Details
1	✅	T363776#9792840 is a pass per T363776#9792858

QA Results - PROD

AC	Status	Details
1	✅	T363776#9827447 is a pass per T363776#9792858

Details

Other Assignee: simon04

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix dialog background color	mediawiki/extensions/MultimediaViewer	master	+4 -4
	Use Codex colors to fix dark mode	mediawiki/extensions/MultimediaViewer	master	+29 -39

Customize query in gerrit

Related Objects

Mentioned In: T363372: Verify 1.43.0-wmf.5 deployment
T361975: [Session] 🥳 Wikimedia Hackathon 2024 Project Showcase & Closing
T340258: MMV should use Codex instead of mediawiki ui
Mentioned Here: T340258: MMV should use Codex instead of mediawiki ui
T354889: Vector 2022 should get night theme

Event Timeline

Jdlrobson created this task.Apr 29 2024, 11:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 29 2024, 11:10 PM

Jdlrobson added a project: Wikimedia-Hackathon-2024.Apr 30 2024, 12:19 AM

Jdlrobson moved this task from Backlog to Hacking project: Dark mode on the Wikimedia-Hackathon-2024 board.Apr 30 2024, 12:27 AM

ovasileva added a parent task: T363814: Release dark mode as a beta feature on desktop (May 15th) .Apr 30 2024, 5:40 PM

Jdlrobson triaged this task as High priority.May 1 2024, 2:25 AM

Jdlrobson added a subscriber: simon04.May 3 2024, 4:22 PM

Change #1027000 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/MultimediaViewer@master] Use Codex colors to fix dark mode

https://gerrit.wikimedia.org/r/1027000

gerritbot added a project: Patch-For-Review.May 3 2024, 6:25 PM

JScherer-WMF added subscribers: JScherer-WMF, mwilliams.May 3 2024, 6:26 PM

Change #1027000 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Use Codex colors to fix dark mode

https://gerrit.wikimedia.org/r/1027000

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.4; 2024-05-07).May 4 2024, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 4 2024, 5:30 PM

Jdlrobson assigned this task to Edtadros.May 4 2024, 7:02 PM

Jdlrobson moved this task from Backlog to QA on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 3) board.

Jdlrobson updated Other Assignee, added: simon04.

Change #1027250 had a related patch set uploaded (by Jdlrobson; author: Simon04):

[mediawiki/extensions/MultimediaViewer@master] Fix Codex icons on progressive buttons in dark mode

https://gerrit.wikimedia.org/r/1027250

gerritbot added a project: Patch-For-Review.May 4 2024, 9:04 PM

In T340258#9769835, @mwilliams wrote:

...

...

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MultimediaViewer/+/1027000 changed the background in light mode to grey, which jars with the tab selector, and doesn't match the designs posted on T340258:

Test Result - Beta

Status: ❌ Fail
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

Test Steps

Visit a desktop page in night theme with image e.g. https://patchdemo.wmflabs.org/wikis/abfa33da2d/wiki/Dog?vectornightmode=1
Click image
Expected results
❌ AC1: All elements appear in night theme without any color contrast issues

There are still a few contrast issues

Just noticed that this ended up on production on Commons even with the bug that @Esanders found and what @Edtadros brought up. You can see it on any file, example here.

Edtadros attached a referenced file: F50775189: image.png. (Show Details)May 9 2024, 4:55 PM

Change #1029665 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/MultimediaViewer@master] Fix dialog background color

https://gerrit.wikimedia.org/r/1029665

Change #1029665 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Fix dialog background color

https://gerrit.wikimedia.org/r/1029665

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.5; 2024-05-14); removed MW-1.43-notes (1.43.0-wmf.4; 2024-05-07).May 10 2024, 9:00 AM

@Edtadros should be ready for testing again.

Quiddity mentioned this in T361975: [Session] 🥳 Wikimedia Hackathon 2024 Project Showcase & Closing.May 13 2024, 6:51 PM

Edtadros updated the task description. (Show Details)May 14 2024, 12:46 AM

Test Result - Beta

Status: ❌ Fail
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

Test Steps

Visit a desktop page in night theme with image e.g. https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Dog&vectornightmode=1
Click image
Expected results
❌ AC1: All elements appear in night theme without any color contrast issues

This odd gradient "view more" bar doesn't show up unless you click the WCAG issue. I'm not sure what to make of it since it's not visible otherwise.

The remaining color contrast issues look like templates specific to that page and are not in our control so we can call this a pass.

Looks good, resolving.

Jdlrobson removed a parent task: T363814: Release dark mode as a beta feature on desktop (May 15th) .May 14 2024, 5:34 PM

Edtadros mentioned this in T363372: Verify 1.43.0-wmf.5 deployment.May 15 2024, 10:52 PM

Edtadros updated the task description. (Show Details)May 22 2024, 9:22 PM

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 125
Device: MBA
Emulated Device:NA

Test Artifact(s):

Test Steps

Visit a desktop page in night theme with image e.g. https://en.wikipedia.org/w/index.php?title=Dog&vectornightmode=1
Click image
Expected results
✅ AC1: All elements appear in night theme without any color contrast issues
Pass per T363776#9792858

This odd gradient "view more" bar doesn't show up unless you click the WCAG issue. I'm not sure what to make of it since it's not visible otherwise.
Pass per T363776#9792858

GMikesell-WMF added a project: Verified.May 23 2024, 7:56 PM

GMikesell-WMF updated the task description. (Show Details)

	F53045403: screenshot 329.png
	May 14 2024, 12:57 AM

	F53045222: screenshot 328.png
	May 14 2024, 12:57 AM

	F50772894: screenshot 312.png
	May 7 2024, 11:55 PM

	F50772884: screenshot 311.png
	May 7 2024, 11:55 PM

[Bug] MultimediaViewer is not compatible with desktop night themeClosed, ResolvedPublicBUG REPORTActions

Description

Steps to reproduce

Expected results

Actual results

Environments observed

QA Results - Beta

QA Results - PROD

Details

Related Objects

Event Timeline

Test Result - Beta

Test Steps

Test Result - Beta

Test Steps

Test Result - PROD

Test Steps

[Bug] MultimediaViewer is not compatible with desktop night theme
Closed, ResolvedPublicBUG REPORT
Actions