Maniphest T364062

GuidedTour external link buttons don't work
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Pppery
	May 3 2024, 4:05 AM

Tags

Referenced Files

None

Subscribers

Description

Steps to replicate the issue (include links if applicable):

Go to https://en.wikipedia.org/wiki/WP:TWA/1/Start?tour=twa1&step=7 while logged out
Click any of the buttons

What happens?:

Nothing

What should have happened instead?:

The buttons should point somewhere.

Other information (browser name/version, screenshots, etc.):
These are defined by https://en.wikipedia.org/wiki/MediaWiki:Guidedtour-tour-twa1.js as action: 'externalLink',. The issue appears to be in GuidedTour itself not the local gadget and is a regression from https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GuidedTour/+/982911 / T182050 by @Jdlrobson

Details

	Subject	Repo	Branch	Lines +/-
	Unbreak link buttons	mediawiki/extensions/GuidedTour	wmf/1.43.0-wmf.4	+12 -4
	Unbreak link buttons	mediawiki/extensions/GuidedTour	master	+12 -4

Customize query in gerrit

Related Objects

Mentioned Here: T182050: Remove all mediawiki.ui components and libraries in favor of Codex

Event Timeline

Pppery created this task.May 3 2024, 4:05 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptMay 3 2024, 4:05 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Pppery added a project: The-Wikipedia-Adventure.May 3 2024, 4:06 AM

TheresNoTime subscribed.May 3 2024, 6:55 AM

Thanks for the ping. I'll look into it.

Pppery moved this task from Backlog to Bug reports on the The-Wikipedia-Adventure board.May 5 2024, 12:38 AM

Change #1028872 had a related patch set uploaded (by Pppery; author: Pppery):

[mediawiki/extensions/GuidedTour@master] Unbreak link buttons

https://gerrit.wikimedia.org/r/1028872

gerritbot added a project: Patch-For-Review.May 7 2024, 5:18 PM

Pppery claimed this task.May 7 2024, 5:18 PM

aliu moved this task from Backlog to Bugs on the MediaWiki-extensions-GuidedTour board.May 7 2024, 9:22 PM

Etonkovidova moved this task from Inbox to Triaged on the Growth-Team board.May 8 2024, 12:50 AM

Change #1028872 merged by jenkins-bot:

[mediawiki/extensions/GuidedTour@master] Unbreak link buttons

https://gerrit.wikimedia.org/r/1028872

Pppery closed this task as Resolved.May 12 2024, 3:58 PM

Pppery removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.5; 2024-05-14).May 12 2024, 4:00 PM

Change #1030983 had a related patch set uploaded (by Jdlrobson; author: Pppery):

[mediawiki/extensions/GuidedTour@wmf/1.43.0-wmf.4] Unbreak link buttons

https://gerrit.wikimedia.org/r/1030983

gerritbot added a project: Patch-For-Review.May 13 2024, 6:48 PM

Change #1030983 merged by jenkins-bot:

[mediawiki/extensions/GuidedTour@wmf/1.43.0-wmf.4] Unbreak link buttons

https://gerrit.wikimedia.org/r/1030983

Mentioned in SAL (#wikimedia-operations) [2024-05-13T21:10:32Z] <ebernhardson@deploy1002> Started scap: Backport for [[gerrit:1030983|Unbreak link buttons (T364062)]]

Mentioned in SAL (#wikimedia-operations) [2024-05-13T21:12:58Z] <ebernhardson@deploy1002> jdlrobson and ebernhardson: Backport for [[gerrit:1030983|Unbreak link buttons (T364062)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Maintenance_bot removed a project: Patch-For-Review.May 13 2024, 9:31 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-13T21:32:32Z] <ebernhardson@deploy1002> Finished scap: Backport for [[gerrit:1030983|Unbreak link buttons (T364062)]] (duration: 22m 00s)

This has now been backported to production. Sorry for any disruption! cc @Quiddity

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.4; 2024-05-07); removed MW-1.43-notes (1.43.0-wmf.5; 2024-05-14).May 13 2024, 10:00 PM

@Mrb_Rafi FYI, see the latest update above ("This has now been backported to production), because I saw you mention this bug in the hackathon telegram/IRC. This 'backport' effort from Jon means the fix should be live immediately (instead of waiting for the weekly deployment train to reach the Wikipedias on Thursday). I hope that helps a bit, and sorry the bug disrupted part of your event.
[Edit: And thank you, Jon, for working on the backport and review!]

(For posterity's sake re Quiddity's comment: https://wm-bot.wmcloud.org/logs/%23wikimedia-hackathon/20240509.txt)