Page MenuHomePhabricator

Inverted OOUi icons (e.g. notifications, language) look different from Codex icons in night theme
Open, Stalled, HighPublicBUG REPORT

Description

NOTE: This is blocked on DST and T358246

Background
In T366337 and T365764 we decided to invert icons which were not using Codex. These decisions created an inconsistency with how icons appear in Vector 2022. On the long term we would want icons to have a uniform appearance across the experience.

Steps to replicate the issue (include links if applicable):

  • Be logged in
  • Enable dark mode on mobile site
  • Look at header of page

What happens?:

Notifications icon (the bell) is brighter than other icons, whether I have unread notifications or not

en.m.wikipedia.org_wiki_Ichthyotitan(iPhone SE).png (234×750 px, 17 KB)

What should have happened instead?:
Icons should have same color, as in light mode

en.m.wikipedia.org_wiki_Ichthyotitan(iPhone SE) (1).png (232×750 px, 17 KB)

This inconsistency problem also impacts the following icons:

  • language button on desktop
  • Echo icon on desktop when clicked.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

SToyofuku-WMF subscribed.

Can reproduce - guessing this is due to a mismatch of codex icons or something similar

Jdlrobson changed the task status from Open to Stalled.May 14 2024, 6:29 PM

I am not sure how we can fix this right now without adding technical debt (e.g. switching from Codex to OOUI). Marking as stalled until we have a plan on how to approach this.

Change #1038914 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Icons render consistently in night mode

https://gerrit.wikimedia.org/r/1038914

Jdlrobson renamed this task from Notifications icon is brighter than others in dark mode to Inverted OOUi icons (e.g. notifications, language) look different from Codex icons in night theme.Thu, Jun 6, 6:28 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson raised the priority of this task from Medium to High.Wed, Jun 12, 8:49 PM
Jdlrobson updated the task description. (Show Details)

Change #1038914 abandoned by Jdlrobson:

[mediawiki/skins/MinervaNeue@master] Icons render consistently in night mode

Reason:

We will talk to the Design Systems Team about this potential solution tomorrow.

https://gerrit.wikimedia.org/r/1038914

@Jdrewniak let us know how your discussion with DST goes!

In standup we agreed to pull this back into our backlog and to focus on a short-term fix for just the Echo notification.