UnexpectedValueException: Wikimedia\Rdbms\InsertQueryBuilder::execute can't have empty $rows value (via ORES SqlScoreStorage)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

service.version: 1.43.0-wmf.3
trace.id: d0f06f0c-209c-498e-b855-944283213fdd
Find trace.id in Logstash

labels.normalized_message

[{reqId}] {exception_url}   UnexpectedValueException: Wikimedia\Rdbms\InsertQueryBuilder::execute can't have empty $rows value

error.stack_trace

from /srv/mediawiki/php-1.43.0-wmf.3/includes/libs/rdbms/querybuilder/InsertQueryBuilder.php(324)
#0 /srv/mediawiki/php-1.43.0-wmf.3/extensions/ORES/includes/Storage/SqlScoreStorage.php(102): Wikimedia\Rdbms\InsertQueryBuilder->execute()
#1 /srv/mediawiki/php-1.43.0-wmf.3/extensions/ORES/includes/Services/FetchScoreJob.php(98): ORES\Storage\SqlScoreStorage->storeScores(array, Closure, array)
#2 /srv/mediawiki/php-1.43.0-wmf.3/extensions/EventBus/includes/JobExecutor.php(80): ORES\Services\FetchScoreJob->run()
#3 /srv/mediawiki/rpc/RunSingleJob.php(60): MediaWiki\Extension\EventBus\JobExecutor->execute(array)
#4 {main}

Impact

Notes

Noticing a number of these in 1.43.0-wmf.3 (T361397).

Related to T362901: UnexpectedValueException: Wikimedia\Rdbms\InsertQueryBuilder::execute can't have empty $rows value (via GlobalUsage)? This was masked on the MediaWiki New Errors ECS dashboard by the filter for that one.

Details

Request URL: https://mw-jobrunner.discovery.wmnet/rpc/RunSingleJob.php

	Subject	Repo	Branch	Lines +/-
	Avoid empty insert in SqlScoreStorage::storeScores	mediawiki/extensions/ORES	wmf/1.43.0-wmf.3	+14 -12
	Avoid empty insert in SqlScoreStorage::storeScores	mediawiki/extensions/ORES	master	+14 -12

Customize query in gerrit

Related Objects

Mentioned In: T344873: [{reqId}] {exception_url} UnexpectedValueException: Wikimedia\Rdbms\InsertQueryBuilder::execute can't have empty $rows value (via UserAgentClientHintsManager)
T364251: Distinct UnexpectedValueException thrown by QueryBuilders to avoid deduplication across different callers
Mentioned Here: T364251: Distinct UnexpectedValueException thrown by QueryBuilders to avoid deduplication across different callers
rEORS246b1f35fa3c: Migrate usage of Database::delete, insert, update and upsert to QueryBuilder
T361397: 1.43.0-wmf.3 deployment blockers
T362901: UnexpectedValueException: Wikimedia\Rdbms\InsertQueryBuilder::execute can't have empty $rows value (via GlobalUsage)

Event Timeline

brennen created this task.May 4 2024, 11:40 AM

Restricted Application added a project: Machine-Learning-Team. · View Herald TranscriptMay 4 2024, 11:40 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

brennen updated the task description. (Show Details)May 4 2024, 11:41 AM

brennen moved this task from Backlog to Logs/Train on the User-brennen board.May 4 2024, 6:24 PM

Change #1027247 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ORES@master] Avoid empty insert in SqlScoreStorage::storeScores

https://gerrit.wikimedia.org/r/1027247

gerritbot added a project: Patch-For-Review.May 4 2024, 7:21 PM

Was changed to InsertQueryBuilder in 246b1f35fa3c3108fc02ffee71deeaac2a97e505

Change #1027247 merged by jenkins-bot:

[mediawiki/extensions/ORES@master] Avoid empty insert in SqlScoreStorage::storeScores

https://gerrit.wikimedia.org/r/1027247

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.4; 2024-05-07).May 4 2024, 8:00 PM

Umherirrender mentioned this in T364251: Distinct UnexpectedValueException thrown by QueryBuilders to avoid deduplication across different callers.May 4 2024, 8:05 PM

Created T364251: Distinct UnexpectedValueException thrown by QueryBuilders to avoid deduplication across different callers to handle the logstash issue making this unseen.

Maintenance_bot removed a project: Patch-For-Review.May 4 2024, 8:30 PM

TheresNoTime merged a task: T364284: UnexpectedValueException: Wikimedia\Rdbms\InsertQueryBuilder::execute can't have empty $rows value (via ORES SqlScoreStorage).May 5 2024, 5:37 PM

TheresNoTime subscribed.

Zabe merged a task: T364411: UnexpectedValueException: Wikimedia\Rdbms\InsertQueryBuilder::execute can't have empty $rows value (via ORES SqlScoreStorage).May 7 2024, 5:34 PM

Zabe subscribed.

Change #1028583 had a related patch set uploaded (by Zabe; author: Umherirrender):

[mediawiki/extensions/ORES@wmf/1.43.0-wmf.3] Avoid empty insert in SqlScoreStorage::storeScores

https://gerrit.wikimedia.org/r/1028583

gerritbot added a project: Patch-For-Review.May 7 2024, 5:35 PM

Aklapper mentioned this in T344873: [{reqId}] {exception_url} UnexpectedValueException: Wikimedia\Rdbms\InsertQueryBuilder::execute can't have empty $rows value (via UserAgentClientHintsManager).May 7 2024, 5:43 PM

Umherirrender renamed this task from UnexpectedValueException: Wikimedia\Rdbms\InsertQueryBuilder::execute can't have empty $rows value to UnexpectedValueException: Wikimedia\Rdbms\InsertQueryBuilder::execute can't have empty $rows value (via ORES SqlScoreStorage).May 7 2024, 6:27 PM

This time I have kept the task open to make it easier to spot that the expection is fixed, but there are still two duplicates reported.

Is there another process to avoid duplicates from exception without backporting? Backports are also a risk, so exceptions with low rate (as expected here) could be easier fixed by the next train, but it seems that makes more trouble.

There were like ~4000 of these within the last 3 hours. So the fix is backport-worthy for me.

Change #1028583 merged by jenkins-bot:

[mediawiki/extensions/ORES@wmf/1.43.0-wmf.3] Avoid empty insert in SqlScoreStorage::storeScores

https://gerrit.wikimedia.org/r/1028583

Mentioned in SAL (#wikimedia-operations) [2024-05-07T20:24:17Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:1028583|Avoid empty insert in SqlScoreStorage::storeScores (T364218)]]

Mentioned in SAL (#wikimedia-operations) [2024-05-07T20:26:55Z] <zabe@deploy1002> zabe: Backport for [[gerrit:1028583|Avoid empty insert in SqlScoreStorage::storeScores (T364218)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Umherirrender closed this task as Resolved.May 7 2024, 8:29 PM

Maintenance_bot removed a project: Patch-For-Review.May 7 2024, 8:30 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-07T20:40:18Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:1028583|Avoid empty insert in SqlScoreStorage::storeScores (T364218)]] (duration: 16m 01s)

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.3; 2024-04-30); removed MW-1.43-notes (1.43.0-wmf.4; 2024-05-07).May 7 2024, 9:00 PM

isarantopoulos moved this task from Unsorted to Watching on the Machine-Learning-Team board.May 9 2024, 7:56 AM

UnexpectedValueException: Wikimedia\Rdbms\InsertQueryBuilder::execute can't have empty $rows value (via ORES SqlScoreStorage)Closed, ResolvedPublicPRODUCTION ERRORActions