[{reqId}] {exception_url} UnexpectedValueException: Wikimedia\Rdbms\InsertQueryBuilder::execute can't have empty $rows value (via UserAgentClientHintsManager)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

message

[{reqId}] {exception_url}   UnexpectedValueException: Wikimedia\Rdbms\InsertQueryBuilder::execute can't have empty $rows value

trace

from /srv/mediawiki/php-1.41.0-wmf.23/includes/libs/rdbms/querybuilder/InsertQueryBuilder.php(206)
#0 /srv/mediawiki/php-1.41.0-wmf.23/extensions/CheckUser/src/Services/UserAgentClientHintsManager.php(171): Wikimedia\Rdbms\InsertQueryBuilder->execute()
#1 /srv/mediawiki/php-1.41.0-wmf.23/extensions/CheckUser/src/Services/UserAgentClientHintsManager.php(105): MediaWiki\CheckUser\Services\UserAgentClientHintsManager->insertMappingRows(MediaWiki\CheckUser\ClientHints\ClientHintsData, integer, string, boolean)
#2 /srv/mediawiki/php-1.41.0-wmf.23/extensions/CheckUser/src/Api/Rest/Handler/UserAgentClientHintsHandler.php(94): MediaWiki\CheckUser\Services\UserAgentClientHintsManager->insertClientHintValues(MediaWiki\CheckUser\ClientHints\ClientHintsData, integer, string)
#3 /srv/mediawiki/php-1.41.0-wmf.23/includes/Rest/SimpleHandler.php(38): MediaWiki\CheckUser\Api\Rest\Handler\UserAgentClientHintsHandler->run(string, integer)
#4 /srv/mediawiki/php-1.41.0-wmf.23/includes/Rest/Router.php(517): MediaWiki\Rest\SimpleHandler->execute()
#5 /srv/mediawiki/php-1.41.0-wmf.23/includes/Rest/Router.php(422): MediaWiki\Rest\Router->executeHandler(MediaWiki\CheckUser\Api\Rest\Handler\UserAgentClientHintsHandler)
#6 /srv/mediawiki/php-1.41.0-wmf.23/includes/Rest/EntryPoint.php(195): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#7 /srv/mediawiki/php-1.41.0-wmf.23/includes/Rest/EntryPoint.php(135): MediaWiki\Rest\EntryPoint->execute()
#8 /srv/mediawiki/php-1.41.0-wmf.23/rest.php(31): MediaWiki\Rest\EntryPoint::main()
#9 /srv/mediawiki/w/rest.php(3): require(string)
#10 {main}

Impact

Caused by users submitting no Client Hints data in the API request.

Impact is limited and no data is lost by the exception occurring as no data was submitted.

Notes

Can be simulated by providing a body to the POST request of the empty dictionary.

Details

	Subject	Repo	Branch	Lines +/-
	clienthints: Return early on no DB rows in ::insertClientHintValues	mediawiki/extensions/CheckUser	master	+26 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		kostajh	T257893 [EPIC] Support User-Agent Client Hints header in CheckUser
		Resolved	PRODUCTION ERROR	Dreamy_Jazz	T344873 [{reqId}] {exception_url} UnexpectedValueException: Wikimedia\Rdbms\InsertQueryBuilder::execute can't have empty $rows value (via UserAgentClientHintsManager)

Event Timeline

Dreamy_Jazz created this task.Aug 23 2023, 11:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 23 2023, 11:26 PM

Dreamy_Jazz added a parent task: T257893: [EPIC] Support User-Agent Client Hints header in CheckUser.Aug 23 2023, 11:27 PM

Dreamy_Jazz updated the task description. (Show Details)Aug 23 2023, 11:29 PM

Dreamy_Jazz updated the task description. (Show Details)Aug 23 2023, 11:45 PM

Change 952018 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] clienthints: Return early on no DB rows in ::insertClientHintValues

https://gerrit.wikimedia.org/r/952018

gerritbot added a project: Patch-For-Review.Aug 23 2023, 11:54 PM

Dreamy_Jazz claimed this task.Aug 24 2023, 12:02 AM

Dreamy_Jazz added a project: Anti-Harassment (AHaT Sprint 32 - Baseball Cap).

Dreamy_Jazz moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.

Suggested QA steps:

Make an edit using Chrome with the network tab open
Right click on the API request to the client hints API (should be the item with the integer title) and click on "Copy as fetch"
Using the same account, make an edit on Firefox
Paste the fetch command into the Firefox console
Modify the command so that the body argument is defined as {}
Run the command
Ensure that the API request returns a 200 (and not a 500).

Dreamy_Jazz moved this task from Untriaged to Aug 2023 on the Wikimedia-production-error board.Aug 24 2023, 12:05 AM

Change 952018 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] clienthints: Return early on no DB rows in ::insertClientHintValues

https://gerrit.wikimedia.org/r/952018

Maintenance_bot removed a project: Patch-For-Review.Aug 24 2023, 11:30 AM

Dreamy_Jazz moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Aug 26 2023, 9:45 PM

Dreamy_Jazz moved this task from General / Unsorted to CheckUser on the CheckUser board.Aug 29 2023, 11:37 AM

Dreamy_Jazz moved this task from CheckUser to General / Unsorted on the CheckUser board.

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 30 2023, 2:02 AM

I no longer see an error when making a client hint request with {}.

Test environment: local docker CheckUser 2.5 (9ed2b65) 18:12, 29 August 2023.

kostajh moved this task from Backlog to Release 0 (Pilot wikis) on the http-client-hints board.Sep 26 2023, 11:32 AM

kostajh edited projects, added http-client-hints (Release 0 (Pilot wikis)); removed http-client-hints.

kostajh closed this task as Resolved.Sep 26 2023, 12:48 PM

Seeing a spike in these errors on jobrunner hosts today.

In T344873#9777427, @hnowlan wrote:

Seeing a spike in these errors on jobrunner hosts today.

Covered in T364218: UnexpectedValueException: Wikimedia\Rdbms\InsertQueryBuilder::execute can't have empty $rows value (via ORES SqlScoreStorage)