Page MenuHomePhabricator

Distinct UnexpectedValueException thrown by QueryBuilders to avoid deduplication across different callers
Open, Needs TriagePublic

Description

In T364218: UnexpectedValueException: Wikimedia\Rdbms\InsertQueryBuilder::execute can't have empty $rows value (via ORES SqlScoreStorage) @brennen wrote:

Related to T362901: UnexpectedValueException: Wikimedia\Rdbms\InsertQueryBuilder::execute can't have empty $rows value (via GlobalUsage)? This was masked on the MediaWiki New Errors ECS dashboard by the filter for that one.

Unfortunally all the UnexpectedValueException thrown by the query builder are issues by itself and should not deduplicated in the logstash.

So adding the caller to the exception message?

Relevant classes:

  • DeleteQueryBuilder
  • InsertQueryBuilder
  • ReplaceQueryBuilder
  • SelectQueryBuilder
  • UnionQueryBuilder
  • UpdateQueryBuilder